2 Commits

Author	SHA1	Message	Date
David Goldman	ea9888b8f6	[clangd] Respect --sysroot argument if it is set ... Summary: - Since `--sysroot` is a superset of the `-isysroot` argument, we shouldn't add the `-isysroot` if we detect a `--sysroot` flag. Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D72415	2020-01-09 11:02:58 -05:00
Sam McCall	99768b243c	[clangd] (take 2) Try harder to find a plausible clang as argv0, particularly on Mac. ... Summary: This was originally committed in 88bccded8f, and reverted in 93f77617ab. This version is now much more testable: the "detect toolchain properties" part is still not tested but also not active in tests. All the command manipulation based on the detected properties is directly tested, and also not active in other tests. Fixes https://github.com/clangd/clangd/issues/211 Fixes https://github.com/clangd/clangd/issues/178 Reviewers: kbobyrev, ilya-biryukov Subscribers: mgorny, ormris, cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay Tags: #clang Differential Revision: https://reviews.llvm.org/D71029	2019-12-06 09:47:03 +01:00