[locale] Update for these changes.
[qrvthtool] Update for localized RVT-H error strings:
- WorkerObject: Don't include the error code in the message when
emitting finished().
- QRvtHWindow: Handle RVT-H error codes better:
- If -ECANCELED is returned, show the message as-is, since the operation
was cancelled.
- If it's an RVT-H error, use QCoreApplication::translate() with the
"RvtH|Error" context and rvth_error(err) string.
- If it's a POSIX error, use rvth_error() anyway for now.
FIXME: Need to properly translate POSIX errors.
Use a '%1' placeholder for "doExtract" and "doImport", since the messages
are all the same except for the function name.
[locale] Update localizations for this change.
dialog-close is black in the KDE Breeze theme.
process-stop is red.
Add process-stop from KDE Oxygen.
Un-indent some stuff and add more braces.
Fix "~/." for the home directory, similar to "./." for the
application directory.
The language tag is initially loaded by ConfigStore, but when notifyAll()
is called, LanguageMenu realizes it's invalid and calls ConfigStore::set()
with an empty tag, which causes a deadlock due to d->mtxSignalMaps being
locked.
To fix this, populate a single vector of methods to invoke, then unlock
the mutex and invoke the methods.
Currently only handles the language code. lastPath is present, but isn't
set up yet.
LanguageMenu: Skip languages with an empty name. These are placeholder
translations that don't have any actual data yet.
The Linux builds have been failing for a while due to an image
configuration issue, and seemingly no one at AppVeyor has noticed:
W: GPG error: https://dl.google.com/linux/chrome/deb stable InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 32EE5355A6BC6E42
E: The repository 'https://dl.google.com/linux/chrome/deb stable InRelease' is not signed.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.
- Don't use '#' in the printf format specifiers. Explicitly specify
"0x" for each one.
- Right-align the descriptions for each entry.
- Put expected on the right side of the actual values.
Before:
[/dev/nvme0n1] NHCD Bank Table:
- Status: HAS_GPT
- Table Magic (Expected Value: 0x0x4443484e): 0x00000000
- x004 (expected: 0x00000001): 0x00000000
- bank_count (expected: 0x00000008): 0x00000000
- x00C (expected: 0x00000000): 0x00000000
- x010 (expected: 0x002FF000): 0x00000000
- unk table:
After:
[/dev/nvme0n1] NHCD Bank Table:
- Status: HAS_GPT
- Table Magic: 0x00000000 (expected: 0x4443484E, "NHCD")
- x004: 0x00000000 (expected: 0x00000001)
- Bank Count: 0x00000000 (expected: 0x00000008)
- x00C: 0x00000000 (expected: 0x00000000)
- x010: 0x00000000 (expected: 0x002FF000)
- unk table:
(Yeah, I used my laptop's NVMe SSD for testing instead of connecting the
RVT-H Reader. It takes effort to connect the RVT-H Reader...)
[qrvthtool] SelectDeviceDialog, [rvthtool] query.c:
- TODO: Switch to VersionHelpers at some point.
- For now, suppress C4996 for GetVersionEx().
[rvthtool] query.c: Likewise.
[nusresign] Cast off64_t to size_t where necessary.
Mostly just need to check the result of fread(), e.g.:
src/libwiicrypto/bin2h.c: In function ‘main’:
src/libwiicrypto/bin2h.c:66:9: error: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Werror=unused-result]
66 | fread(bin, 1, fsize, f);
| ^~~~~~~~~~~~~~~~~~~~~~~
I was considering adding an "HxA" prefix, but that looks ugly.
We can't easily determine if it's HMA (wireless) or HUA (wired) through
the numeric part of the serial number, so just leave it out.
NOTE: Several functions still take RefFile* if they don't need to store
the file pointer. May change them to `const RefFilePtr&` later.
RvtHPrivate: Move the enum variables to after the STL objects.
rvth_init_BankEntry(): Needs to take `const RefFilePtr&` in order to
call Reader::open().
This improves performance with some compilers, especially MSVC.
NOTE: Some include guards are left in because a few files check for them:
- secoptions_win8.h: Checks for __RVTHTOOL_LIBWIICRYPTO_WIN32_SECOPTIONS_H__.
