GerbilSoft/rom-properties
1
Fork 0
mirror of https://github.com/GerbilSoft/rom-properties.git synced 2025-06-18 11:35:38 -04:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity
6,807 Commits 255 Branches 37 Tags 162 MiB
a4533f6f68
Commit Graph

6807 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
David Korth
a4533f6f68 git_version.sh: Revert accidental change that broke the dirty flag. 2020-07-12 23:57:18 -04:00
David Korth
e0947b3f5c Revert "[win32] RP_ShellPropSheetExt: Initialize str_nl to 0." 
This reverts commit 9e57292814.

This is a tstring, not tstring*. Initializing it to 0 is a guaranteed
way to crash all of the time.

I'm not exactly sure what I was trying to accomplish here...

This fixes issue #236: Opening ROM Properties tab causes crash of
Explorer process
 2020-07-12 23:46:26 -04:00
David Korth
2f742c6900 [rp-download] IDownloader: Include the Windows OS version. 
I meant to do this a while ago, but never got around to doing it...

TODO: Version numbers for other OSes.
 2020-07-12 23:35:15 -04:00
David Korth
73cab42f07 [libromdata] Moved more "Unknown" strings to the RomData context. 
This eliminates several duplicate strings in the .po files.
 2020-07-12 17:51:09 -04:00
David Korth
b405ca957c [locale] Updated rom-properties.pot and *.po. 
Forgot to do this before releasing rom-properties 1.6. Oh well.
 2020-07-12 17:42:14 -04:00
David Korth
9e92bab93e [debian] rules: Remove XFCE3, MATE, CINNAMON; renamed GNOME to GTK3. 2020-07-12 17:25:40 -04:00
David Korth
9aacc2e9eb [libromdata] GczReader: Use le64_to_cpu(), not le32_to_cpu(). 
This probably won't affect too many .gcz files, since the important
data is stored within the first 4 GB.
 2020-07-12 17:25:00 -04:00
David Korth
1bb267ff7d Version bump for development. (v1.6+) 2020-07-12 17:23:43 -04:00
David Korth
0136021beb [extlib] CMakeLists.txt: Don't install zstd.dll right now. 
We're not using zstd outside of the test suite, so we don't need to
install it.
 2020-07-12 17:22:54 -04:00
David Korth
1a7d919f78 Fix some more ARM64 and AMD64 build issues. 
- ImageDecoder: Default parameter for the SSE2-only version isn't needed.

- byteswap.h: Check for i386/amd64 before using the non-inline functions.
 2020-07-12 15:57:31 -04:00
David Korth
8b7db70995 [librptexture] ImageDecoder: Add default parameter for stride in non-i386/non-amd64 cases. 2020-07-12 15:39:24 -04:00
David Korth
ae06e7d357 [debian] changelog: Update changelog. 2020-07-12 15:26:10 -04:00
David Korth
3571240ad7 [librptexture] ImageDecoder: Attempt to fix ARM64 IFUNC build issues on Launchpad. 2020-07-12 15:22:35 -04:00
David Korth
4c39562f85 rom-properties 1.6 2020-07-12 15:00:26 -04:00
David Korth
da3934d11e [doc] Updated the example configuration files. 2020-07-12 14:24:34 -04:00
David Korth
558a1b007c [rp-stub] Create symlinks in CMakeLists.txt, not debian/rules. 2020-07-12 13:17:01 -04:00
David Korth
31c7bf10f2 NEWS.md: Mention debug Wii U stuff. 2020-07-11 03:01:56 -04:00
David Korth
f4af482f62 [libromdata] KeyStoreUI::importWiiUOtpBin(): Support otp.bin from WIi U devkits. 
The Boot1 hash is different, and the key slots refer to debug keys,
not retail keys.
 2020-07-11 02:48:28 -04:00
David Korth
f4821bc4fa [libromdata] WiiPartition: Added debug Korean and vWii keys. 
These are found in the CAT-DEV OTP.
 2020-07-11 02:41:11 -04:00
David Korth
2d92bbf424 [libromdata] elf_structs.h: Added a missing tag to Elf64_Shdr. 2020-07-11 02:30:54 -04:00
David Korth
f306fb6c64 [gtk] RomDataView: Don't return if page->uri is nullptr. 
There's another check for this later.

PVS-Studio V547 (Med): Expression 'page->uri == nullptr' is always false.

TODO: Remove widgets?
 2020-07-05 01:53:51 -04:00
David Korth
f3c990f597 [libromdata] EXE_NE.cpp: Added a 128 KB limit when reading the module name tables. 
64 KB is probably enough, but we'll go with 128 KB just in case.
 2020-07-04 13:27:53 -04:00
David Korth
520ddc6827 [libromdata] EXE_PE.cpp: Fix large memory allocations with corrupted PE files. 
The corrupted address values were causing us to allocate huge amounts
of memory. This didn't cause an issue normally, since that was all
virtual address space and not real address space, but `afl` failed
because it restricts the virtual address space to 50 MB. After the
memory allocation failed, glibc then tried calling rt_sigprocmask(),
which failed due to seccomp restrictions.

Found using afl-2.56b.
 2020-07-04 13:25:30 -04:00
David Korth
d6fc0ec904 [win32] ConfigDialog: Added another reference for the PropertySheet Minimize button shenanigans. 2020-07-04 03:59:45 -04:00
David Korth
ba8333f38f [win32] ConfigDialog: Restore the default system menu. 
Property sheets only have "Move" and "Close" by default. This re-adds
all of the other entries.

In addition, this seems to fix something that broke on Windows 8.1
and later (and possibly Windows 8.0): Re-adding the Minimize button
without restoring the system menu results in a Minimize button that
does absolutely nothing when clicking it.

This fixes issue #229: Minimize button doesn't work on win32 rp-config
 2020-07-04 03:49:10 -04:00
David Korth
79909d075c [libromdata] xbox360_xdbf_structs.h: #pragma pack(), not #pragma pack(0). 
xbox360_xdbf_structs.h(189,16): warning C4086: expected pragma parameter to be '1', '2', '4', '8', or '16'

This fixes a regression from commit 61999700a7.
(Removed PACKED and #pragma pack(1) where it isn't needed.)
 2020-07-04 03:18:11 -04:00
David Korth
73d3c02df8 NEWS.md: Mention EXE crash fixes. 2020-07-04 00:06:33 -04:00
David Korth
6bd7650869 [libromdata] EXE: We can't use NOP_C_("RomData", "Unknown") in fileTypes_tbl[]. 
We're calling dpgettext_expr() with "EXE|FileType", so the RomData context
won't be used when it should be used.
 2020-07-04 00:04:29 -04:00
David Korth
37b28be155 [libromdata] EXE_PE.cpp: Fix nullptr dereference for IMAGE_SUBSYSTEM_UNKNOWN. 
Print "Unknown" if it's IMAGE_SUBSYSTEM_UNKNOWN, and "Unknown (%u)"
if it's some other value.
 2020-07-04 00:03:13 -04:00
David Korth
b5041d1c38 [libromdata] GczReader: unique_ptr<> needs to use uint8_t[] for an array allocation. 
Found using PVS-Studio v7.08.
V554 (High): Incorrect use of unique_ptr. The memory allocated with
'new []' will be cleaned using 'delete'.
 2020-07-03 17:26:42 -04:00
David Korth
d45054dcc0 [libromdata] GcnPartitionPrivate: Need to delete[] fstData, not free(). 
Found using PVS-Studio v7.08.
V611 (High): The memory was allocated using 'new' operator but was
released using the 'free' function. Consider inspecting operation
logics behind the 'fstData' variable.

This fixes a regression from commit 242bf61e72.
(Use new/delete in some places instead of malloc()/free().)
 2020-07-03 17:24:38 -04:00
David Korth
534e2544ff Fixed two 'expression is always true' warnings. 
Found using PVS-Studio v7.08.
V547 (Med): Expression 'cboImageType_lastAdded' is always true.
V547 (Med): Expresion 'imageType < IMG_TYPE_COUNT' is always true.
 2020-07-03 17:14:51 -04:00
David Korth
c4750c840c [libromdata] EXE: Handle VS_VERSION_INFO with dwFileType == VFT_UNKNOWN. 
Added "Unknown" as a string. Handle nullptr as well.

This fixes issue #235: Crashes on Inside exe
Reported by @mariomadproductions .
 2020-07-03 16:37:14 -04:00
David Korth
d2650cdb8e [kf5] RpExtractorPlugin: MIME types are ASCII, not UTF-8. 
Use QLatin1String() instead of QString::fromUtf8().
 2020-07-03 01:30:00 -04:00
David Korth
c082eefb47 [libromdata] WiiSave: Wrap the no-copy flag check in #ifdef ENABLE_DECRYPTION. 
This fixes a regression from commit 66e466b925.
([libromdata] WiiSave: Show permissions as if they're Unix-style permissions, and show the "No Copy from NAND" flag.)

Reported by @DankRank.
 2020-07-03 01:05:38 -04:00
David Korth
caa2972a88 [libromdata] GameCube: Detect more types of standalone update partitions. 
'UPD' is an IOS-only update partition.
'UPE', 'UPJ', 'UPK', and 'UPP' are region-specific update partitions.

'UPC' would be a region-specific update partition for China, if the
iQue Wii would have been released.

There might be a 'UPT' or 'UPW' for Taiwan, but a Taiwan-region Wii
didn't happen, either. (Well, there might be an RVL-001(TWN), but it
likely has a JPN region code.)
 2020-07-03 00:40:36 -04:00
David Korth
fc51b5eaf0 NEWS.md: Mention XboxPublishers. 2020-07-03 00:40:19 -04:00
David Korth
252f24091e [gtk, kde] We might need to include ${CMAKE_CURRENT_BINARY_DIR} for generated files. 
This may fix a regression from commit 3f26630920.
(Rework MIME types for the .desktop files.)

See issue #234: Compiling error
 2020-07-02 21:21:02 -04:00
David Korth
94e92f0dad [libromdata] XboxPublishers: New list of Xbox and Xbox 360 publishers. 
Reference: https://xboxdevwiki.net/Xbe

Xbox_XBE, Xbox360_XEX: Look up the publisher name.
 2020-07-02 01:39:18 -04:00
David Korth
cc896a8c45 [librptexture] PowerVR3: Removed an obsolete TODO. 2020-07-01 01:01:58 -04:00
David Korth
4c849339da [win32] RP_ExtractIcon_Private::DoExtractIconA(): IPersistFile always takes LPCOLESTR. 
No ANSI conversion is necessary here.
 2020-07-01 00:46:59 -04:00
David Korth
817f3b1bfa [libromdata] GczReader: Fix build issues on MSVC 2017. 
- Constructor cannot return a value.
- isDiscSupported_static(): Return -1, not nullptr.

Not sure why this didn't cause problems with gcc...
 2020-07-01 00:28:47 -04:00
David Korth
9e57292814 [win32] RP_ShellPropSheetExt: Initialize str_nl to 0. 
Otherwise, if !str and !field.data.str, this ends up remaining
uninitialized, which could cause shenanigans to occur.

This scenario is unlikely, though...
 2020-07-01 00:18:38 -04:00
David Korth
7b955ef53c [librptexture] ImageDecoder_N3DS: Using pointers instead of indexes has no improvement in the release build. 2020-07-01 00:08:05 -04:00
David Korth
461279c4f5 Removed a bunch of obsolete TODOs. 2020-06-30 20:25:48 -04:00
David Korth
7a383fa8be [libromdata] MegaDrivePrivate::addFields_vectorTable(): Minor optimization. 
Code size reduction: (64-bit Gentoo Linux, gcc-10.1.0, release build, no LTO)

   text    data     bss     dec     hex filename
  13372    1696       0   15068    3adc MegaDrive.cpp.o [before]
  13262    1728       0   14990    3a8e MegaDrive.cpp.o [after]
   -110     +32       0     -78     -4e Difference
 2020-06-30 20:23:16 -04:00
David Korth
3196c17725 [libromdata] WiiU: Get the GameTDB region code for boxart from the game ID. 2020-06-30 19:47:43 -04:00
David Korth
d3670e9dd9 CMakeLists.txt: Check CPU_i386 before setting MMX or SSE2 flags. 
These flags aren't needed on 64-bit, so only set them on 32-bit.
 2020-06-30 19:46:40 -04:00
David Korth
66e466b925 [libromdata] WiiSave: Show permissions as if they're Unix-style permissions, and show the "No Copy from NAND" flag. 
WiiWIBN: Added an accessor to get the "No Copy from NAND" flag.
 2020-06-30 19:45:34 -04:00
David Korth
f72f457470 [libromdata] GdiReader: Fix reading 2048-byte sector images. 
This fixes a regression from commit 8ee27197f9.
([libromdata] GdiReader::readBlock(): Use cdromSectorDataPtr().)
 2020-06-30 19:42:58 -04:00