GerbilSoft/rom-properties
1
Fork 0
mirror of https://github.com/GerbilSoft/rom-properties.git synced 2025-06-18 11:35:38 -04:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Revert "[win32] RP_ShellPropSheetExt: Initialize str_nl to 0."

Browse Source 
This reverts commit 9e57292814.

This is a tstring, not tstring*. Initializing it to 0 is a guaranteed
way to crash all of the time.

I'm not exactly sure what I was trying to accomplish here...

This fixes issue #236: Opening ROM Properties tab causes crash of
Explorer process
This commit is contained in:
David Korth 2020-07-12 23:46:26 -04:00
parent 2f742c6900
commit e0947b3f5c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/win32/RP_ShellPropSheetExt.cpp
View File

@ -687,7 +687,7 @@ int RP_ShellPropSheetExt_Private::initString(_In_ HWND hDlg, _In_ HWND hWndTab,
// If string data wasn't specified, get the RFT_STRING data // If string data wasn't specified, get the RFT_STRING data
// from the RomFields::Field object. // from the RomFields::Field object.
int lf_count = 0; int lf_count = 0;
tstring str_nl = 0; tstring str_nl;
if (!str) { if (!str) {
if (field.type != RomFields::RFT_STRING) if (field.type != RomFields::RFT_STRING)
return 0; return 0;