From e0947b3f5cb3928fa384e267ecff94f408895df2 Mon Sep 17 00:00:00 2001 From: David Korth Date: Sun, 12 Jul 2020 23:46:26 -0400 Subject: [PATCH] Revert "[win32] RP_ShellPropSheetExt: Initialize str_nl to 0." This reverts commit 9e57292814c71f0b31f4dde132add873a8cfbfb8. This is a tstring, not tstring*. Initializing it to 0 is a guaranteed way to crash all of the time. I'm not exactly sure what I was trying to accomplish here... This fixes issue #236: Opening ROM Properties tab causes crash of Explorer process --- src/win32/RP_ShellPropSheetExt.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/win32/RP_ShellPropSheetExt.cpp b/src/win32/RP_ShellPropSheetExt.cpp index b0cec697d..63c635d72 100644 --- a/src/win32/RP_ShellPropSheetExt.cpp +++ b/src/win32/RP_ShellPropSheetExt.cpp @@ -687,7 +687,7 @@ int RP_ShellPropSheetExt_Private::initString(_In_ HWND hDlg, _In_ HWND hWndTab, // If string data wasn't specified, get the RFT_STRING data // from the RomFields::Field object. int lf_count = 0; - tstring str_nl = 0; + tstring str_nl; if (!str) { if (field.type != RomFields::RFT_STRING) return 0;