pleonex/NitroDebugger
1
Fork 0
mirror of https://github.com/pleonex/NitroDebugger.git synced 2025-06-19 13:45:33 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Max attempts for receive messages too

Browse Source
This commit is contained in:
Benito Palacios Sánchez 2014-12-08 15:39:18 +01:00
parent 4f698709a0
commit 3a06b1aa6b
2 changed files with 51 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
NitroDebugger.UnitTests/PresentationTests.cs
View File

@ -116,39 +116,46 @@ namespace UnitTests
() => SendCommand("test2", "arg1,arg2", "f5", 11));
}
[Test]
public void ReceiveMessage()
private void ReceiveMessageBad(int attempts)
{
// $ O K # 9 a
byte[] response = new byte[] { 0x24, 0x4F, 0x4B, 0x23, 0x39, 0x61 };
connection.GetStream().Write(response, 0, response.Length);
// $ O K # 9 b
byte[] responseBad = new byte[] { 0x24, 0x4F, 0x4B, 0x23, 0x39, 0x62 };
// $ O K # 9 a
byte[] responseGood = new byte[] { 0x24, 0x4F, 0x4B, 0x23, 0x39, 0x61 };
for (int i = 0; i < attempts - 1; i++)
connection.GetStream().Write(responseBad, 0, responseBad.Length);
connection.GetStream().Write(responseGood, 0, responseGood.Length);
ReplyPacket responsePacket = presentation.ReceiveReply();
Assert.IsInstanceOf<OkReply>(responsePacket);
for (int i = 0; i < attempts - 1; i++) {
byte nack = (byte)connection.GetStream().ReadByte();
Assert.AreEqual(RawPacket.Nack, nack);
}
byte ack = (byte)connection.GetStream().ReadByte();
Assert.AreEqual(RawPacket.Ack, ack);
}
[Test]
public void ReceiveMessage()
{
ReceiveMessageBad(1);
}
[Test]
public void RequestResent()
{
// $ O K # 9 b
byte[] responseBad = new byte[] { 0x24, 0x4F, 0x4B, 0x23, 0x39, 0x62 };
connection.GetStream().Write(responseBad, 0, responseBad.Length);
ReceiveMessageBad(3);
}
// $ O K # 9 a
byte[] responseGood = new byte[] { 0x24, 0x4F, 0x4B, 0x23, 0x39, 0x61 };
connection.GetStream().Write(responseGood, 0, responseGood.Length);
ReplyPacket responsePacket = presentation.ReceiveReply();
Assert.IsInstanceOf<OkReply>(responsePacket);
byte firstNack = (byte)connection.GetStream().ReadByte();
Assert.AreEqual(RawPacket.Nack, firstNack);
byte ack = (byte)connection.GetStream().ReadByte();
Assert.AreEqual(RawPacket.Ack, ack);
[Test]
public void ReceiveTooManyBadMessages()
{
Assert.Throws<ProtocolViolationException>(() => ReceiveMessageBad(11));
}
[Test]

35
NitroDebugger/RSP/Presentation.cs
View File

@ -73,19 +73,32 @@ namespace NitroDebugger.RSP
public ReplyPacket ReceiveReply()
{
ReplyPacket response = null;
int count = 0;
while (response == null) {
try {
// Get data
byte[] packet = this.session.ReadPacket(PacketSeparator);
response = PacketBinConverter.FromBinary(packet);
do {
if (count == MaxWriteAttemps)
throw new ProtocolViolationException("[PRES] Can not receive correctly");
count++;
// Send ACK
this.session.Write(RawPacket.Ack);
} catch (FormatException) {
// Error... send NACK
this.session.Write(RawPacket.Nack);
}
response = this.NextReply();
} while (response == null);
return response;
}
private ReplyPacket NextReply()
{
ReplyPacket response = null;
try {
// Get data
byte[] packet = this.session.ReadPacket(PacketSeparator);
response = PacketBinConverter.FromBinary(packet);
// Send ACK
this.session.Write(RawPacket.Ack);
} catch (FormatException) {
// Error... send NACK
this.session.Write(RawPacket.Nack);
}
return response;