mirror of
https://github.com/W3SLAV/micropython.git
synced 2025-06-19 03:55:44 -04:00
decf8e6a8b
The STATIC macro was introduced a very long time ago in commit
d5df6cd44a. The original reason for this was
to have the option to define it to nothing so that all static functions
become global functions and therefore visible to certain debug tools, so
one could do function size comparison and other things.
This STATIC feature is rarely (if ever) used. And with the use of LTO and
heavy inline optimisation, analysing the size of individual functions when
they are not static is not a good representation of the size of code when
fully optimised.
So the macro does not have much use and it's simpler to just remove it.
Then you know exactly what it's doing. For example, newcomers don't have
to learn what the STATIC macro is and why it exists. Reading the code is
also less "loud" with a lowercase static.
One other minor point in favour of removing it, is that it stops bugs with
`STATIC inline`, which should always be `static inline`.
Methodology for this commit was:
1) git ls-files | egrep '\.[ch]$' | \
xargs sed -Ei "s/(^| )STATIC($| )/\1static\2/"
2) Do some manual cleanup in the diff by searching for the word STATIC in
comments and changing those back.
3) "git-grep STATIC docs/", manually fixed those cases.
4) "rg -t python STATIC", manually fixed codegen lines that used STATIC.
This work was funded through GitHub Sponsors.
Signed-off-by: Angus Gratton <angus@redyak.com.au>
87 lines
2.9 KiB
C
87 lines
2.9 KiB
C
/*
|
|
* This file is part of the MicroPython project, http://micropython.org/
|
|
*
|
|
* The MIT License (MIT)
|
|
*
|
|
* Copyright (c) 2019 Jim Mussared
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
* THE SOFTWARE.
|
|
*/
|
|
|
|
#include "py/runtime.h"
|
|
#include "py/mperrno.h"
|
|
#include "py/mphal.h"
|
|
|
|
#if MICROPY_PY_BLUETOOTH && MICROPY_BLUETOOTH_NIMBLE
|
|
|
|
#define DEBUG_printf(...) // printf("nimble (esp32): " __VA_ARGS__)
|
|
|
|
#include "esp_nimble_hci.h"
|
|
#include "nimble/nimble_port.h"
|
|
#include "nimble/nimble_port_freertos.h"
|
|
|
|
#include "extmod/nimble/modbluetooth_nimble.h"
|
|
|
|
static void ble_host_task(void *param) {
|
|
DEBUG_printf("ble_host_task\n");
|
|
nimble_port_run(); // This function will return only when nimble_port_stop() is executed.
|
|
nimble_port_freertos_deinit();
|
|
}
|
|
|
|
void mp_bluetooth_nimble_port_hci_init(void) {
|
|
DEBUG_printf("mp_bluetooth_nimble_port_hci_init\n");
|
|
esp_nimble_hci_init();
|
|
}
|
|
|
|
void mp_bluetooth_nimble_port_hci_deinit(void) {
|
|
DEBUG_printf("mp_bluetooth_nimble_port_hci_deinit\n");
|
|
|
|
esp_nimble_hci_deinit();
|
|
}
|
|
|
|
void mp_bluetooth_nimble_port_start(void) {
|
|
DEBUG_printf("mp_bluetooth_nimble_port_start\n");
|
|
nimble_port_freertos_init(ble_host_task);
|
|
}
|
|
|
|
void mp_bluetooth_nimble_port_shutdown(void) {
|
|
DEBUG_printf("mp_bluetooth_nimble_port_shutdown\n");
|
|
|
|
#if MICROPY_PY_BLUETOOTH_USE_SYNC_EVENTS_WITH_INTERLOCK
|
|
// Release the GIL so any callbacks can run during the shutdown calls below.
|
|
MP_THREAD_GIL_EXIT();
|
|
#endif
|
|
|
|
// Despite the name, these is an ESP32-specific (no other NimBLE ports have these functions).
|
|
// Calls ble_hs_stop() and waits for stack shutdown.
|
|
nimble_port_stop();
|
|
|
|
// Shuts down the event queue.
|
|
nimble_port_deinit();
|
|
|
|
#if MICROPY_PY_BLUETOOTH_USE_SYNC_EVENTS_WITH_INTERLOCK
|
|
MP_THREAD_GIL_ENTER();
|
|
#endif
|
|
|
|
// Mark stack as shutdown.
|
|
mp_bluetooth_nimble_ble_state = MP_BLUETOOTH_NIMBLE_BLE_STATE_OFF;
|
|
}
|
|
|
|
#endif
|