mirror of
https://github.com/W3SLAV/micropython.git
synced 2025-06-20 20:45:35 -04:00
4bed614e70
Two cases, one assigning to a slice. Closes https://github.com/micropython/micropython/issues/13283 Second is extending a slice from itself, similar logic. In both cases the problem occurs when m_renew causes realloc to move the buffer, leaving a dangling pointer behind. There are more complex and hard to fix cases when either argument is a memoryview into the buffer, currently resizing to a new address breaks memoryviews into that object. Reproducing this bug and confirming the fix was done by running the unix port under valgrind with GC-aware extensions. Note in default configurations with GIL this bug exists but has no impact (the free buffer won't be reused while the function is still executing, and is no longer referenced after it returns). Signed-off-by: Angus Gratton <angus@redyak.com.au>
75 lines
1.3 KiB
Python
75 lines
1.3 KiB
Python
try:
|
|
bytearray()[:] = bytearray()
|
|
except TypeError:
|
|
print("SKIP")
|
|
raise SystemExit
|
|
|
|
# test slices; only 2 argument version supported by MicroPython at the moment
|
|
x = bytearray(range(10))
|
|
|
|
# Assignment
|
|
l = bytearray(x)
|
|
l[1:3] = bytearray([10, 20])
|
|
print(l)
|
|
l = bytearray(x)
|
|
l[1:3] = bytearray([10])
|
|
print(l)
|
|
l = bytearray(x)
|
|
l[1:3] = bytearray()
|
|
print(l)
|
|
l = bytearray(x)
|
|
# del l[1:3]
|
|
print(l)
|
|
|
|
l = bytearray(x)
|
|
l[:3] = bytearray([10, 20])
|
|
print(l)
|
|
l = bytearray(x)
|
|
l[:3] = bytearray()
|
|
print(l)
|
|
l = bytearray(x)
|
|
# del l[:3]
|
|
print(l)
|
|
|
|
l = bytearray(x)
|
|
l[:-3] = bytearray([10, 20])
|
|
print(l)
|
|
l = bytearray(x)
|
|
l[:-3] = bytearray()
|
|
print(l)
|
|
l = bytearray(x)
|
|
# del l[:-3]
|
|
print(l)
|
|
|
|
# slice assignment that extends the array
|
|
b = bytearray(2)
|
|
b[2:] = bytearray(10)
|
|
print(b)
|
|
|
|
b = bytearray(10)
|
|
b[:-1] = bytearray(500)
|
|
print(len(b), b[0], b[-1])
|
|
|
|
# extension with self on RHS
|
|
b = bytearray(x)
|
|
b[4:] = b
|
|
print(b)
|
|
|
|
# Assignment of bytes to array slice
|
|
b = bytearray(2)
|
|
b[1:1] = b"12345"
|
|
print(b)
|
|
|
|
# Growth of bytearray via slice extension
|
|
b = bytearray(b"12345678")
|
|
b.append(57) # expand and add a bit of unused space at end of the bytearray
|
|
for i in range(400):
|
|
b[-1:] = b"ab" # grow slowly into the unused space
|
|
print(len(b), b)
|
|
|
|
# Growth of bytearray via slice extension from itself
|
|
b = bytearray(b"1234567")
|
|
for i in range(3):
|
|
b[-1:] = b
|
|
print(len(b), b)
|