teak-llvm/lldb/packages/Python/lldbsuite
Pavel Labath e8687e6ee1 Make TestVSCode_step pass reliably
Summary:
The test was failing occasionally (1% of runs or so), because of
unpredictable timings between the two threads spawned by the test. If
the second thread hit the breakpoint right as we were stepping out of
the function on the first thread, we would still be stuck at the inner
frame when the process stopped.

This would cause errors like:
    File "/home/worker/lldb-x86_64-debian/lldb-x86_64-debian/llvm/tools/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/step/TestVSCode_step.py", line 67, in test_step
      self.assertEqual(x1, x3, 'verify step out variable')
  AssertionError: 2 != 1 : verify step out variable

AFAICT, lldb-vscode is doing the right thing here, and the problem is
that the test is not taking this sequence of events into account. Since
the test is about testing stepping, it does not seem necessary to have
threads in the inferior at all, so I just rewrite the test to execute
the code we're supposed to step through directly on the main thread.

Reviewers: clayborg, jgorbe

Subscribers: jfb, lldb-commits

Differential Revision: https://reviews.llvm.org/D60608

llvm-svn: 358847
2019-04-21 13:02:41 +00:00
..
pre_kill_hook added Linux support for test timeout sampling 2016-09-26 20:25:47 +00:00
support [testsuite] Drop characters that can't be decoded, restoring parity with Py2. 2019-03-07 17:45:53 +00:00
test Make TestVSCode_step pass reliably 2019-04-21 13:02:41 +00:00
test_event Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
__init__.py *** This commit represents a complete reformatting of the LLDB source code 2016-09-06 20:57:50 +00:00
.clang-format Updated .clang-format rules so bring LLDB in line with LLVM standards. 2016-09-06 17:19:00 +00:00