mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-20 03:55:48 -04:00
df50f9440d
Summary: Currently we have some settings which treat "\ " on settings set commands specially. E.g., it is a valid way of specifying an argument of " " to a target. However, this fails if "\ " is the last argument as CommandObjectSettingsSet strips trailing whitespace. This resulted in a surprising argument of "\" to the target. This patch disables the training whitespace removal at a global level. Instead, for each argument type we locally determine whether whitespace stripping makes sense. Currently, I strip whitespace for all simple object type except of regex and format-string, with the rationale that these two object types do their own complex parsing and we want to interfere with them as least as possible. Specifically, stripping the whitespace of a regex "\ " will result in a (surprising?) error "trailing backslash". Furthermore, the default value of dissasembly-format setting already contains a trailing space and there is no way for the user to type this in manually if we strip whitespace. Reviewers: clayborg, zturner Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D7592 llvm-svn: 229382
118 lines
3.4 KiB
C++
118 lines
3.4 KiB
C++
//===-- OptionValueArch.cpp ---------------------------------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "lldb/lldb-python.h"
|
|
|
|
#include "lldb/Interpreter/OptionValueArch.h"
|
|
|
|
// C Includes
|
|
// C++ Includes
|
|
// Other libraries and framework includes
|
|
// Project includes
|
|
#include "lldb/Core/State.h"
|
|
#include "lldb/DataFormatters/FormatManager.h"
|
|
#include "lldb/Interpreter/Args.h"
|
|
#include "lldb/Interpreter/CommandCompletions.h"
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
|
|
void
|
|
OptionValueArch::DumpValue (const ExecutionContext *exe_ctx, Stream &strm, uint32_t dump_mask)
|
|
{
|
|
if (dump_mask & eDumpOptionType)
|
|
strm.Printf ("(%s)", GetTypeAsCString ());
|
|
if (dump_mask & eDumpOptionValue)
|
|
{
|
|
if (dump_mask & eDumpOptionType)
|
|
strm.PutCString (" = ");
|
|
|
|
if (m_current_value.IsValid())
|
|
{
|
|
const char *arch_name = m_current_value.GetArchitectureName();
|
|
if (arch_name)
|
|
strm.PutCString (arch_name);
|
|
}
|
|
}
|
|
}
|
|
|
|
Error
|
|
OptionValueArch::SetValueFromCString (const char *value_cstr, VarSetOperationType op)
|
|
{
|
|
Error error;
|
|
switch (op)
|
|
{
|
|
case eVarSetOperationClear:
|
|
Clear();
|
|
NotifyValueChanged();
|
|
break;
|
|
|
|
case eVarSetOperationReplace:
|
|
case eVarSetOperationAssign:
|
|
if (value_cstr)
|
|
{
|
|
std::string value = llvm::StringRef(value_cstr).trim().str();
|
|
value_cstr = value.c_str();
|
|
if (m_current_value.SetTriple (value_cstr))
|
|
{
|
|
m_value_was_set = true;
|
|
NotifyValueChanged();
|
|
}
|
|
else
|
|
error.SetErrorStringWithFormat("unsupported architecture '%s'", value_cstr);
|
|
}
|
|
else
|
|
{
|
|
error.SetErrorString("invalid value string");
|
|
}
|
|
break;
|
|
|
|
case eVarSetOperationInsertBefore:
|
|
case eVarSetOperationInsertAfter:
|
|
case eVarSetOperationRemove:
|
|
case eVarSetOperationAppend:
|
|
case eVarSetOperationInvalid:
|
|
error = OptionValue::SetValueFromCString (value_cstr, op);
|
|
break;
|
|
}
|
|
return error;
|
|
}
|
|
|
|
lldb::OptionValueSP
|
|
OptionValueArch::DeepCopy () const
|
|
{
|
|
return OptionValueSP(new OptionValueArch(*this));
|
|
}
|
|
|
|
|
|
size_t
|
|
OptionValueArch::AutoComplete (CommandInterpreter &interpreter,
|
|
const char *s,
|
|
int match_start_point,
|
|
int max_return_elements,
|
|
bool &word_complete,
|
|
StringList &matches)
|
|
{
|
|
word_complete = false;
|
|
matches.Clear();
|
|
CommandCompletions::InvokeCommonCompletionCallbacks (interpreter,
|
|
CommandCompletions::eArchitectureCompletion,
|
|
s,
|
|
match_start_point,
|
|
max_return_elements,
|
|
nullptr,
|
|
word_complete,
|
|
matches);
|
|
return matches.GetSize();
|
|
}
|
|
|
|
|
|
|
|
|