mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-20 12:05:48 -04:00
2946cd7010
to reflect the new license. We understand that people may be surprised that we're moving the header entirely to discuss the new license. We checked this carefully with the Foundation's lawyer and we believe this is the correct approach. Essentially, all code in the project is now made available by the LLVM project under our new license, so you will see that the license headers include that license only. Some of our contributors have contributed code under our old license, and accordingly, we have retained a copy of our old license notice in the top-level files in each project and repository. llvm-svn: 351636
82 lines
2.7 KiB
C++
82 lines
2.7 KiB
C++
//===--- NoMallocCheck.cpp - clang-tidy------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "NoMallocCheck.h"
|
|
#include "../utils/Matchers.h"
|
|
#include "../utils/OptionsUtils.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
#include <algorithm>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
using namespace clang::ast_matchers;
|
|
using namespace clang::ast_matchers::internal;
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
namespace cppcoreguidelines {
|
|
|
|
namespace {
|
|
Matcher<FunctionDecl> hasAnyListedName(const std::string &FunctionNames) {
|
|
const std::vector<std::string> NameList =
|
|
utils::options::parseStringList(FunctionNames);
|
|
return hasAnyName(std::vector<StringRef>(NameList.begin(), NameList.end()));
|
|
}
|
|
} // namespace
|
|
|
|
void NoMallocCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
|
|
Options.store(Opts, "Allocations", AllocList);
|
|
Options.store(Opts, "Reallocations", ReallocList);
|
|
Options.store(Opts, "Deallocations", DeallocList);
|
|
}
|
|
|
|
void NoMallocCheck::registerMatchers(MatchFinder *Finder) {
|
|
// C-style memory management is only problematic in C++.
|
|
if (!getLangOpts().CPlusPlus)
|
|
return;
|
|
|
|
// Registering malloc, will suggest RAII.
|
|
Finder->addMatcher(callExpr(callee(functionDecl(hasAnyListedName(AllocList))))
|
|
.bind("allocation"),
|
|
this);
|
|
|
|
// Registering realloc calls, suggest std::vector or std::string.
|
|
Finder->addMatcher(
|
|
callExpr(callee(functionDecl(hasAnyListedName(ReallocList))))
|
|
.bind("realloc"),
|
|
this);
|
|
|
|
// Registering free calls, will suggest RAII instead.
|
|
Finder->addMatcher(
|
|
callExpr(callee(functionDecl(hasAnyListedName(DeallocList))))
|
|
.bind("free"),
|
|
this);
|
|
}
|
|
|
|
void NoMallocCheck::check(const MatchFinder::MatchResult &Result) {
|
|
const CallExpr *Call = nullptr;
|
|
StringRef Recommendation;
|
|
|
|
if ((Call = Result.Nodes.getNodeAs<CallExpr>("allocation")))
|
|
Recommendation = "consider a container or a smart pointer";
|
|
else if ((Call = Result.Nodes.getNodeAs<CallExpr>("realloc")))
|
|
Recommendation = "consider std::vector or std::string";
|
|
else if ((Call = Result.Nodes.getNodeAs<CallExpr>("free")))
|
|
Recommendation = "use RAII";
|
|
|
|
assert(Call && "Unhandled binding in the Matcher");
|
|
|
|
diag(Call->getBeginLoc(), "do not manage memory manually; %0")
|
|
<< Recommendation << SourceRange(Call->getBeginLoc(), Call->getEndLoc());
|
|
}
|
|
|
|
} // namespace cppcoreguidelines
|
|
} // namespace tidy
|
|
} // namespace clang
|