mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-22 04:55:50 -04:00
ad2524f9fc
Summary: The cppcoreguidelines-pro-bounds-pointer-arithmetic warns on all occassion where pointer arithmetic is used, but does not check values where the pointer types is deduced via `auto`. This patch adjusts this behaviour and solved PR36489. I accidentally commited a wrong patch, this Differential is meant to have a correct revision description and code attached to it. Because the patch was accepted by aaron.ballman already, i will just commit it. See https://reviews.llvm.org/D48717 for the old differntial (contains wrong code from the mixup) Subscribers: nemanjai, xazax.hun, kbarton, cfe-commits Differential Revision: https://reviews.llvm.org/D49682 llvm-svn: 337716
64 lines
2.0 KiB
C++
64 lines
2.0 KiB
C++
//===--- ProBoundsPointerArithmeticCheck.cpp - clang-tidy------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "ProBoundsPointerArithmeticCheck.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
namespace cppcoreguidelines {
|
|
|
|
void ProBoundsPointerArithmeticCheck::registerMatchers(MatchFinder *Finder) {
|
|
if (!getLangOpts().CPlusPlus)
|
|
return;
|
|
|
|
const auto AllPointerTypes = anyOf(
|
|
hasType(pointerType()), hasType(autoType(hasDeducedType(pointerType()))),
|
|
hasType(decltypeType(hasUnderlyingType(pointerType()))));
|
|
|
|
// Flag all operators +, -, +=, -=, ++, -- that result in a pointer
|
|
Finder->addMatcher(
|
|
binaryOperator(
|
|
anyOf(hasOperatorName("+"), hasOperatorName("-"),
|
|
hasOperatorName("+="), hasOperatorName("-=")),
|
|
AllPointerTypes,
|
|
unless(hasLHS(ignoringImpCasts(declRefExpr(to(isImplicit()))))))
|
|
.bind("expr"),
|
|
this);
|
|
|
|
Finder->addMatcher(
|
|
unaryOperator(anyOf(hasOperatorName("++"), hasOperatorName("--")),
|
|
hasType(pointerType()))
|
|
.bind("expr"),
|
|
this);
|
|
|
|
// Array subscript on a pointer (not an array) is also pointer arithmetic
|
|
Finder->addMatcher(
|
|
arraySubscriptExpr(
|
|
hasBase(ignoringImpCasts(
|
|
anyOf(AllPointerTypes,
|
|
hasType(decayedType(hasDecayedType(pointerType())))))))
|
|
.bind("expr"),
|
|
this);
|
|
}
|
|
|
|
void ProBoundsPointerArithmeticCheck::check(
|
|
const MatchFinder::MatchResult &Result) {
|
|
const auto *MatchedExpr = Result.Nodes.getNodeAs<Expr>("expr");
|
|
|
|
diag(MatchedExpr->getExprLoc(), "do not use pointer arithmetic");
|
|
}
|
|
|
|
} // namespace cppcoreguidelines
|
|
} // namespace tidy
|
|
} // namespace clang
|