mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-23 05:25:50 -04:00
5b6dda33d1
The semantics for converting nested pointers between address spaces are not very well defined. Some conversions which do not really carry any meaning only produce warnings, and in some cases warnings hide invalid conversions, such as 'global int*' to 'local float*'! This patch changes the logic in checkPointerTypesForAssignment and checkAddressSpaceCast to fail properly on implicit conversions that should definitely not be permitted. We also dig deeper into the pointer types and warn on explicit conversions where the address space in a nested pointer changes, regardless of whether the address space is compatible with the corresponding pointer nesting level on the destination type. Fixes PR39674! Patch by ebevhan (Bevin Hansson)! Differential Revision: https://reviews.llvm.org/D58236 llvm-svn: 360258
244 lines
14 KiB
Common Lisp
244 lines
14 KiB
Common Lisp
// RUN: %clang_cc1 %s -verify -pedantic -fsyntax-only
|
|
// RUN: %clang_cc1 %s -cl-std=CL2.0 -verify -pedantic -fsyntax-only
|
|
// RUN: %clang_cc1 %s -cl-std=c++ -verify -pedantic -fsyntax-only
|
|
|
|
__constant int ci = 1;
|
|
|
|
__kernel void foo(__global int *gip) {
|
|
__local int li;
|
|
__local int lj = 2; // expected-error {{'__local' variable cannot have an initializer}}
|
|
|
|
int *ip;
|
|
#if ((!__OPENCL_CPP_VERSION__) && (__OPENCL_C_VERSION__ < 200))
|
|
ip = gip; // expected-error {{assigning '__global int *' to 'int *' changes address space of pointer}}
|
|
ip = &li; // expected-error {{assigning '__local int *' to 'int *' changes address space of pointer}}
|
|
ip = &ci; // expected-error {{assigning '__constant int *' to 'int *' changes address space of pointer}}
|
|
#else
|
|
ip = gip;
|
|
ip = &li;
|
|
ip = &ci;
|
|
#if !__OPENCL_CPP_VERSION__
|
|
// expected-error@-2 {{assigning '__constant int *' to '__generic int *' changes address space of pointer}}
|
|
#else
|
|
// expected-error@-4 {{assigning to '__generic int *' from incompatible type '__constant int *'}}
|
|
#endif
|
|
#endif
|
|
}
|
|
|
|
void explicit_cast(__global int *g, __local int *l, __constant int *c, __private int *p, const __constant int *cc) {
|
|
g = (__global int *)l;
|
|
#if !__OPENCL_CPP_VERSION__
|
|
// expected-error@-2 {{casting '__local int *' to type '__global int *' changes address space of pointer}}
|
|
#else
|
|
// expected-error@-4 {{C-style cast from '__local int *' to '__global int *' converts between mismatching address spaces}}
|
|
#endif
|
|
g = (__global int *)c;
|
|
#if !__OPENCL_CPP_VERSION__
|
|
// expected-error@-2 {{casting '__constant int *' to type '__global int *' changes address space of pointer}}
|
|
#else
|
|
// expected-error@-4 {{C-style cast from '__constant int *' to '__global int *' converts between mismatching address spaces}}
|
|
#endif
|
|
g = (__global int *)cc;
|
|
#if !__OPENCL_CPP_VERSION__
|
|
// expected-error@-2 {{casting 'const __constant int *' to type '__global int *' changes address space of pointer}}
|
|
#else
|
|
// expected-error@-4 {{C-style cast from 'const __constant int *' to '__global int *' converts between mismatching address spaces}}
|
|
#endif
|
|
g = (__global int *)p;
|
|
#if !__OPENCL_CPP_VERSION__
|
|
// expected-error@-2 {{casting 'int *' to type '__global int *' changes address space of pointer}}
|
|
#else
|
|
// expected-error@-4 {{C-style cast from 'int *' to '__global int *' converts between mismatching address spaces}}
|
|
#endif
|
|
l = (__local int *)g;
|
|
#if !__OPENCL_CPP_VERSION__
|
|
// expected-error@-2 {{casting '__global int *' to type '__local int *' changes address space of pointer}}
|
|
#else
|
|
// expected-error@-4 {{C-style cast from '__global int *' to '__local int *' converts between mismatching address spaces}}
|
|
#endif
|
|
l = (__local int *)c;
|
|
#if !__OPENCL_CPP_VERSION__
|
|
// expected-error@-2 {{casting '__constant int *' to type '__local int *' changes address space of pointer}}
|
|
#else
|
|
// expected-error@-4 {{C-style cast from '__constant int *' to '__local int *' converts between mismatching address spaces}}
|
|
#endif
|
|
l = (__local int *)cc;
|
|
#if !__OPENCL_CPP_VERSION__
|
|
// expected-error@-2 {{casting 'const __constant int *' to type '__local int *' changes address space of pointer}}
|
|
#else
|
|
// expected-error@-4 {{C-style cast from 'const __constant int *' to '__local int *' converts between mismatching address spaces}}
|
|
#endif
|
|
l = (__local int *)p;
|
|
#if !__OPENCL_CPP_VERSION__
|
|
// expected-error@-2 {{casting 'int *' to type '__local int *' changes address space of pointer}}
|
|
#else
|
|
// expected-error@-4 {{C-style cast from 'int *' to '__local int *' converts between mismatching address spaces}}
|
|
#endif
|
|
c = (__constant int *)g;
|
|
#if !__OPENCL_CPP_VERSION__
|
|
// expected-error@-2 {{casting '__global int *' to type '__constant int *' changes address space of pointer}}
|
|
#else
|
|
// expected-error@-4 {{C-style cast from '__global int *' to '__constant int *' converts between mismatching address spaces}}
|
|
#endif
|
|
c = (__constant int *)l;
|
|
#if !__OPENCL_CPP_VERSION__
|
|
// expected-error@-2 {{casting '__local int *' to type '__constant int *' changes address space of pointer}}
|
|
#else
|
|
// expected-error@-4 {{C-style cast from '__local int *' to '__constant int *' converts between mismatching address spaces}}
|
|
#endif
|
|
c = (__constant int *)p;
|
|
#if !__OPENCL_CPP_VERSION__
|
|
// expected-error@-2 {{casting 'int *' to type '__constant int *' changes address space of pointer}}
|
|
#else
|
|
// expected-error@-4 {{C-style cast from 'int *' to '__constant int *' converts between mismatching address spaces}}
|
|
#endif
|
|
p = (__private int *)g;
|
|
#if !__OPENCL_CPP_VERSION__
|
|
// expected-error@-2 {{casting '__global int *' to type 'int *' changes address space of pointer}}
|
|
#else
|
|
// expected-error@-4 {{C-style cast from '__global int *' to 'int *' converts between mismatching address spaces}}
|
|
#endif
|
|
p = (__private int *)l;
|
|
#if !__OPENCL_CPP_VERSION__
|
|
// expected-error@-2 {{casting '__local int *' to type 'int *' changes address space of pointer}}
|
|
#else
|
|
// expected-error@-4 {{C-style cast from '__local int *' to 'int *' converts between mismatching address spaces}}
|
|
#endif
|
|
p = (__private int *)c;
|
|
#if !__OPENCL_CPP_VERSION__
|
|
// expected-error@-2 {{casting '__constant int *' to type 'int *' changes address space of pointer}}
|
|
#else
|
|
// expected-error@-4 {{C-style cast from '__constant int *' to 'int *' converts between mismatching address spaces}}
|
|
#endif
|
|
p = (__private int *)cc;
|
|
#if !__OPENCL_CPP_VERSION__
|
|
// expected-error@-2 {{casting 'const __constant int *' to type 'int *' changes address space of pointer}}
|
|
#else
|
|
// expected-error@-4 {{C-style cast from 'const __constant int *' to 'int *' converts between mismatching address spaces}}
|
|
#endif
|
|
}
|
|
|
|
void ok_explicit_casts(__global int *g, __global int *g2, __local int *l, __local int *l2, __private int *p, __private int *p2) {
|
|
g = (__global int *)g2;
|
|
l = (__local int *)l2;
|
|
p = (__private int *)p2;
|
|
}
|
|
|
|
#if !__OPENCL_CPP_VERSION__
|
|
void nested(__global int *g, __global int * __private *gg, __local int *l, __local int * __private *ll, __global float * __private *gg_f) {
|
|
g = gg; // expected-error {{assigning '__global int **' to '__global int *' changes address space of pointer}}
|
|
g = l; // expected-error {{assigning '__local int *' to '__global int *' changes address space of pointer}}
|
|
g = ll; // expected-error {{assigning '__local int **' to '__global int *' changes address space of pointer}}
|
|
g = gg_f; // expected-error {{assigning '__global float **' to '__global int *' changes address space of pointer}}
|
|
g = (__global int *)gg_f; // expected-error {{casting '__global float **' to type '__global int *' changes address space of pointer}}
|
|
|
|
gg = g; // expected-error {{assigning '__global int *' to '__global int **' changes address space of pointer}}
|
|
gg = l; // expected-error {{assigning '__local int *' to '__global int **' changes address space of pointer}}
|
|
gg = ll; // expected-error {{assigning '__local int **' to '__global int **' changes address space of nested pointer}}
|
|
gg = gg_f; // expected-warning {{incompatible pointer types assigning to '__global int **' from '__global float **'}}
|
|
gg = (__global int * __private *)gg_f;
|
|
|
|
l = g; // expected-error {{assigning '__global int *' to '__local int *' changes address space of pointer}}
|
|
l = gg; // expected-error {{assigning '__global int **' to '__local int *' changes address space of pointer}}
|
|
l = ll; // expected-error {{assigning '__local int **' to '__local int *' changes address space of pointer}}
|
|
l = gg_f; // expected-error {{assigning '__global float **' to '__local int *' changes address space of pointer}}
|
|
l = (__local int *)gg_f; // expected-error {{casting '__global float **' to type '__local int *' changes address space of pointer}}
|
|
|
|
ll = g; // expected-error {{assigning '__global int *' to '__local int **' changes address space of pointer}}
|
|
ll = gg; // expected-error {{assigning '__global int **' to '__local int **' changes address space of nested pointer}}
|
|
ll = l; // expected-error {{assigning '__local int *' to '__local int **' changes address space of pointer}}
|
|
ll = gg_f; // expected-error {{assigning '__global float **' to '__local int **' changes address space of nested pointer}}
|
|
ll = (__local int * __private *)gg_f; // expected-warning {{casting '__global float **' to type '__local int **' discards qualifiers in nested pointer types}}
|
|
|
|
gg_f = g; // expected-error {{assigning '__global int *' to '__global float **' changes address space of pointer}}
|
|
gg_f = gg; // expected-warning {{incompatible pointer types assigning to '__global float **' from '__global int **'}}
|
|
gg_f = l; // expected-error {{assigning '__local int *' to '__global float **' changes address space of pointer}}
|
|
gg_f = ll; // expected-error {{assigning '__local int **' to '__global float **' changes address space of nested pointer}}
|
|
gg_f = (__global float * __private *)gg;
|
|
|
|
// FIXME: This doesn't seem right. This should be an error, not a warning.
|
|
__local int * __global * __private * lll;
|
|
lll = gg; // expected-warning {{incompatible pointer types assigning to '__local int *__global **' from '__global int **'}}
|
|
|
|
typedef __local int * l_t;
|
|
typedef __global int * g_t;
|
|
__private l_t * pl;
|
|
__private g_t * pg;
|
|
gg = pl; // expected-error {{assigning 'l_t *' (aka '__local int **') to '__global int **' changes address space of nested pointer}}
|
|
pl = gg; // expected-error {{assigning '__global int **' to 'l_t *' (aka '__local int **') changes address space of nested pointer}}
|
|
gg = pg;
|
|
pg = gg;
|
|
pg = pl; // expected-error {{assigning 'l_t *' (aka '__local int **') to 'g_t *' (aka '__global int **') changes address space of nested pointer}}
|
|
pl = pg; // expected-error {{assigning 'g_t *' (aka '__global int **') to 'l_t *' (aka '__local int **') changes address space of nested pointer}}
|
|
|
|
ll = (__local int * __private *)(void *)gg;
|
|
void *vp = ll;
|
|
}
|
|
#else
|
|
void nested(__global int *g, __global int * __private *gg, __local int *l, __local int * __private *ll, __global float * __private *gg_f) {
|
|
g = gg; // expected-error {{assigning to '__global int *' from incompatible type '__global int **'}}
|
|
g = l; // expected-error {{assigning to '__global int *' from incompatible type '__local int *'}}
|
|
g = ll; // expected-error {{assigning to '__global int *' from incompatible type '__local int **'}}
|
|
g = gg_f; // expected-error {{assigning to '__global int *' from incompatible type '__global float **'}}
|
|
g = (__global int *)gg_f; // expected-error {{C-style cast from '__global float **' to '__global int *' converts between mismatching address spaces}}
|
|
|
|
gg = g; // expected-error {{assigning to '__global int **' from incompatible type '__global int *'; take the address with &}}
|
|
gg = l; // expected-error {{assigning to '__global int **' from incompatible type '__local int *'}}
|
|
gg = ll; // expected-error {{assigning to '__global int **' from incompatible type '__local int **'}}
|
|
gg = gg_f; // expected-error {{assigning to '__global int **' from incompatible type '__global float **'}}
|
|
gg = (__global int * __private *)gg_f;
|
|
|
|
l = g; // expected-error {{assigning to '__local int *' from incompatible type '__global int *'}}
|
|
l = gg; // expected-error {{assigning to '__local int *' from incompatible type '__global int **'}}
|
|
l = ll; // expected-error {{assigning to '__local int *' from incompatible type '__local int **'}}
|
|
l = gg_f; // expected-error {{assigning to '__local int *' from incompatible type '__global float **'}}
|
|
l = (__local int *)gg_f; // expected-error {{C-style cast from '__global float **' to '__local int *' converts between mismatching address spaces}}
|
|
|
|
ll = g; // expected-error {{assigning to '__local int **' from incompatible type '__global int *'}}
|
|
ll = gg; // expected-error {{assigning to '__local int **' from incompatible type '__global int **'}}
|
|
ll = l; // expected-error {{assigning to '__local int **' from incompatible type '__local int *'; take the address with &}}
|
|
ll = gg_f; // expected-error {{assigning to '__local int **' from incompatible type '__global float **'}}
|
|
// FIXME: The below becomes a reinterpret_cast, and therefore does not emit an error
|
|
// even though the address space mismatches in the nested pointers.
|
|
ll = (__local int * __private *)gg;
|
|
|
|
gg_f = g; // expected-error {{assigning to '__global float **' from incompatible type '__global int *'}}
|
|
gg_f = gg; // expected-error {{assigning to '__global float **' from incompatible type '__global int **'}}
|
|
gg_f = l; // expected-error {{assigning to '__global float **' from incompatible type '__local int *'}}
|
|
gg_f = ll; // expected-error {{assigning to '__global float **' from incompatible type '__local int **'}}
|
|
gg_f = (__global float * __private *)gg;
|
|
|
|
typedef __local int * l_t;
|
|
typedef __global int * g_t;
|
|
__private l_t * pl;
|
|
__private g_t * pg;
|
|
gg = pl; // expected-error {{assigning to '__global int **' from incompatible type 'l_t *' (aka '__local int **')}}
|
|
pl = gg; // expected-error {{assigning to 'l_t *' (aka '__local int **') from incompatible type '__global int **'}}
|
|
gg = pg;
|
|
pg = gg;
|
|
pg = pl; // expected-error {{assigning to 'g_t *' (aka '__global int **') from incompatible type 'l_t *' (aka '__local int **')}}
|
|
pl = pg; // expected-error {{assigning to 'l_t *' (aka '__local int **') from incompatible type 'g_t *' (aka '__global int **')}}
|
|
|
|
ll = (__local int * __private *)(void *)gg;
|
|
void *vp = ll;
|
|
}
|
|
#endif
|
|
|
|
__private int func_return_priv(void); //expected-error {{return value cannot be qualified with address space}}
|
|
__global int func_return_global(void); //expected-error {{return value cannot be qualified with address space}}
|
|
__local int func_return_local(void); //expected-error {{return value cannot be qualified with address space}}
|
|
__constant int func_return_constant(void); //expected-error {{return value cannot be qualified with address space}}
|
|
#if __OPENCL_C_VERSION__ >= 200
|
|
__generic int func_return_generic(void); //expected-error {{return value cannot be qualified with address space}}
|
|
#endif
|
|
|
|
void func_multiple_addr(void) {
|
|
typedef __private int private_int_t;
|
|
__private __local int var1; // expected-error {{multiple address spaces specified for type}}
|
|
__private __local int *var2; // expected-error {{multiple address spaces specified for type}}
|
|
__local private_int_t var3; // expected-error {{multiple address spaces specified for type}}
|
|
__local private_int_t *var4; // expected-error {{multiple address spaces specified for type}}
|
|
__private private_int_t var5; // expected-warning {{multiple identical address spaces specified for type}}
|
|
__private private_int_t *var6;// expected-warning {{multiple identical address spaces specified for type}}
|
|
}
|