teak-llvm/warn-write-strings.c at ceb639dbeea97c901b2642ebe296eb358d27b2f6 - teak-llvm - Git Backup

Gericom/teak-llvm

mirror of https://github.com/Gericom/teak-llvm.git synced 2025-06-23 13:35:42 -04:00

Chandler Carruth b009b14971 There were some frustrating problems with the implementation of

-Wwrite-strings. First and foremost, once the positive form of the flag
was passed, it could never be disabled by passing -Wno-write-strings.
Also, the diagnostic engine couldn't in turn use -Wwrite-strings to
control diagnostics (as GCC does) because it was essentially hijacked to
drive the language semantics.

Fix this by giving CC1 a clean '-fconst-strings' flag to enable
const-qualified strings in C and ObjC compilations. Corresponding
'-fno-const-strings' is also added. Then the driver is taught to
introduce '-fconst-strings' in the CC1 command when '-Wwrite-strings'
dominates.

This entire flag is basically GCC-bug-compatibility driven, so we also
match GCC's bug where '-w' doesn't actually disable -Wwrite-strings. I'm
open to changing this though as it seems insane.

llvm-svn: 130051

2011-04-23 06:30:43 +00:00

11 lines

279 B

C

Raw Blame History

 // RUN: %clang_cc1 -verify -fsyntax-only -fconst-strings %s
 // PR4804
 char* x = "foo"; // expected-warning {{initializing 'char *' with an expression of type 'const char [4]' discards qualifiers}}
 // PR7192
 #include <stddef.h>
 void test(wchar_t *dst) {
   dst[0] = 0;  // Ok.
 }