mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-23 13:35:42 -04:00
8129c5c0a4
For pointer assignments of VLA types, Clang currently detects when array
dimensions _lower_ than a variable dimension differ, and reports a warning.
However it does not do the same when the _higher_ dimensions differ, a
case that GCC does catch.
These two pointer types
int (*foo)[1][bar][3];
int (*baz)[1][2][3];
are compatible with each another, and the program is well formed if
bar == 2, a matter that is the programmers problem. However the following:
int (*qux)[2][2][3];
would not be compatible with either, because the upper dimension differs
in size. Clang reports baz is incompatible with qux, but not that foo is
incompatible with qux because it doesn't check those higher dimensions.
Fix this by comparing array sizes on higher dimensions: if both are
constants but unequal then report incompatibility; if either dimension is
variable then we can't know either way.
Differential Revision: https://reviews.llvm.org/D47628
llvm-svn: 333989
92 lines
2.9 KiB
C
92 lines
2.9 KiB
C
// RUN: %clang_cc1 %s -verify -fsyntax-only -pedantic
|
|
|
|
int test1() {
|
|
typedef int x[test1()]; // vla
|
|
static int y = sizeof(x); // expected-error {{not a compile-time constant}}
|
|
}
|
|
|
|
// PR2347
|
|
void f (unsigned int m)
|
|
{
|
|
int e[2][m];
|
|
|
|
e[0][0] = 0;
|
|
}
|
|
|
|
// PR3048
|
|
int x = sizeof(struct{char qq[x];}); // expected-error {{fields must have a constant size}}
|
|
|
|
// PR2352
|
|
void f2(unsigned int m)
|
|
{
|
|
extern int e1[2][m]; // expected-error {{variable length array declaration cannot have 'extern' linkage}}
|
|
|
|
e1[0][0] = 0;
|
|
|
|
}
|
|
|
|
// PR2361
|
|
int i;
|
|
int c[][i]; // expected-error {{variably modified type declaration not allowed at file scope}}
|
|
int d[i]; // expected-error {{variable length array declaration not allowed at file scope}}
|
|
|
|
int (*e)[i]; // expected-error {{variably modified type declaration not allowed at file scope}}
|
|
|
|
void f3()
|
|
{
|
|
static int a[i]; // expected-error {{variable length array declaration cannot have 'static' storage duration}}
|
|
extern int b[i]; // expected-error {{variable length array declaration cannot have 'extern' linkage}}
|
|
|
|
extern int (*c1)[i]; // expected-error {{variably modified type declaration cannot have 'extern' linkage}}
|
|
static int (*d)[i];
|
|
}
|
|
|
|
// PR3663
|
|
static const unsigned array[((2 * (int)((((4) / 2) + 1.0/3.0) * (4) - 1e-8)) + 1)]; // expected-warning {{variable length array folded to constant array as an extension}}
|
|
|
|
int a[*]; // expected-error {{star modifier used outside of function prototype}}
|
|
int f4(int a[*][*]);
|
|
|
|
// PR2044
|
|
int pr2044(int b) {int (*c(void))[b];**c() = 2;} // expected-error {{variably modified type}}
|
|
int pr2044b;
|
|
int (*pr2044c(void))[pr2044b]; // expected-error {{variably modified type}}
|
|
|
|
const int f5_ci = 1;
|
|
void f5() { char a[][f5_ci] = {""}; } // expected-warning {{variable length array folded to constant array as an extension}}
|
|
|
|
// PR5185
|
|
void pr5185(int a[*]);
|
|
void pr5185(int a[*]) // expected-error {{variable length array must be bound in function definition}}
|
|
{
|
|
}
|
|
|
|
void pr23151(int (*p1)[*]) // expected-error {{variable length array must be bound in function definition}}
|
|
{}
|
|
|
|
// Make sure this isn't treated as an error
|
|
int TransformBug(int a) {
|
|
return sizeof(*(int(*)[({ goto v; v: a;})]) 0); // expected-warning {{use of GNU statement expression extension}}
|
|
}
|
|
|
|
// PR36157
|
|
struct {
|
|
int a[ // expected-error {{variable length array in struct}}
|
|
implicitly_declared() // expected-warning {{implicit declaration}}
|
|
];
|
|
};
|
|
int (*use_implicitly_declared)() = implicitly_declared; // ok, was implicitly declared at file scope
|
|
|
|
void VLAPtrAssign(int size) {
|
|
int array[1][2][3][size][4][5];
|
|
// This is well formed
|
|
int (*p)[2][3][size][4][5] = array;
|
|
// Last array dimension too large
|
|
int (*p2)[2][3][size][4][6] = array; // expected-warning {{incompatible pointer types}}
|
|
// Second array dimension too large
|
|
int (*p3)[20][3][size][4][5] = array; // expected-warning {{incompatible pointer types}}
|
|
|
|
// Not illegal in C, program _might_ be well formed if size == 3.
|
|
int (*p4)[2][size][3][4][5] = array;
|
|
}
|