mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-26 06:48:51 -04:00
3234887fe2
Without this patch, APSInt inherits APInt::isNegative, which merely checks the sign bit without regard to whether the type is actually signed. isNonNegative and isStrictlyPositive call isNegative and so are also affected. This patch adjusts APSInt to override isNegative, isNonNegative, and isStrictlyPositive with implementations that consider whether the type is signed. A large set of Clang OpenMP tests are affected. Without this patch, these tests assume that `true` is not a valid argument for clauses like `collapse`. Indeed, `true` fails APInt::isStrictlyPositive but not APSInt::isStrictlyPositive. This patch adjusts those tests to assume `true` should be accepted. This patch also adds tests revealing various other similar fixes due to APSInt::isNegative calls in Clang's ExprConstant.cpp and SemaExpr.cpp: `++` and `--` overflow in `constexpr`, evaluated object size based on `alloc_size`, `<<` and `>>` shift count validation, and OpenMP array section validation. Reviewed By: lebedev.ri, ABataev, hfinkel Differential Revision: https://reviews.llvm.org/D59712 llvm-svn: 359012
110 lines
7.5 KiB
C++
110 lines
7.5 KiB
C++
// RUN: %clang_cc1 -verify -fopenmp %s
|
|
// RUN: %clang_cc1 -verify -fopenmp -std=c++98 %s
|
|
// RUN: %clang_cc1 -verify -fopenmp -std=c++11 %s
|
|
|
|
// RUN: %clang_cc1 -verify -fopenmp-simd %s
|
|
// RUN: %clang_cc1 -verify -fopenmp-simd -std=c++98 %s
|
|
// RUN: %clang_cc1 -verify -fopenmp-simd -std=c++11 %s
|
|
|
|
void foo() {
|
|
}
|
|
|
|
bool foobool(int argc) {
|
|
#if __cplusplus >= 201103L
|
|
// expected-note@-2 4 {{declared here}}
|
|
#endif
|
|
return argc;
|
|
}
|
|
|
|
struct S1; // expected-note {{declared here}}
|
|
|
|
template <class T, typename S, int N, int ST> // expected-note {{declared here}}
|
|
T tmain(T argc, S **argv) { //expected-note 2 {{declared here}}
|
|
#pragma omp target parallel for collapse // expected-error {{expected '(' after 'collapse'}}
|
|
for (int i = ST; i < N; i++) argv[0][i] = argv[0][i] - argv[0][i-ST];
|
|
#pragma omp target parallel for collapse ( // expected-error {{expected expression}} expected-error {{expected ')'}} expected-note {{to match this '('}}
|
|
for (int i = ST; i < N; i++) argv[0][i] = argv[0][i] - argv[0][i-ST];
|
|
#pragma omp target parallel for collapse () // expected-error {{expected expression}}
|
|
for (int i = ST; i < N; i++) argv[0][i] = argv[0][i] - argv[0][i-ST];
|
|
// expected-error@+3 {{expected ')'}} expected-note@+3 {{to match this '('}}
|
|
// expected-error@+2 2 {{expression is not an integral constant expression}}
|
|
// expected-note@+1 2 {{read of non-const variable 'argc' is not allowed in a constant expression}}
|
|
#pragma omp target parallel for collapse (argc
|
|
for (int i = ST; i < N; i++) argv[0][i] = argv[0][i] - argv[0][i-ST];
|
|
// expected-error@+1 2 {{argument to 'collapse' clause must be a strictly positive integer value}}
|
|
#pragma omp target parallel for collapse (ST // expected-error {{expected ')'}} expected-note {{to match this '('}}
|
|
for (int i = ST; i < N; i++) argv[0][i] = argv[0][i] - argv[0][i-ST];
|
|
#pragma omp target parallel for collapse (1)) // expected-warning {{extra tokens at the end of '#pragma omp target parallel for' are ignored}}
|
|
for (int i = ST; i < N; i++) argv[0][i] = argv[0][i] - argv[0][i-ST];
|
|
#pragma omp target parallel for collapse ((ST > 0) ? 1 + ST : 2) // expected-note 2 {{as specified in 'collapse' clause}}
|
|
for (int i = ST; i < N; i++) argv[0][i] = argv[0][i] - argv[0][i-ST]; // expected-error 2 {{expected 2 for loops after '#pragma omp target parallel for', but found only 1}}
|
|
// expected-error@+3 2 {{directive '#pragma omp target parallel for' cannot contain more than one 'collapse' clause}}
|
|
// expected-error@+2 {{argument to 'collapse' clause must be a strictly positive integer value}}
|
|
// expected-error@+1 2 {{expression is not an integral constant expression}}
|
|
#pragma omp target parallel for collapse (foobool(argc)), collapse (true), collapse (-5)
|
|
#if __cplusplus >= 201103L
|
|
// expected-note@-2 2 {{non-constexpr function 'foobool' cannot be used in a constant expression}}
|
|
#endif
|
|
for (int i = ST; i < N; i++) argv[0][i] = argv[0][i] - argv[0][i-ST];
|
|
#pragma omp target parallel for collapse (S) // expected-error {{'S' does not refer to a value}}
|
|
for (int i = ST; i < N; i++) argv[0][i] = argv[0][i] - argv[0][i-ST];
|
|
#if __cplusplus >= 201103L
|
|
// expected-error@+4 2 {{integral constant expression must have integral or unscoped enumeration type, not 'char *'}}
|
|
#else
|
|
// expected-error@+2 2 {{expression is not an integral constant expression}}
|
|
#endif
|
|
#pragma omp target parallel for collapse (argv[1]=2) // expected-error {{expected ')'}} expected-note {{to match this '('}}
|
|
for (int i = ST; i < N; i++) argv[0][i] = argv[0][i] - argv[0][i-ST];
|
|
#pragma omp target parallel for collapse (1)
|
|
for (int i = ST; i < N; i++) argv[0][i] = argv[0][i] - argv[0][i-ST];
|
|
#pragma omp target parallel for collapse (N) // expected-error {{argument to 'collapse' clause must be a strictly positive integer value}}
|
|
for (T i = ST; i < N; i++) argv[0][i] = argv[0][i] - argv[0][i-ST];
|
|
#pragma omp target parallel for collapse (2) // expected-note {{as specified in 'collapse' clause}}
|
|
foo(); // expected-error {{expected 2 for loops after '#pragma omp target parallel for'}}
|
|
return argc;
|
|
}
|
|
|
|
int main(int argc, char **argv) {
|
|
#pragma omp target parallel for collapse // expected-error {{expected '(' after 'collapse'}}
|
|
for (int i = 4; i < 12; i++) argv[0][i] = argv[0][i] - argv[0][i-4];
|
|
#pragma omp target parallel for collapse ( // expected-error {{expected expression}} expected-error {{expected ')'}} expected-note {{to match this '('}}
|
|
for (int i = 4; i < 12; i++) argv[0][i] = argv[0][i] - argv[0][i-4];
|
|
#pragma omp target parallel for collapse () // expected-error {{expected expression}}
|
|
for (int i = 4; i < 12; i++) argv[0][i] = argv[0][i] - argv[0][i-4];
|
|
#pragma omp target parallel for collapse (4 // expected-error {{expected ')'}} expected-note {{to match this '('}} expected-note {{as specified in 'collapse' clause}}
|
|
for (int i = 4; i < 12; i++) argv[0][i] = argv[0][i] - argv[0][i-4]; // expected-error {{expected 4 for loops after '#pragma omp target parallel for', but found only 1}}
|
|
#pragma omp target parallel for collapse (2+2)) // expected-warning {{extra tokens at the end of '#pragma omp target parallel for' are ignored}} expected-note {{as specified in 'collapse' clause}}
|
|
for (int i = 4; i < 12; i++) argv[0][i] = argv[0][i] - argv[0][i-4]; // expected-error {{expected 4 for loops after '#pragma omp target parallel for', but found only 1}}
|
|
#pragma omp target parallel for collapse (foobool(1) > 0 ? 1 : 2) // expected-error {{expression is not an integral constant expression}}
|
|
#if __cplusplus >= 201103L
|
|
// expected-note@-2 {{non-constexpr function 'foobool' cannot be used in a constant expression}}
|
|
#endif
|
|
for (int i = 4; i < 12; i++) argv[0][i] = argv[0][i] - argv[0][i-4];
|
|
// expected-error@+3 {{expression is not an integral constant expression}}
|
|
// expected-error@+2 2 {{directive '#pragma omp target parallel for' cannot contain more than one 'collapse' clause}}
|
|
// expected-error@+1 {{argument to 'collapse' clause must be a strictly positive integer value}}
|
|
#pragma omp target parallel for collapse (foobool(argc)), collapse (true), collapse (-5)
|
|
#if __cplusplus >= 201103L
|
|
// expected-note@-2 {{non-constexpr function 'foobool' cannot be used in a constant expression}}
|
|
#endif
|
|
for (int i = 4; i < 12; i++) argv[0][i] = argv[0][i] - argv[0][i-4];
|
|
#pragma omp target parallel for collapse (S1) // expected-error {{'S1' does not refer to a value}}
|
|
for (int i = 4; i < 12; i++) argv[0][i] = argv[0][i] - argv[0][i-4];
|
|
#if __cplusplus >= 201103L
|
|
// expected-error@+4 {{integral constant expression must have integral or unscoped enumeration type, not 'char *'}}
|
|
#else
|
|
// expected-error@+2 {{expression is not an integral constant expression}}
|
|
#endif
|
|
#pragma omp target parallel for collapse (argv[1]=2) // expected-error {{expected ')'}} expected-note {{to match this '('}}
|
|
for (int i = 4; i < 12; i++) argv[0][i] = argv[0][i] - argv[0][i-4];
|
|
// expected-error@+3 {{statement after '#pragma omp target parallel for' must be a for loop}}
|
|
// expected-note@+1 {{in instantiation of function template specialization 'tmain<int, char, -1, -2>' requested here}}
|
|
#pragma omp target parallel for collapse(collapse(tmain<int, char, -1, -2>(argc, argv) // expected-error 2 {{expected ')'}} expected-note 2 {{to match this '('}}
|
|
foo();
|
|
#pragma omp target parallel for collapse (2) // expected-note {{as specified in 'collapse' clause}}
|
|
foo(); // expected-error {{expected 2 for loops after '#pragma omp target parallel for'}}
|
|
// expected-note@+1 {{in instantiation of function template specialization 'tmain<int, char, 1, 0>' requested here}}
|
|
return tmain<int, char, 1, 0>(argc, argv);
|
|
}
|
|
|