mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-26 14:58:59 -04:00
2946cd7010
to reflect the new license. We understand that people may be surprised that we're moving the header entirely to discuss the new license. We checked this carefully with the Foundation's lawyer and we believe this is the correct approach. Essentially, all code in the project is now made available by the LLVM project under our new license, so you will see that the license headers include that license only. Some of our contributors have contributed code under our old license, and accordingly, we have retained a copy of our old license notice in the top-level files in each project and repository. llvm-svn: 351636
114 lines
3.5 KiB
C++
114 lines
3.5 KiB
C++
//===--- UseUsingCheck.cpp - clang-tidy------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "UseUsingCheck.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/Lex/Lexer.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
namespace modernize {
|
|
|
|
UseUsingCheck::UseUsingCheck(StringRef Name, ClangTidyContext *Context)
|
|
: ClangTidyCheck(Name, Context),
|
|
IgnoreMacros(Options.getLocalOrGlobal("IgnoreMacros", true)) {}
|
|
|
|
void UseUsingCheck::registerMatchers(MatchFinder *Finder) {
|
|
if (!getLangOpts().CPlusPlus11)
|
|
return;
|
|
Finder->addMatcher(typedefDecl(unless(isInstantiated())).bind("typedef"),
|
|
this);
|
|
}
|
|
|
|
// Checks if 'typedef' keyword can be removed - we do it only if
|
|
// it is the only declaration in a declaration chain.
|
|
static bool CheckRemoval(SourceManager &SM, SourceLocation StartLoc,
|
|
ASTContext &Context) {
|
|
assert(StartLoc.isFileID() && "StartLoc must not be in a macro");
|
|
std::pair<FileID, unsigned> LocInfo = SM.getDecomposedLoc(StartLoc);
|
|
StringRef File = SM.getBufferData(LocInfo.first);
|
|
const char *TokenBegin = File.data() + LocInfo.second;
|
|
Lexer DeclLexer(SM.getLocForStartOfFile(LocInfo.first), Context.getLangOpts(),
|
|
File.begin(), TokenBegin, File.end());
|
|
|
|
Token Tok;
|
|
int ParenLevel = 0;
|
|
bool FoundTypedef = false;
|
|
|
|
while (!DeclLexer.LexFromRawLexer(Tok) && !Tok.is(tok::semi)) {
|
|
switch (Tok.getKind()) {
|
|
case tok::l_brace:
|
|
case tok::r_brace:
|
|
// This might be the `typedef struct {...} T;` case.
|
|
return false;
|
|
case tok::l_paren:
|
|
ParenLevel++;
|
|
break;
|
|
case tok::r_paren:
|
|
ParenLevel--;
|
|
break;
|
|
case tok::comma:
|
|
if (ParenLevel == 0) {
|
|
// If there is comma and we are not between open parenthesis then it is
|
|
// two or more declarations in this chain.
|
|
return false;
|
|
}
|
|
break;
|
|
case tok::raw_identifier:
|
|
if (Tok.getRawIdentifier() == "typedef") {
|
|
FoundTypedef = true;
|
|
}
|
|
break;
|
|
default:
|
|
break;
|
|
}
|
|
}
|
|
|
|
// Sanity check against weird macro cases.
|
|
return FoundTypedef;
|
|
}
|
|
|
|
void UseUsingCheck::check(const MatchFinder::MatchResult &Result) {
|
|
const auto *MatchedDecl = Result.Nodes.getNodeAs<TypedefDecl>("typedef");
|
|
if (MatchedDecl->getLocation().isInvalid())
|
|
return;
|
|
|
|
auto &Context = *Result.Context;
|
|
auto &SM = *Result.SourceManager;
|
|
|
|
SourceLocation StartLoc = MatchedDecl->getBeginLoc();
|
|
|
|
if (StartLoc.isMacroID() && IgnoreMacros)
|
|
return;
|
|
|
|
auto Diag =
|
|
diag(StartLoc, "use 'using' instead of 'typedef'");
|
|
|
|
// do not fix if there is macro or array
|
|
if (MatchedDecl->getUnderlyingType()->isArrayType() || StartLoc.isMacroID())
|
|
return;
|
|
|
|
if (CheckRemoval(SM, StartLoc, Context)) {
|
|
auto printPolicy = PrintingPolicy(getLangOpts());
|
|
printPolicy.SuppressScope = true;
|
|
printPolicy.ConstantArraySizeAsWritten = true;
|
|
printPolicy.UseVoidForZeroParams = false;
|
|
|
|
Diag << FixItHint::CreateReplacement(
|
|
MatchedDecl->getSourceRange(),
|
|
"using " + MatchedDecl->getNameAsString() + " = " +
|
|
MatchedDecl->getUnderlyingType().getAsString(printPolicy));
|
|
}
|
|
}
|
|
|
|
} // namespace modernize
|
|
} // namespace tidy
|
|
} // namespace clang
|