mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-25 22:38:56 -04:00

to reflect the new license. We understand that people may be surprised that we're moving the header entirely to discuss the new license. We checked this carefully with the Foundation's lawyer and we believe this is the correct approach. Essentially, all code in the project is now made available by the LLVM project under our new license, so you will see that the license headers include that license only. Some of our contributors have contributed code under our old license, and accordingly, we have retained a copy of our old license notice in the top-level files in each project and repository. llvm-svn: 351636
63 lines
2.3 KiB
C++
63 lines
2.3 KiB
C++
//===--- MisplacedConstCheck.cpp - clang-tidy------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "MisplacedConstCheck.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
namespace misc {
|
|
|
|
void MisplacedConstCheck::registerMatchers(MatchFinder *Finder) {
|
|
Finder->addMatcher(
|
|
valueDecl(hasType(isConstQualified()),
|
|
hasType(typedefType(hasDeclaration(
|
|
typedefDecl(hasType(pointerType(unless(pointee(
|
|
anyOf(isConstQualified(),
|
|
ignoringParens(functionType())))))))
|
|
.bind("typedef")))))
|
|
.bind("decl"),
|
|
this);
|
|
}
|
|
|
|
static QualType guessAlternateQualification(ASTContext &Context, QualType QT) {
|
|
// We're given a QualType from a typedef where the qualifiers apply to the
|
|
// pointer instead of the pointee. Strip the const qualifier from the pointer
|
|
// type and add it to the pointee instead.
|
|
if (!QT->isPointerType())
|
|
return QT;
|
|
|
|
Qualifiers Quals = QT.getLocalQualifiers();
|
|
Quals.removeConst();
|
|
|
|
QualType NewQT = Context.getPointerType(
|
|
QualType(QT->getPointeeType().getTypePtr(), Qualifiers::Const));
|
|
return NewQT.withCVRQualifiers(Quals.getCVRQualifiers());
|
|
}
|
|
|
|
void MisplacedConstCheck::check(const MatchFinder::MatchResult &Result) {
|
|
const auto *Var = Result.Nodes.getNodeAs<ValueDecl>("decl");
|
|
const auto *Typedef = Result.Nodes.getNodeAs<TypedefDecl>("typedef");
|
|
ASTContext &Ctx = *Result.Context;
|
|
QualType CanQT = Var->getType().getCanonicalType();
|
|
|
|
diag(Var->getLocation(), "%0 declared with a const-qualified typedef type; "
|
|
"results in the type being '%1' instead of '%2'")
|
|
<< Var << CanQT.getAsString(Ctx.getPrintingPolicy())
|
|
<< guessAlternateQualification(Ctx, CanQT)
|
|
.getAsString(Ctx.getPrintingPolicy());
|
|
diag(Typedef->getLocation(), "typedef declared here", DiagnosticIDs::Note);
|
|
}
|
|
|
|
} // namespace misc
|
|
} // namespace tidy
|
|
} // namespace clang
|