mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-19 19:45:40 -04:00
8c90c1d2d5
Summary: This migrates objc-forbidden-subclassing to `isDerivedFrom` as it now supports matching Objective-C interface declarations. Test Notes: Ran clang tools tests. Reviewers: aaron.ballman, gribozavr Reviewed By: aaron.ballman Subscribers: xazax.hun, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D66269 llvm-svn: 369076
95 lines
2.7 KiB
C++
95 lines
2.7 KiB
C++
//===--- ForbiddenSubclassingCheck.cpp - clang-tidy -----------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "ForbiddenSubclassingCheck.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
#include "llvm/ADT/Hashing.h"
|
|
#include "llvm/ADT/SmallVector.h"
|
|
#include "../utils/OptionsUtils.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
namespace objc {
|
|
|
|
namespace {
|
|
|
|
constexpr char DefaultForbiddenSuperClassNames[] =
|
|
"ABNewPersonViewController;"
|
|
"ABPeoplePickerNavigationController;"
|
|
"ABPersonViewController;"
|
|
"ABUnknownPersonViewController;"
|
|
"NSHashTable;"
|
|
"NSMapTable;"
|
|
"NSPointerArray;"
|
|
"NSPointerFunctions;"
|
|
"NSTimer;"
|
|
"UIActionSheet;"
|
|
"UIAlertView;"
|
|
"UIImagePickerController;"
|
|
"UITextInputMode;"
|
|
"UIWebView";
|
|
|
|
} // namespace
|
|
|
|
ForbiddenSubclassingCheck::ForbiddenSubclassingCheck(
|
|
StringRef Name,
|
|
ClangTidyContext *Context)
|
|
: ClangTidyCheck(Name, Context),
|
|
ForbiddenSuperClassNames(
|
|
utils::options::parseStringList(
|
|
Options.get("ClassNames", DefaultForbiddenSuperClassNames))) {
|
|
}
|
|
|
|
void ForbiddenSubclassingCheck::registerMatchers(MatchFinder *Finder) {
|
|
// this check should only be applied to ObjC sources.
|
|
if (!getLangOpts().ObjC)
|
|
return;
|
|
|
|
Finder->addMatcher(
|
|
objcInterfaceDecl(
|
|
isDerivedFrom(
|
|
objcInterfaceDecl(
|
|
hasAnyName(
|
|
std::vector<StringRef>(
|
|
ForbiddenSuperClassNames.begin(),
|
|
ForbiddenSuperClassNames.end())))
|
|
.bind("superclass")))
|
|
.bind("subclass"),
|
|
this);
|
|
}
|
|
|
|
void ForbiddenSubclassingCheck::check(
|
|
const MatchFinder::MatchResult &Result) {
|
|
const auto *SubClass = Result.Nodes.getNodeAs<ObjCInterfaceDecl>(
|
|
"subclass");
|
|
assert(SubClass != nullptr);
|
|
const auto *SuperClass = Result.Nodes.getNodeAs<ObjCInterfaceDecl>(
|
|
"superclass");
|
|
assert(SuperClass != nullptr);
|
|
diag(SubClass->getLocation(),
|
|
"Objective-C interface %0 subclasses %1, which is not "
|
|
"intended to be subclassed")
|
|
<< SubClass
|
|
<< SuperClass;
|
|
}
|
|
|
|
void ForbiddenSubclassingCheck::storeOptions(
|
|
ClangTidyOptions::OptionMap &Opts) {
|
|
Options.store(
|
|
Opts,
|
|
"ForbiddenSuperClassNames",
|
|
utils::options::serializeStringList(ForbiddenSuperClassNames));
|
|
}
|
|
|
|
} // namespace objc
|
|
} // namespace tidy
|
|
} // namespace clang
|