mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-25 14:28:54 -04:00
30680e9437
Allow Obj-C ivars with incomplete array type but only as the last ivar. Also add a requirement for ivars that contain a flexible array member to be at the end of class too. It is possible to add in a subclass another ivar at the end but we'll emit a warning in this case. Also we'll emit a warning if a variable sized ivar is declared in class extension or in implementation because subclasses won't know they should avoid adding new ivars. In ARC incomplete array objects are treated as __unsafe_unretained so require them to be marked as such. Prohibit synthesizing ivars with flexible array members because order of synthesized ivars is not obvious and tricky to control. Spelling out ivar explicitly gives control to developers and helps to avoid surprises with unexpected ivar ordering. For C and C++ changed diagnostic to tell explicitly a field is not the last one and point to the next field. It is not as useful as in Obj-C but it is an improvement and it is consistent with Obj-C. For C for unions emit more specific err_flexible_array_union instead of generic err_field_incomplete. rdar://problem/21054495 Reviewers: rjmccall, theraven Reviewed By: rjmccall Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D38773 llvm-svn: 316381
38 lines
883 B
Plaintext
38 lines
883 B
Plaintext
// RUN: %clang_cc1 -fsyntax-only -verify -Wno-objc-root-class %s
|
|
|
|
// Test only flexible array member functionality specific to C++.
|
|
|
|
union VariableSizeUnion {
|
|
int s;
|
|
char c[];
|
|
};
|
|
|
|
@interface LastUnionIvar {
|
|
VariableSizeUnion flexible;
|
|
}
|
|
@end
|
|
|
|
@interface NotLastUnionIvar {
|
|
VariableSizeUnion flexible; // expected-error {{field 'flexible' with variable sized type 'VariableSizeUnion' is not at the end of class}}
|
|
int last; // expected-note {{next instance variable declaration is here}}
|
|
}
|
|
@end
|
|
|
|
|
|
class VariableSizeClass {
|
|
public:
|
|
int s;
|
|
char c[];
|
|
};
|
|
|
|
@interface LastClassIvar {
|
|
VariableSizeClass flexible;
|
|
}
|
|
@end
|
|
|
|
@interface NotLastClassIvar {
|
|
VariableSizeClass flexible; // expected-error {{field 'flexible' with variable sized type 'VariableSizeClass' is not at the end of class}}
|
|
int last; // expected-note {{next instance variable declaration is here}}
|
|
}
|
|
@end
|