teak-llvm/warn-zero-nullptr.h at b4dd6d24d7567869e66e901b02d886095b87525d - teak-llvm - Git Backup

Gericom/teak-llvm

mirror of https://github.com/Gericom/teak-llvm.git synced 2025-06-28 15:58:57 -04:00

Roman Lebedev 809df34efc [Sema] -Wzero-as-null-pointer-constant: don't warn for system macros other than NULL.

Summary:
The warning was initially introduced in D32914 by @thakis,
and the concerns were raised there, and later in rL302247
and PR33771.

I do believe that it makes sense to relax the diagnostic
e.g. in this case, when the expression originates from the
system header, which can not be modified. This prevents
adoption for the diagnostic for codebases which use pthreads
(`PTHREAD_MUTEX_INITIALIZER`), gtest, etc.

As @malcolm.parsons suggests, it *may* make sense to also
not warn for the template types, but it is not obvious to
me how to do that in here.

Though, it still makes sense to complain about `NULL` macro.

While there, add more tests.

Reviewers: dblaikie, thakis, rsmith, rjmccall, aaron.ballman

Reviewed By: thakis

Subscribers: Rakete1111, hans, cfe-commits, thakis, malcolm.parsons

Tags: #clang

Differential Revision: https://reviews.llvm.org/D38954

llvm-svn: 316662

2017-10-26 13:18:14 +00:00

4 lines

76 B

C

Raw Blame History

	`#define NULL (0)`
	`#define SYSTEM_MACRO (0)`
	`#define OTHER_SYSTEM_MACRO (NULL)`