mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-21 12:35:47 -04:00
b3faa01ff9
Summary: IOHandler needs to read lines of input from a lldb::File. The way it currently does this using, FILE*, which is something we want to avoid now. I'd prefer to just replace the FILE* code with calls to File::Read, but it contains an awkward and delicate workaround specific to ctrl-C handling on windows, and it's not clear if or how that workaround would translate to lldb::File. So in this patch, we use use the FILE* if it's available, and only fall back on File::Read if that's the only option. I think this is a reasonable approach here for two reasons. First is that interactive terminal support is the one area where FILE* can't be avoided. We need them for libedit and curses anyway, and using them here as well is consistent with that pattern. The second reason is that the comments express a hope that the underlying windows bug that's being worked around will be fixed one day, so hopefully when that happens, that whole path can be deleted. Reviewers: JDevlieghere, jasonmolenda, labath, lanza Reviewed By: labath Subscribers: lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D68622 llvm-svn: 374576 |
||
|---|---|---|
| .. | ||
| breakpoint | ||
| class_members | ||
| debugger | ||
| default-constructor | ||
| disassemble-raw-data | ||
| event | ||
| exprpath_synthetic | ||
| file_handle | ||
| findvalue_duplist | ||
| formatters | ||
| frame | ||
| function_symbol | ||
| hello_world | ||
| interpreter | ||
| lldbutil | ||
| module_section | ||
| name_lookup | ||
| objc_type | ||
| process | ||
| rdar-12481949 | ||
| sbdata | ||
| sblaunchinfo | ||
| sbstructureddata | ||
| sbtype_typeclass | ||
| sbvalue_const_addrof | ||
| sbvalue_persist | ||
| section | ||
| signals | ||
| symbol-context | ||
| target | ||
| thread | ||
| type | ||
| value | ||
| value_var_update | ||
| watchpoint | ||
| .categories | ||