mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-22 21:15:40 -04:00
38c2059aec
Summary:
I have found a way to segfault lldb in 7 keystrokes! Steps to reproduce:
1) Launch lldb
2) Type `print` and hit enter. lldb will now prompt you to type a list of
expressions, followed by an empty line.
3) Hit enter, indicating the end of your input.
4) Segfault!
After some investigation, I've found the issue in Host/common/Editline.cpp.
Editline::MoveCursor() relies on m_input_lines not being empty when the `to`
argument is CursorPosition::BlockEnd. This scenario, as far as I can tell,
occurs in one specific instance: In Editline::EndOrAddLineCommand() when the
list of lines being processed contains exactly one string (""). Meeting this
condition is fairly simple, I have posted steps to reproduce above.
Reviewers: krytarowski, zturner, labath
Reviewed By: labath
Subscribers: scott.smith, lldb-commits
Differential Revision: https://reviews.llvm.org/D32421
Patch by Alex Langford.
llvm-svn: 302225
91 lines
2.8 KiB
Python
91 lines
2.8 KiB
Python
"""Test multiline expressions."""
|
|
|
|
from __future__ import print_function
|
|
|
|
import os
|
|
import lldb
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
|
|
class MultilineExpressionsTestCase(TestBase):
|
|
|
|
mydir = TestBase.compute_mydir(__file__)
|
|
NO_DEBUG_INFO_TESTCASE = True
|
|
|
|
def setUp(self):
|
|
# Call super's setUp().
|
|
TestBase.setUp(self)
|
|
# Find the line number to break on inside main.cpp.
|
|
self.line = line_number('main.c', 'break')
|
|
|
|
@skipIfRemote
|
|
@expectedFailureAll(
|
|
oslist=["windows"],
|
|
bugnumber="llvm.org/pr22274: need a pexpect replacement for windows")
|
|
def test_with_run_commands(self):
|
|
"""Test that multiline expressions work correctly"""
|
|
self.build()
|
|
import pexpect
|
|
exe = os.path.join(os.getcwd(), "a.out")
|
|
prompt = "(lldb) "
|
|
|
|
# So that the child gets torn down after the test.
|
|
self.child = pexpect.spawn(
|
|
'%s %s %s' %
|
|
(lldbtest_config.lldbExec, self.lldbOption, exe))
|
|
child = self.child
|
|
# Turn on logging for what the child sends back.
|
|
if self.TraceOn():
|
|
child.logfile_read = sys.stdout
|
|
|
|
# Set the breakpoint, run the inferior, when it breaks, issue print on
|
|
# the various convenience variables.
|
|
child.expect_exact(prompt)
|
|
child.sendline('breakpoint set -f main.c -l %d' % self.line)
|
|
child.expect_exact(prompt)
|
|
child.sendline('run')
|
|
child.expect_exact("stop reason = breakpoint 1.1")
|
|
child.expect_exact(prompt)
|
|
child.sendline('expr')
|
|
child.expect_exact('1:')
|
|
|
|
child.sendline('2+')
|
|
child.expect_exact('2:')
|
|
|
|
child.sendline('3')
|
|
child.expect_exact('3:')
|
|
|
|
child.sendline('')
|
|
child.expect_exact(prompt)
|
|
self.expect(child.before, exe=False,
|
|
patterns=['= 5'])
|
|
|
|
@skipIfRemote
|
|
@expectedFailureAll(
|
|
oslist=["windows"],
|
|
bugnumber="llvm.org/pr22274: need a pexpect replacement for windows")
|
|
def test_empty_list(self):
|
|
"""Test printing an empty list of expressions"""
|
|
import pexpect
|
|
prompt = "(lldb) "
|
|
|
|
# So that the child gets torn down after the test
|
|
self.child = pexpect.spawn(
|
|
"%s %s" %
|
|
(lldbtest_config.lldbExec, self.lldbOption))
|
|
child = self.child
|
|
|
|
# Turn on logging for what the child sends back.
|
|
if self.TraceOn():
|
|
child.logfile_read = sys.stdout
|
|
|
|
# We expect a prompt, then send "print" to start a list of expressions,
|
|
# then an empty line. We expect a prompt back.
|
|
child.expect_exact(prompt)
|
|
child.sendline("print")
|
|
child.expect_exact('1:')
|
|
child.sendline("")
|
|
child.expect_exact(prompt)
|