mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-23 13:35:42 -04:00
e6234d1429
The following appears in OpenMP 3.1 sec. 2.9.1.1 as a predetermined data-sharing attribute: > Variables with const-qualified type having no mutable member are > shared. It does not appear in OpenmP 4.0, 4.5, or 5.0. This patch removes the implementation of that attribute when the requested OpenMP version is greater than 3.1. One effect of that removal is that `default(none)` affects const variables without mutable members. Also, without this patch, if a const variable without mutable members was explicitly lastprivate or private, it was an error because it was predetermined shared. Now, clang instead complains that it's const without mutable fields, which is a more intelligible diagnostic. That should be fine for all of the above versions because they all have something like the following, which is quoted from OpenMP 5.0 sec. 2.19.3: > A variable that is privatized must not have a const-qualified type > unless it is of class type with a mutable member. This restriction does > not apply to the firstprivate clause. reduction and linear clauses already have separate checks for const variables. Future patches will merge the implementations. Reviewed By: ABataev Differential Revision: https://reviews.llvm.org/D56113 llvm-svn: 350439
149 lines
4.7 KiB
C++
149 lines
4.7 KiB
C++
// RUN: %clang_cc1 -verify -fopenmp %s
|
|
|
|
// RUN: %clang_cc1 -verify -fopenmp-simd %s
|
|
|
|
void foo() {
|
|
}
|
|
|
|
bool foobool(int argc) {
|
|
return argc;
|
|
}
|
|
|
|
struct S1; // expected-note {{declared here}} expected-note {{forward declaration of 'S1'}}
|
|
extern S1 a;
|
|
class S2 {
|
|
mutable int a;
|
|
public:
|
|
S2():a(0) { }
|
|
static float S2s; // expected-note {{predetermined as shared}}
|
|
};
|
|
const S2 b;
|
|
const S2 ba[5];
|
|
class S3 {
|
|
int a;
|
|
public:
|
|
S3():a(0) { }
|
|
};
|
|
const S3 c; // expected-note {{'c' defined here}}
|
|
const S3 ca[5]; // expected-note {{'ca' defined here}}
|
|
extern const int f; // expected-note {{'f' declared here}}
|
|
class S4 {
|
|
int a;
|
|
S4(); // expected-note {{implicitly declared private here}}
|
|
public:
|
|
S4(int v):a(v) { }
|
|
};
|
|
class S5 {
|
|
int a;
|
|
S5():a(0) {} // expected-note {{implicitly declared private here}}
|
|
public:
|
|
S5(int v):a(v) { }
|
|
};
|
|
|
|
S3 h;
|
|
#pragma omp threadprivate(h) // expected-note {{defined as threadprivate or thread local}}
|
|
|
|
|
|
int main(int argc, char **argv) {
|
|
const int d = 5; // expected-note {{'d' defined here}}
|
|
const int da[5] = { 0 }; // expected-note {{'da' defined here}}
|
|
S4 e(4);
|
|
S5 g(5);
|
|
int i;
|
|
int &j = i;
|
|
|
|
#pragma omp target
|
|
#pragma omp teams distribute private // expected-error {{expected '(' after 'private'}}
|
|
for (int k = 0; k < argc; ++k) ++k;
|
|
|
|
#pragma omp target
|
|
#pragma omp teams distribute private ( // expected-error {{expected expression}} expected-error {{expected ')'}} expected-note {{to match this '('}}
|
|
for (int k = 0; k < argc; ++k) ++k;
|
|
|
|
#pragma omp target
|
|
#pragma omp teams distribute private () // expected-error {{expected expression}}
|
|
for (int k = 0; k < argc; ++k) ++k;
|
|
|
|
#pragma omp target
|
|
#pragma omp teams distribute private (argc // expected-error {{expected ')'}} expected-note {{to match this '('}}
|
|
for (int k = 0; k < argc; ++k) ++k;
|
|
|
|
#pragma omp target
|
|
#pragma omp teams distribute private (argc, // expected-error {{expected expression}} expected-error {{expected ')'}} expected-note {{to match this '('}}
|
|
for (int k = 0; k < argc; ++k) ++k;
|
|
|
|
#pragma omp target
|
|
#pragma omp teams distribute private (argc > 0 ? argv[1] : argv[2]) // expected-error {{expected variable name}}
|
|
for (int k = 0; k < argc; ++k) ++k;
|
|
|
|
#pragma omp target
|
|
#pragma omp teams distribute private (argc)
|
|
for (int k = 0; k < argc; ++k) ++k;
|
|
|
|
#pragma omp target
|
|
#pragma omp teams distribute private (S1) // expected-error {{'S1' does not refer to a value}}
|
|
for (int k = 0; k < argc; ++k) ++k;
|
|
|
|
#pragma omp target
|
|
#pragma omp teams distribute private (a, b, c, d, f) // expected-error {{private variable with incomplete type 'S1'}} expected-error 1 {{const-qualified variable without mutable fields cannot be private}} expected-error 2 {{const-qualified variable cannot be private}}
|
|
for (int k = 0; k < argc; ++k) ++k;
|
|
|
|
#pragma omp target
|
|
#pragma omp teams distribute private (argv[1]) // expected-error {{expected variable name}}
|
|
for (int k = 0; k < argc; ++k) ++k;
|
|
|
|
#pragma omp target
|
|
#pragma omp teams distribute private(ba)
|
|
for (int k = 0; k < argc; ++k) ++k;
|
|
|
|
#pragma omp target
|
|
#pragma omp teams distribute private(ca) // expected-error {{const-qualified variable without mutable fields cannot be private}}
|
|
for (int k = 0; k < argc; ++k) ++k;
|
|
|
|
#pragma omp target
|
|
#pragma omp teams distribute private(da) // expected-error {{const-qualified variable cannot be private}}
|
|
for (int k = 0; k < argc; ++k) ++k;
|
|
|
|
#pragma omp target
|
|
#pragma omp teams distribute private(S2::S2s) // expected-error {{shared variable cannot be private}}
|
|
for (int k = 0; k < argc; ++k) ++k;
|
|
|
|
#pragma omp target
|
|
#pragma omp teams distribute private(e, g) // expected-error {{calling a private constructor of class 'S4'}} expected-error {{calling a private constructor of class 'S5'}}
|
|
for (int k = 0; k < argc; ++k) ++k;
|
|
|
|
#pragma omp target
|
|
#pragma omp teams distribute private(h) // expected-error {{threadprivate or thread local variable cannot be private}}
|
|
for (int k = 0; k < argc; ++k) ++k;
|
|
|
|
#pragma omp target
|
|
#pragma omp teams distribute shared(i)
|
|
for (int k = 0; k < argc; ++k) ++k;
|
|
|
|
#pragma omp target
|
|
#pragma omp teams distribute firstprivate(i), private(i) // expected-error {{firstprivate variable cannot be private}} expected-note {{defined as firstprivate}}
|
|
for (int k = 0; k < argc; ++k) ++k;
|
|
|
|
#pragma omp target
|
|
#pragma omp teams distribute private(j)
|
|
for (int k = 0; k < argc; ++k) ++k;
|
|
|
|
#pragma omp target
|
|
#pragma omp teams distribute reduction(+:i)
|
|
for (int k = 0; k < argc; ++k) ++k;
|
|
|
|
#pragma omp distribute private(i)
|
|
for (int k = 0; k < 10; ++k) {
|
|
#pragma omp target
|
|
#pragma omp teams distribute private(i)
|
|
for (int x = 0; x < 10; ++x) foo();
|
|
}
|
|
|
|
#pragma omp target
|
|
#pragma omp teams distribute firstprivate(i)
|
|
for (int k = 0; k < 10; ++k) {
|
|
}
|
|
|
|
return 0;
|
|
}
|