mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-25 22:38:56 -04:00

Summary: print build errors nicely in test output This test infrastructure change adds a new Python exception for test subject builds that fail. The output of the build command is captured and propagated to both the textual test output display code and to the test event system. The ResultsFormatter objects have been modified to do something more useful with this information. The xUnit formatter now replaces the non-informative Python build error stacktrace with the build error content. The curses ResultsFormatter prints a 'B' for build errors rather than 'E'. The xUnit output, in particular, makes it much easier for developers to track down test subject build errors that cause test failures when reports come in from CI. Reviewers: granata.enrico Subscribers: llvm-commits Differential Revision: http://reviews.llvm.org/D20252 llvm-svn: 269525
157 lines
5.1 KiB
Python
157 lines
5.1 KiB
Python
"""
|
|
If the build* function is passed the compiler argument, for example, 'llvm-gcc',
|
|
it is passed as a make variable to the make command. Otherwise, we check the
|
|
LLDB_CC environment variable; if it is defined, it is passed as a make variable
|
|
to the make command.
|
|
|
|
If neither the compiler keyword argument nor the LLDB_CC environment variable is
|
|
specified, no CC make variable is passed to the make command. The Makefile gets
|
|
to define the default CC being used.
|
|
|
|
Same idea holds for LLDB_ARCH environment variable, which maps to the ARCH make
|
|
variable.
|
|
"""
|
|
|
|
# System imports
|
|
import os
|
|
import platform
|
|
import subprocess
|
|
import sys
|
|
|
|
# Our imports
|
|
import lldbsuite.test.lldbtest as lldbtest
|
|
import lldbsuite.test.lldbutil as lldbutil
|
|
from lldbsuite.test_event import build_exception
|
|
|
|
def getArchitecture():
|
|
"""Returns the architecture in effect the test suite is running with."""
|
|
return os.environ["ARCH"] if "ARCH" in os.environ else ""
|
|
|
|
def getCompiler():
|
|
"""Returns the compiler in effect the test suite is running with."""
|
|
compiler = os.environ.get("CC", "clang")
|
|
compiler = lldbutil.which(compiler)
|
|
return os.path.realpath(compiler)
|
|
|
|
def getArchFlag():
|
|
"""Returns the flag required to specify the arch"""
|
|
compiler = getCompiler()
|
|
if compiler is None:
|
|
return ""
|
|
elif "gcc" in compiler:
|
|
archflag = "-m"
|
|
elif "clang" in compiler:
|
|
archflag = "-arch"
|
|
else:
|
|
archflag = None
|
|
|
|
return ("ARCHFLAG=" + archflag) if archflag else ""
|
|
|
|
def getMake():
|
|
"""Returns the name for GNU make"""
|
|
if platform.system() == "FreeBSD" or platform.system() == "NetBSD":
|
|
return "gmake"
|
|
else:
|
|
return "make"
|
|
|
|
def getArchSpec(architecture):
|
|
"""
|
|
Helper function to return the key-value string to specify the architecture
|
|
used for the make system.
|
|
"""
|
|
arch = architecture if architecture else None
|
|
if not arch and "ARCH" in os.environ:
|
|
arch = os.environ["ARCH"]
|
|
|
|
return ("ARCH=" + arch) if arch else ""
|
|
|
|
def getCCSpec(compiler):
|
|
"""
|
|
Helper function to return the key-value string to specify the compiler
|
|
used for the make system.
|
|
"""
|
|
cc = compiler if compiler else None
|
|
if not cc and "CC" in os.environ:
|
|
cc = os.environ["CC"]
|
|
if cc:
|
|
return "CC=\"%s\"" % cc
|
|
else:
|
|
return ""
|
|
|
|
def getCmdLine(d):
|
|
"""
|
|
Helper function to return a properly formatted command line argument(s)
|
|
string used for the make system.
|
|
"""
|
|
|
|
# If d is None or an empty mapping, just return an empty string.
|
|
if not d:
|
|
return ""
|
|
pattern = '%s="%s"' if "win32" in sys.platform else "%s='%s'"
|
|
|
|
def setOrAppendVariable(k, v):
|
|
append_vars = ["CFLAGS_EXTRAS", "LD_EXTRAS"]
|
|
if k in append_vars and k in os.environ:
|
|
v = os.environ[k] + " " + v
|
|
return pattern % (k, v)
|
|
cmdline = " ".join([setOrAppendVariable(k, v) for k, v in list(d.items())])
|
|
|
|
return cmdline
|
|
|
|
|
|
def runBuildCommands(commands, sender):
|
|
try:
|
|
lldbtest.system(commands, sender=sender)
|
|
except subprocess.CalledProcessError as called_process_error:
|
|
# Convert to a build-specific error.
|
|
# We don't do that in lldbtest.system() since that
|
|
# is more general purpose.
|
|
raise build_exception.BuildError(called_process_error)
|
|
|
|
|
|
def buildDefault(sender=None, architecture=None, compiler=None, dictionary=None, clean=True):
|
|
"""Build the binaries the default way."""
|
|
commands = []
|
|
if clean:
|
|
commands.append([getMake(), "clean", getCmdLine(dictionary)])
|
|
commands.append([getMake(), getArchSpec(architecture), getCCSpec(compiler), getCmdLine(dictionary)])
|
|
|
|
runBuildCommands(commands, sender=sender)
|
|
|
|
# True signifies that we can handle building default.
|
|
return True
|
|
|
|
def buildDwarf(sender=None, architecture=None, compiler=None, dictionary=None, clean=True):
|
|
"""Build the binaries with dwarf debug info."""
|
|
commands = []
|
|
if clean:
|
|
commands.append([getMake(), "clean", getCmdLine(dictionary)])
|
|
commands.append([getMake(), "MAKE_DSYM=NO", getArchSpec(architecture), getCCSpec(compiler), getCmdLine(dictionary)])
|
|
|
|
runBuildCommands(commands, sender=sender)
|
|
# True signifies that we can handle building dwarf.
|
|
return True
|
|
|
|
def buildDwo(sender=None, architecture=None, compiler=None, dictionary=None, clean=True):
|
|
"""Build the binaries with dwarf debug info."""
|
|
commands = []
|
|
if clean:
|
|
commands.append([getMake(), "clean", getCmdLine(dictionary)])
|
|
commands.append([getMake(), "MAKE_DSYM=NO", "MAKE_DWO=YES", getArchSpec(architecture), getCCSpec(compiler), getCmdLine(dictionary)])
|
|
|
|
runBuildCommands(commands, sender=sender)
|
|
# True signifies that we can handle building dwo.
|
|
return True
|
|
|
|
def cleanup(sender=None, dictionary=None):
|
|
"""Perform a platform-specific cleanup after the test."""
|
|
#import traceback
|
|
#traceback.print_stack()
|
|
commands = []
|
|
if os.path.isfile("Makefile"):
|
|
commands.append([getMake(), "clean", getCmdLine(dictionary)])
|
|
|
|
runBuildCommands(commands, sender=sender)
|
|
# True signifies that we can handle cleanup.
|
|
return True
|