mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-27 07:19:03 -04:00
683dfd3124
This patch ignores malloc-overflow bug in two cases: Case1: x = a/b; where n < b malloc (x*n); Then x*n will not overflow. Case2: x = a; // when 'a' is a known value. malloc (x*n); Also replaced isa with dyn_cast. Reject multiplication by zero cases in MallocOverflowSecurityChecker Currently MallocOverflowSecurityChecker does not catch cases like: malloc(n * 0 * sizeof(int)); This patch rejects such cases. Two test cases added. malloc-overflow2.c has an example inspired from a code in linux kernel where the current checker flags a warning while it should not. A patch by Aditya Kumar! Differential Revision: http://reviews.llvm.org/D9924 llvm-svn: 248446
114 lines
2.4 KiB
C
114 lines
2.4 KiB
C
// RUN: %clang_cc1 -analyze -analyzer-checker=alpha.security.MallocOverflow -verify %s
|
|
|
|
#define NULL ((void *) 0)
|
|
typedef __typeof__(sizeof(int)) size_t;
|
|
extern void * malloc(size_t);
|
|
|
|
void * f1(int n)
|
|
{
|
|
return malloc(n * sizeof(int)); // expected-warning {{the computation of the size of the memory allocation may overflow}}
|
|
}
|
|
|
|
void * f2(int n)
|
|
{
|
|
return malloc(sizeof(int) * n); // // expected-warning {{the computation of the size of the memory allocation may overflow}}
|
|
}
|
|
|
|
void * f3()
|
|
{
|
|
return malloc(4 * sizeof(int)); // no-warning
|
|
}
|
|
|
|
struct s4
|
|
{
|
|
int n;
|
|
};
|
|
|
|
void * f4(struct s4 *s)
|
|
{
|
|
return malloc(s->n * sizeof(int)); // expected-warning {{the computation of the size of the memory allocation may overflow}}
|
|
}
|
|
|
|
void * f5(struct s4 *s)
|
|
{
|
|
struct s4 s2 = *s;
|
|
return malloc(s2.n * sizeof(int)); // expected-warning {{the computation of the size of the memory allocation may overflow}}
|
|
}
|
|
|
|
void * f6(int n)
|
|
{
|
|
return malloc((n + 1) * sizeof(int)); // expected-warning {{the computation of the size of the memory allocation may overflow}}
|
|
}
|
|
|
|
extern void * malloc (size_t);
|
|
|
|
void * f7(int n)
|
|
{
|
|
if (n > 10)
|
|
return NULL;
|
|
return malloc(n * sizeof(int)); // no-warning
|
|
}
|
|
|
|
void * f8(int n)
|
|
{
|
|
if (n < 10)
|
|
return malloc(n * sizeof(int)); // no-warning
|
|
else
|
|
return NULL;
|
|
}
|
|
|
|
void * f9(int n)
|
|
{
|
|
int * x = malloc(n * sizeof(int)); // expected-warning {{the computation of the size of the memory allocation may overflow}}
|
|
for (int i = 0; i < n; i++)
|
|
x[i] = i;
|
|
return x;
|
|
}
|
|
|
|
void * f10(int n)
|
|
{
|
|
int * x = malloc(n * sizeof(int)); // expected-warning {{the computation of the size of the memory allocation may overflow}}
|
|
int i = 0;
|
|
while (i < n)
|
|
x[i++] = 0;
|
|
return x;
|
|
}
|
|
|
|
void * f11(int n)
|
|
{
|
|
int * x = malloc(n * sizeof(int)); // expected-warning {{the computation of the size of the memory allocation may overflow}}
|
|
int i = 0;
|
|
do {
|
|
x[i++] = 0;
|
|
} while (i < n);
|
|
return x;
|
|
}
|
|
|
|
void * f12(int n)
|
|
{
|
|
n = (n > 10 ? 10 : n);
|
|
int * x = malloc(n * sizeof(int)); // no-warning
|
|
for (int i = 0; i < n; i++)
|
|
x[i] = i;
|
|
return x;
|
|
}
|
|
|
|
struct s13
|
|
{
|
|
int n;
|
|
};
|
|
|
|
void * f13(struct s13 *s)
|
|
{
|
|
if (s->n > 10)
|
|
return NULL;
|
|
return malloc(s->n * sizeof(int)); // no-warning
|
|
}
|
|
|
|
void * f14(int n)
|
|
{
|
|
if (n < 0)
|
|
return NULL;
|
|
return malloc(n * sizeof(int)); // expected-warning {{the computation of the size of the memory allocation may overflow}}
|
|
}
|