mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-20 20:15:49 -04:00
5dca0596a9
Summary: Many of our tests need to initialize certain subsystems/plugins of LLDB such as `FileSystem` or `HostInfo` by calling their static `Initialize` functions before the test starts and then calling `::Terminate` after the test is done (in reverse order). This adds a lot of error-prone boilerplate code to our testing code. This patch adds a RAII called SubsystemRAII that ensures that we always call ::Initialize and then call ::Terminate after the test is done (and that the Terminate calls are always in the reverse order of the ::Initialize calls). It also gets rid of all of the boilerplate that we had for these calls. Per-fixture initialization is still not very nice with this approach as it would require some kind of static unique_ptr that gets manually assigned/reseted from the gtest SetUpTestCase/TearDownTestCase functions. Because of that I changed all per-fixture setup to now do per-test setup which can be done by just having the SubsystemRAII as a member of the test fixture. This change doesn't influence our normal test runtime as LIT anyway runs each test case separately (and the Initialize/Terminate calls are anyway not very expensive). It will however make running all tests in a single executable slightly slower. Reviewers: labath, JDevlieghere, martong, espindola, shafik Reviewed By: labath Subscribers: mgorny, rnkovacs, emaste, MaskRay, abidh, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D71630
161 lines
6.7 KiB
C++
161 lines
6.7 KiB
C++
//===-- CppModuleConfigurationTest.cpp ---------------------------*- C++-*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "Plugins/ExpressionParser/Clang/CppModuleConfiguration.h"
|
|
#include "Plugins/ExpressionParser/Clang/ClangHost.h"
|
|
#include "TestingSupport/SubsystemRAII.h"
|
|
#include "lldb/Host/FileSystem.h"
|
|
#include "lldb/Host/HostInfo.h"
|
|
|
|
#include "gmock/gmock.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
using namespace lldb_private;
|
|
|
|
namespace {
|
|
struct CppModuleConfigurationTest : public testing::Test {
|
|
SubsystemRAII<FileSystem, HostInfo> subsystems;
|
|
};
|
|
} // namespace
|
|
|
|
/// Returns the Clang resource include directory.
|
|
static std::string ResourceInc() {
|
|
llvm::SmallString<256> resource_dir;
|
|
llvm::sys::path::append(resource_dir, GetClangResourceDir().GetPath(),
|
|
"include");
|
|
return resource_dir.str().str();
|
|
}
|
|
|
|
/// Utility function turningn a list of paths into a FileSpecList.
|
|
static FileSpecList makeFiles(llvm::ArrayRef<std::string> paths) {
|
|
FileSpecList result;
|
|
for (const std::string &path : paths)
|
|
result.Append(FileSpec(path, FileSpec::Style::posix));
|
|
return result;
|
|
}
|
|
|
|
TEST_F(CppModuleConfigurationTest, Linux) {
|
|
// Test the average Linux configuration.
|
|
std::string libcpp = "/usr/include/c++/v1";
|
|
std::string usr = "/usr/include";
|
|
CppModuleConfiguration config(
|
|
makeFiles({usr + "/bits/types.h", libcpp + "/vector"}));
|
|
EXPECT_THAT(config.GetImportedModules(), testing::ElementsAre("std"));
|
|
EXPECT_THAT(config.GetIncludeDirs(),
|
|
testing::ElementsAre(libcpp, ResourceInc(), usr));
|
|
}
|
|
|
|
TEST_F(CppModuleConfigurationTest, Sysroot) {
|
|
// Test that having a sysroot for the whole system works fine.
|
|
std::string libcpp = "/home/user/sysroot/usr/include/c++/v1";
|
|
std::string usr = "/home/user/sysroot/usr/include";
|
|
CppModuleConfiguration config(
|
|
makeFiles({usr + "/bits/types.h", libcpp + "/vector"}));
|
|
EXPECT_THAT(config.GetImportedModules(), testing::ElementsAre("std"));
|
|
EXPECT_THAT(config.GetIncludeDirs(),
|
|
testing::ElementsAre(libcpp, ResourceInc(), usr));
|
|
}
|
|
|
|
TEST_F(CppModuleConfigurationTest, LinuxLocalLibCpp) {
|
|
// Test that a locally build libc++ is detected.
|
|
std::string libcpp = "/home/user/llvm-build/include/c++/v1";
|
|
std::string usr = "/usr/include";
|
|
CppModuleConfiguration config(
|
|
makeFiles({usr + "/bits/types.h", libcpp + "/vector"}));
|
|
EXPECT_THAT(config.GetImportedModules(), testing::ElementsAre("std"));
|
|
EXPECT_THAT(config.GetIncludeDirs(),
|
|
testing::ElementsAre(libcpp, ResourceInc(), usr));
|
|
}
|
|
|
|
TEST_F(CppModuleConfigurationTest, UnrelatedLibrary) {
|
|
// Test that having an unrelated library in /usr/include doesn't break.
|
|
std::string libcpp = "/home/user/llvm-build/include/c++/v1";
|
|
std::string usr = "/usr/include";
|
|
CppModuleConfiguration config(makeFiles(
|
|
{usr + "/bits/types.h", libcpp + "/vector", usr + "/boost/vector"}));
|
|
EXPECT_THAT(config.GetImportedModules(), testing::ElementsAre("std"));
|
|
EXPECT_THAT(config.GetIncludeDirs(),
|
|
testing::ElementsAre(libcpp, ResourceInc(), usr));
|
|
}
|
|
|
|
TEST_F(CppModuleConfigurationTest, Xcode) {
|
|
// Test detection of libc++ coming from Xcode with generic platform names.
|
|
std::string p = "/Applications/Xcode.app/Contents/Developer/";
|
|
std::string libcpp = p + "Toolchains/B.xctoolchain/usr/include/c++/v1";
|
|
std::string usr =
|
|
p + "Platforms/A.platform/Developer/SDKs/OSVers.sdk/usr/include";
|
|
CppModuleConfiguration config(
|
|
makeFiles({libcpp + "/unordered_map", usr + "/stdio.h"}));
|
|
EXPECT_THAT(config.GetImportedModules(), testing::ElementsAre("std"));
|
|
EXPECT_THAT(config.GetIncludeDirs(),
|
|
testing::ElementsAre(libcpp, ResourceInc(), usr));
|
|
}
|
|
|
|
TEST_F(CppModuleConfigurationTest, LibCppV2) {
|
|
// Test that a "v2" of libc++ is still correctly detected.
|
|
CppModuleConfiguration config(
|
|
makeFiles({"/usr/include/bits/types.h", "/usr/include/c++/v2/vector"}));
|
|
EXPECT_THAT(config.GetImportedModules(), testing::ElementsAre("std"));
|
|
EXPECT_THAT(config.GetIncludeDirs(),
|
|
testing::ElementsAre("/usr/include/c++/v2", ResourceInc(),
|
|
"/usr/include"));
|
|
}
|
|
|
|
TEST_F(CppModuleConfigurationTest, UnknownLibCppFile) {
|
|
// Test that having some unknown file in the libc++ path doesn't break
|
|
// anything.
|
|
CppModuleConfiguration config(makeFiles(
|
|
{"/usr/include/bits/types.h", "/usr/include/c++/v1/non_existing_file"}));
|
|
EXPECT_THAT(config.GetImportedModules(), testing::ElementsAre("std"));
|
|
EXPECT_THAT(config.GetIncludeDirs(),
|
|
testing::ElementsAre("/usr/include/c++/v1", ResourceInc(),
|
|
"/usr/include"));
|
|
}
|
|
|
|
TEST_F(CppModuleConfigurationTest, MissingUsrInclude) {
|
|
// Test that we don't load 'std' if we can't find the C standard library.
|
|
CppModuleConfiguration config(makeFiles({"/usr/include/c++/v1/vector"}));
|
|
EXPECT_THAT(config.GetImportedModules(), testing::ElementsAre());
|
|
EXPECT_THAT(config.GetIncludeDirs(), testing::ElementsAre());
|
|
}
|
|
|
|
TEST_F(CppModuleConfigurationTest, MissingLibCpp) {
|
|
// Test that we don't load 'std' if we don't have a libc++.
|
|
CppModuleConfiguration config(makeFiles({"/usr/include/bits/types.h"}));
|
|
EXPECT_THAT(config.GetImportedModules(), testing::ElementsAre());
|
|
EXPECT_THAT(config.GetIncludeDirs(), testing::ElementsAre());
|
|
}
|
|
|
|
TEST_F(CppModuleConfigurationTest, IgnoreLibStdCpp) {
|
|
// Test that we don't do anything bad when we encounter libstdc++ paths.
|
|
CppModuleConfiguration config(makeFiles(
|
|
{"/usr/include/bits/types.h", "/usr/include/c++/8.0.1/vector"}));
|
|
EXPECT_THAT(config.GetImportedModules(), testing::ElementsAre());
|
|
EXPECT_THAT(config.GetIncludeDirs(), testing::ElementsAre());
|
|
}
|
|
|
|
TEST_F(CppModuleConfigurationTest, AmbiguousCLib) {
|
|
// Test that we don't do anything when we are not sure where the
|
|
// right C standard library is.
|
|
CppModuleConfiguration config(
|
|
makeFiles({"/usr/include/bits/types.h", "/usr/include/c++/v1/vector",
|
|
"/sysroot/usr/include/bits/types.h"}));
|
|
EXPECT_THAT(config.GetImportedModules(), testing::ElementsAre());
|
|
EXPECT_THAT(config.GetIncludeDirs(), testing::ElementsAre());
|
|
}
|
|
|
|
TEST_F(CppModuleConfigurationTest, AmbiguousLibCpp) {
|
|
// Test that we don't do anything when we are not sure where the
|
|
// right libc++ is.
|
|
CppModuleConfiguration config(
|
|
makeFiles({"/usr/include/bits/types.h", "/usr/include/c++/v1/vector",
|
|
"/usr/include/c++/v2/vector"}));
|
|
EXPECT_THAT(config.GetImportedModules(), testing::ElementsAre());
|
|
EXPECT_THAT(config.GetIncludeDirs(), testing::ElementsAre());
|
|
}
|