mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-20 12:05:48 -04:00
405c3a6be1
Summary: Creates a new darwin ClangTidy module and adds the darwin-dispatch-once-nonstatic check that warns about dispatch_once_t variables not in static or global storage. This catches a missing static for local variables in e.g. singleton initialization behavior, and also warns on storing dispatch_once_t values in Objective-C instance variables. C/C++ struct/class instances may potentially live in static/global storage, and are ignored for this check. The osx.API static analysis checker can find the non-static storage use of dispatch_once_t; I thought it useful to also catch this issue in clang-tidy when possible. This is a re-land of https://reviews.llvm.org/D67567 Reviewers: thakis, gribozavr, stephanemoore Subscribers: Eugene.Zelenko, mgorny, xazax.hun, jkorous, arphaman, kadircet, usaxena95 Tags: #clang-tools-extra, #clang, #llvm Differential Revision: https://reviews.llvm.org/D68109 llvm-svn: 373065
38 lines
1.2 KiB
C++
38 lines
1.2 KiB
C++
//===--- MiscTidyModule.cpp - clang-tidy ----------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "../ClangTidy.h"
|
|
#include "../ClangTidyModule.h"
|
|
#include "../ClangTidyModuleRegistry.h"
|
|
#include "DispatchOnceNonstaticCheck.h"
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
namespace darwin {
|
|
|
|
class DarwinModule : public ClangTidyModule {
|
|
public:
|
|
void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
|
|
CheckFactories.registerCheck<DispatchOnceNonstaticCheck>(
|
|
"darwin-dispatch-once-nonstatic");
|
|
}
|
|
};
|
|
|
|
} // namespace darwin
|
|
|
|
// Register the DarwinTidyModule using this statically initialized variable.
|
|
static ClangTidyModuleRegistry::Add<darwin::DarwinModule>
|
|
X("misc-module", "Adds miscellaneous lint checks.");
|
|
|
|
// This anchor is used to force the linker to link in the generated object file
|
|
// and thus register the DarwinModule.
|
|
volatile int DarwinModuleAnchorSource = 0;
|
|
|
|
} // namespace tidy
|
|
} // namespace clang
|