mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-24 14:05:49 -04:00
2f93fd1f50
Summary: During the previous attempt to generalize the UUID class, it was suggested that we represent invalid UUIDs as length zero (previously, we used an all-zero UUID for that). This meant that some valid build-ids could not be represented (it's possible however unlikely that a checksum of some file would be zero) and complicated adding support for variable length build-ids (should a 16-byte empty UUID compare equal to a 20-byte empty UUID?). This patch resolves these issues by introducing a canonical representation for an invalid UUID. The slight complication here is that some clients (MachO) actually use the all-zero notation to mean "no UUID has been set". To keep this use case working (while making it very explicit about which construction semantices are wanted), replaced the UUID constructors and the SetBytes functions with named factory methods. - "fromData" creates a UUID from the given data, and it treats all bytes equally. - "fromOptionalData" first checks the data contents - if all bytes are zero, it treats this as an invalid/empty UUID. Reviewers: clayborg, sas, lemo, davide, espindola Subscribers: emaste, lldb-commits, arichardson Differential Revision: https://reviews.llvm.org/D48479 llvm-svn: 335612
74 lines
2.2 KiB
C++
74 lines
2.2 KiB
C++
//===-- UUIDTest.cpp --------------------------------------------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "gtest/gtest.h"
|
|
|
|
#include "lldb/Utility/UUID.h"
|
|
|
|
using namespace lldb_private;
|
|
|
|
TEST(UUIDTest, RelationalOperators) {
|
|
UUID empty;
|
|
UUID a16 = UUID::fromData("1234567890123456", 16);
|
|
UUID b16 = UUID::fromData("1234567890123457", 16);
|
|
UUID a20 = UUID::fromData("12345678901234567890", 20);
|
|
UUID b20 = UUID::fromData("12345678900987654321", 20);
|
|
|
|
EXPECT_EQ(empty, empty);
|
|
EXPECT_EQ(a16, a16);
|
|
EXPECT_EQ(a20, a20);
|
|
|
|
EXPECT_NE(a16, b16);
|
|
EXPECT_NE(a20, b20);
|
|
EXPECT_NE(a16, a20);
|
|
EXPECT_NE(empty, a16);
|
|
|
|
EXPECT_LT(empty, a16);
|
|
EXPECT_LT(a16, a20);
|
|
EXPECT_LT(a16, b16);
|
|
EXPECT_GT(a20, b20);
|
|
}
|
|
|
|
TEST(UUIDTest, Validity) {
|
|
UUID empty;
|
|
std::vector<uint8_t> zeroes(20, 0);
|
|
UUID a16 = UUID::fromData(zeroes.data(), 16);
|
|
UUID a20 = UUID::fromData(zeroes.data(), 20);
|
|
UUID a16_0 = UUID::fromOptionalData(zeroes.data(), 16);
|
|
UUID a20_0 = UUID::fromOptionalData(zeroes.data(), 20);
|
|
EXPECT_FALSE(empty);
|
|
EXPECT_TRUE(a16);
|
|
EXPECT_TRUE(a20);
|
|
EXPECT_FALSE(a16_0);
|
|
EXPECT_FALSE(a20_0);
|
|
}
|
|
|
|
TEST(UUIDTest, SetFromStringRef) {
|
|
UUID u;
|
|
EXPECT_EQ(32u, u.SetFromStringRef("404142434445464748494a4b4c4d4e4f"));
|
|
EXPECT_EQ(UUID::fromData("@ABCDEFGHIJKLMNO", 16), u);
|
|
|
|
EXPECT_EQ(36u, u.SetFromStringRef("40-41-42-43-4445464748494a4b4c4d4e4f"));
|
|
EXPECT_EQ(UUID::fromData("@ABCDEFGHIJKLMNO", 16), u);
|
|
|
|
EXPECT_EQ(45u, u.SetFromStringRef(
|
|
"40-41-42-43-4445464748494a4b4c4d4e4f-50515253", 20));
|
|
EXPECT_EQ(UUID::fromData("@ABCDEFGHIJKLMNOPQRS", 20), u);
|
|
|
|
EXPECT_EQ(0u, u.SetFromStringRef("40-41-42-43-4445464748494a4b4c4d4e4f", 20));
|
|
EXPECT_EQ(0u, u.SetFromStringRef("40xxxxx"));
|
|
EXPECT_EQ(0u, u.SetFromStringRef(""));
|
|
EXPECT_EQ(UUID::fromData("@ABCDEFGHIJKLMNOPQRS", 20), u)
|
|
<< "uuid was changed by failed parse calls";
|
|
|
|
EXPECT_EQ(
|
|
32u, u.SetFromStringRef("404142434445464748494a4b4c4d4e4f-50515253", 16));
|
|
EXPECT_EQ(UUID::fromData("@ABCDEFGHIJKLMNO", 16), u);
|
|
}
|