teak-llvm/lldb/source/API/SBModuleSpec.cpp
Pavel Labath 2f93fd1f50 Represent invalid UUIDs as UUIDs with length zero
Summary:
During the previous attempt to generalize the UUID class, it was
suggested that we represent invalid UUIDs as length zero (previously, we
used an all-zero UUID for that). This meant that some valid build-ids
could not be represented (it's possible however unlikely that a checksum of
some file would be zero) and complicated adding support for variable
length build-ids (should a 16-byte empty UUID compare equal to a 20-byte
empty UUID?).

This patch resolves these issues by introducing a canonical
representation for an invalid UUID. The slight complication here is that
some clients (MachO) actually use the all-zero notation to mean "no UUID
has been set". To keep this use case working (while making it very
explicit about which construction semantices are wanted), replaced the
UUID constructors and the SetBytes functions with named factory methods.
- "fromData" creates a UUID from the given data, and it treats all bytes
  equally.
- "fromOptionalData" first checks the data contents - if all bytes are
  zero, it treats this as an invalid/empty UUID.

Reviewers: clayborg, sas, lemo, davide, espindola

Subscribers: emaste, lldb-commits, arichardson

Differential Revision: https://reviews.llvm.org/D48479

llvm-svn: 335612
2018-06-26 15:12:20 +00:00

159 lines
4.7 KiB
C++

//===-- SBModuleSpec.cpp ----------------------------------------*- C++ -*-===//
//
// The LLVM Compiler Infrastructure
//
// This file is distributed under the University of Illinois Open Source
// License. See LICENSE.TXT for details.
//
//===----------------------------------------------------------------------===//
#include "lldb/API/SBModuleSpec.h"
#include "lldb/API/SBStream.h"
#include "lldb/Core/Module.h"
#include "lldb/Core/ModuleSpec.h"
#include "lldb/Host/Host.h"
#include "lldb/Symbol/ObjectFile.h"
#include "lldb/Utility/Stream.h"
using namespace lldb;
using namespace lldb_private;
SBModuleSpec::SBModuleSpec() : m_opaque_ap(new lldb_private::ModuleSpec()) {}
SBModuleSpec::SBModuleSpec(const SBModuleSpec &rhs)
: m_opaque_ap(new lldb_private::ModuleSpec(*rhs.m_opaque_ap)) {}
const SBModuleSpec &SBModuleSpec::operator=(const SBModuleSpec &rhs) {
if (this != &rhs)
*m_opaque_ap = *(rhs.m_opaque_ap);
return *this;
}
SBModuleSpec::~SBModuleSpec() {}
bool SBModuleSpec::IsValid() const { return m_opaque_ap->operator bool(); }
void SBModuleSpec::Clear() { m_opaque_ap->Clear(); }
SBFileSpec SBModuleSpec::GetFileSpec() {
SBFileSpec sb_spec(m_opaque_ap->GetFileSpec());
return sb_spec;
}
void SBModuleSpec::SetFileSpec(const lldb::SBFileSpec &sb_spec) {
m_opaque_ap->GetFileSpec() = *sb_spec;
}
lldb::SBFileSpec SBModuleSpec::GetPlatformFileSpec() {
return SBFileSpec(m_opaque_ap->GetPlatformFileSpec());
}
void SBModuleSpec::SetPlatformFileSpec(const lldb::SBFileSpec &sb_spec) {
m_opaque_ap->GetPlatformFileSpec() = *sb_spec;
}
lldb::SBFileSpec SBModuleSpec::GetSymbolFileSpec() {
return SBFileSpec(m_opaque_ap->GetSymbolFileSpec());
}
void SBModuleSpec::SetSymbolFileSpec(const lldb::SBFileSpec &sb_spec) {
m_opaque_ap->GetSymbolFileSpec() = *sb_spec;
}
const char *SBModuleSpec::GetObjectName() {
return m_opaque_ap->GetObjectName().GetCString();
}
void SBModuleSpec::SetObjectName(const char *name) {
m_opaque_ap->GetObjectName().SetCString(name);
}
const char *SBModuleSpec::GetTriple() {
std::string triple(m_opaque_ap->GetArchitecture().GetTriple().str());
// Unique the string so we don't run into ownership issues since the const
// strings put the string into the string pool once and the strings never
// comes out
ConstString const_triple(triple.c_str());
return const_triple.GetCString();
}
void SBModuleSpec::SetTriple(const char *triple) {
m_opaque_ap->GetArchitecture().SetTriple(triple);
}
const uint8_t *SBModuleSpec::GetUUIDBytes() {
return m_opaque_ap->GetUUID().GetBytes().data();
}
size_t SBModuleSpec::GetUUIDLength() {
return m_opaque_ap->GetUUID().GetBytes().size();
}
bool SBModuleSpec::SetUUIDBytes(const uint8_t *uuid, size_t uuid_len) {
m_opaque_ap->GetUUID() = UUID::fromOptionalData(uuid, uuid_len);
return m_opaque_ap->GetUUID().IsValid();
}
bool SBModuleSpec::GetDescription(lldb::SBStream &description) {
m_opaque_ap->Dump(description.ref());
return true;
}
SBModuleSpecList::SBModuleSpecList() : m_opaque_ap(new ModuleSpecList()) {}
SBModuleSpecList::SBModuleSpecList(const SBModuleSpecList &rhs)
: m_opaque_ap(new ModuleSpecList(*rhs.m_opaque_ap)) {}
SBModuleSpecList &SBModuleSpecList::operator=(const SBModuleSpecList &rhs) {
if (this != &rhs)
*m_opaque_ap = *rhs.m_opaque_ap;
return *this;
}
SBModuleSpecList::~SBModuleSpecList() {}
SBModuleSpecList SBModuleSpecList::GetModuleSpecifications(const char *path) {
SBModuleSpecList specs;
FileSpec file_spec(path, true);
Host::ResolveExecutableInBundle(file_spec);
ObjectFile::GetModuleSpecifications(file_spec, 0, 0, *specs.m_opaque_ap);
return specs;
}
void SBModuleSpecList::Append(const SBModuleSpec &spec) {
m_opaque_ap->Append(*spec.m_opaque_ap);
}
void SBModuleSpecList::Append(const SBModuleSpecList &spec_list) {
m_opaque_ap->Append(*spec_list.m_opaque_ap);
}
size_t SBModuleSpecList::GetSize() { return m_opaque_ap->GetSize(); }
SBModuleSpec SBModuleSpecList::GetSpecAtIndex(size_t i) {
SBModuleSpec sb_module_spec;
m_opaque_ap->GetModuleSpecAtIndex(i, *sb_module_spec.m_opaque_ap);
return sb_module_spec;
}
SBModuleSpec
SBModuleSpecList::FindFirstMatchingSpec(const SBModuleSpec &match_spec) {
SBModuleSpec sb_module_spec;
m_opaque_ap->FindMatchingModuleSpec(*match_spec.m_opaque_ap,
*sb_module_spec.m_opaque_ap);
return sb_module_spec;
}
SBModuleSpecList
SBModuleSpecList::FindMatchingSpecs(const SBModuleSpec &match_spec) {
SBModuleSpecList specs;
m_opaque_ap->FindMatchingModuleSpecs(*match_spec.m_opaque_ap,
*specs.m_opaque_ap);
return specs;
}
bool SBModuleSpecList::GetDescription(lldb::SBStream &description) {
m_opaque_ap->Dump(description.ref());
return true;
}