mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-21 12:35:47 -04:00

Summary: This check flags all calls to c-style vararg functions and all use of va_list, va_start and va_arg. Passing to varargs assumes the correct type will be read. This is fragile because it cannot generally be enforced to be safe in the language and so relies on programmer discipline to get it right. This rule is part of the "Type safety" profile of the C++ Core Guidelines, see https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#-type8-avoid-reading-from-varargs-or-passing-vararg-arguments-prefer-variadic-template-parameters-instead This commits also reverts "[clang-tidy] add cert's VariadicFunctionDefCheck as cppcoreguidelines-pro-type-vararg-def" because that check makes the SFINAE use of vararg functions impossible. Reviewers: alexfh, sbenza, bkramer, aaron.ballman Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D13787 llvm-svn: 250939
58 lines
2.2 KiB
C++
58 lines
2.2 KiB
C++
//===--- CppCoreGuidelinesModule.cpp - clang-tidy -------------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "../ClangTidy.h"
|
|
#include "../ClangTidyModule.h"
|
|
#include "../ClangTidyModuleRegistry.h"
|
|
#include "../misc/AssignOperatorSignatureCheck.h"
|
|
#include "ProBoundsPointerArithmeticCheck.h"
|
|
#include "ProTypeConstCastCheck.h"
|
|
#include "ProTypeReinterpretCastCheck.h"
|
|
#include "ProTypeStaticCastDowncastCheck.h"
|
|
#include "ProTypeUnionAccessCheck.h"
|
|
#include "ProTypeVarargCheck.h"
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
namespace cppcoreguidelines {
|
|
|
|
/// A module containing checks of the C++ Core Guidelines
|
|
class CppCoreGuidelinesModule : public ClangTidyModule {
|
|
public:
|
|
void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
|
|
CheckFactories.registerCheck<ProBoundsPointerArithmeticCheck>(
|
|
"cppcoreguidelines-pro-bounds-pointer-arithmetic");
|
|
CheckFactories.registerCheck<ProTypeConstCastCheck>(
|
|
"cppcoreguidelines-pro-type-const-cast");
|
|
CheckFactories.registerCheck<ProTypeReinterpretCastCheck>(
|
|
"cppcoreguidelines-pro-type-reinterpret-cast");
|
|
CheckFactories.registerCheck<ProTypeStaticCastDowncastCheck>(
|
|
"cppcoreguidelines-pro-type-static-cast-downcast");
|
|
CheckFactories.registerCheck<ProTypeUnionAccessCheck>(
|
|
"cppcoreguidelines-pro-type-union-access");
|
|
CheckFactories.registerCheck<ProTypeVarargCheck>(
|
|
"cppcoreguidelines-pro-type-vararg");
|
|
CheckFactories.registerCheck<misc::AssignOperatorSignatureCheck>(
|
|
"cppcoreguidelines-c-copy-assignment-signature");
|
|
}
|
|
};
|
|
|
|
// Register the LLVMTidyModule using this statically initialized variable.
|
|
static ClangTidyModuleRegistry::Add<CppCoreGuidelinesModule>
|
|
X("cppcoreguidelines-module", "Adds checks for the C++ Core Guidelines.");
|
|
|
|
} // namespace cppcoreguidelines
|
|
|
|
// This anchor is used to force the linker to link in the generated object file
|
|
// and thus register the CppCoreGuidelinesModule.
|
|
volatile int CppCoreGuidelinesModuleAnchorSource = 0;
|
|
|
|
} // namespace tidy
|
|
} // namespace clang
|