mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-24 05:55:43 -04:00

Summary: test_set_working_dir was testing two scenario: failure to set the working dir because of a non existent directory and succeeding to set the working directory. Since the negative case fails on both Linux and Windows, the positive case was never tested. I split the test into two which allows us to always run both the negative and positive cases. The positive case now succeeds on Linux and the negative case still fails. During the investigation, it turned out that lldbtest.py will try to execute a process launch command up to 3 times if the command failed. This means that we could be covering up intermittent failures by running any test that does process launch multiple times without ever realizing it. I've changed the counter to 1 (though it can still be overwritten with the environment variable). This change also fixes both the positive and negative cases on Windows. There were a few issues: 1) In ProcessLauncherWindows::LaunchProcess, the error was not retrieved until CloseHandle was possibly called. Since CloseHandle is also a system API, its success would overwrite any existing error that could be retrieved using GetLastError. So by the time the error was retrieved, it was now a success. 2) In DebuggerThread::StopDebugging TerminateProcess was called on the process handle regardless of whether it was a valid handle. This was causing the process to crash when the handle was LLDB_INVALID_PROCESS (0xFFFFFFFF). 3) In ProcessWindows::DoLaunch we need to check that the working directory exists before launching the process to have the same behavior as other platforms which first check the directory and then launch process. This way we also control the exact error string. Reviewers: labath, zturner, asmith, jingham Reviewed By: labath Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D48050 llvm-svn: 334642
209 lines
7.0 KiB
Python
209 lines
7.0 KiB
Python
"""
|
|
Test lldb process launch flags.
|
|
"""
|
|
|
|
from __future__ import print_function
|
|
|
|
import copy
|
|
import os
|
|
import time
|
|
|
|
import lldb
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
import six
|
|
|
|
|
|
class ProcessLaunchTestCase(TestBase):
|
|
|
|
mydir = TestBase.compute_mydir(__file__)
|
|
NO_DEBUG_INFO_TESTCASE = True
|
|
|
|
def setUp(self):
|
|
# Call super's setUp().
|
|
TestBase.setUp(self)
|
|
self.runCmd("settings set auto-confirm true")
|
|
|
|
def tearDown(self):
|
|
self.runCmd("settings clear auto-confirm")
|
|
TestBase.tearDown(self)
|
|
|
|
@not_remote_testsuite_ready
|
|
def test_io(self):
|
|
"""Test that process launch I/O redirection flags work properly."""
|
|
self.build()
|
|
exe = self.getBuildArtifact("a.out")
|
|
self.expect("file " + exe,
|
|
patterns=["Current executable set to .*a.out"])
|
|
|
|
in_file = os.path.join(self.getSourceDir(), "input-file.txt")
|
|
out_file = lldbutil.append_to_process_working_directory(self, "output-test.out")
|
|
err_file = lldbutil.append_to_process_working_directory(self, "output-test.err")
|
|
|
|
# Make sure the output files do not exist before launching the process
|
|
try:
|
|
os.remove(out_file)
|
|
except OSError:
|
|
pass
|
|
|
|
try:
|
|
os.remove(err_file)
|
|
except OSError:
|
|
pass
|
|
|
|
launch_command = "process launch -i '{0}' -o '{1}' -e '{2}' -w '{3}'".format(
|
|
in_file, out_file, err_file, self.get_process_working_directory())
|
|
|
|
if lldb.remote_platform:
|
|
self.runCmd('platform put-file "{local}" "{remote}"'.format(
|
|
local=in_file, remote=in_file))
|
|
|
|
self.expect(launch_command,
|
|
patterns=["Process .* launched: .*a.out"])
|
|
|
|
success = True
|
|
err_msg = ""
|
|
|
|
out = lldbutil.read_file_on_target(self, out_file)
|
|
if out != "This should go to stdout.\n":
|
|
success = False
|
|
err_msg = err_msg + " ERROR: stdout file does not contain correct output.\n"
|
|
|
|
|
|
err = lldbutil.read_file_on_target(self, err_file)
|
|
if err != "This should go to stderr.\n":
|
|
success = False
|
|
err_msg = err_msg + " ERROR: stderr file does not contain correct output.\n"
|
|
|
|
if not success:
|
|
self.fail(err_msg)
|
|
|
|
# rdar://problem/9056462
|
|
# The process launch flag '-w' for setting the current working directory
|
|
# not working?
|
|
@not_remote_testsuite_ready
|
|
@expectedFailureAll(oslist=["linux"], bugnumber="llvm.org/pr20265")
|
|
def test_set_working_dir_nonexisting(self):
|
|
"""Test that '-w dir' fails to set the working dir when running the inferior with a dir which doesn't exist."""
|
|
d = {'CXX_SOURCES': 'print_cwd.cpp'}
|
|
self.build(dictionary=d)
|
|
self.setTearDownCleanup(d)
|
|
exe = self.getBuildArtifact("a.out")
|
|
self.runCmd("file " + exe)
|
|
|
|
mywd = 'my_working_dir'
|
|
out_file_name = "my_working_dir_test.out"
|
|
err_file_name = "my_working_dir_test.err"
|
|
|
|
my_working_dir_path = self.getBuildArtifact(mywd)
|
|
out_file_path = os.path.join(my_working_dir_path, out_file_name)
|
|
err_file_path = os.path.join(my_working_dir_path, err_file_name)
|
|
|
|
# Check that we get an error when we have a nonexisting path
|
|
invalid_dir_path = mywd + 'z'
|
|
launch_command = "process launch -w %s -o %s -e %s" % (
|
|
invalid_dir_path, out_file_path, err_file_path)
|
|
|
|
self.expect(
|
|
launch_command, error=True, patterns=[
|
|
"error:.* No such file or directory: %s" %
|
|
invalid_dir_path])
|
|
|
|
@not_remote_testsuite_ready
|
|
def test_set_working_dir_existing(self):
|
|
"""Test that '-w dir' sets the working dir when running the inferior."""
|
|
d = {'CXX_SOURCES': 'print_cwd.cpp'}
|
|
self.build(dictionary=d)
|
|
self.setTearDownCleanup(d)
|
|
exe = self.getBuildArtifact("a.out")
|
|
self.runCmd("file " + exe)
|
|
|
|
mywd = 'my_working_dir'
|
|
out_file_name = "my_working_dir_test.out"
|
|
err_file_name = "my_working_dir_test.err"
|
|
|
|
my_working_dir_path = self.getBuildArtifact(mywd)
|
|
lldbutil.mkdir_p(my_working_dir_path)
|
|
out_file_path = os.path.join(my_working_dir_path, out_file_name)
|
|
err_file_path = os.path.join(my_working_dir_path, err_file_name)
|
|
|
|
# Make sure the output files do not exist before launching the process
|
|
try:
|
|
os.remove(out_file_path)
|
|
os.remove(err_file_path)
|
|
except OSError:
|
|
pass
|
|
|
|
launch_command = "process launch -w %s -o %s -e %s" % (
|
|
my_working_dir_path, out_file_path, err_file_path)
|
|
|
|
self.expect(launch_command,
|
|
patterns=["Process .* launched: .*a.out"])
|
|
|
|
success = True
|
|
err_msg = ""
|
|
|
|
# Check to see if the 'stdout' file was created
|
|
try:
|
|
out_f = open(out_file_path)
|
|
except IOError:
|
|
success = False
|
|
err_msg = err_msg + "ERROR: stdout file was not created.\n"
|
|
else:
|
|
# Check to see if the 'stdout' file contains the right output
|
|
line = out_f.readline()
|
|
if self.TraceOn():
|
|
print("line:", line)
|
|
if not re.search(mywd, line):
|
|
success = False
|
|
err_msg = err_msg + "The current working directory was not set correctly.\n"
|
|
out_f.close()
|
|
|
|
# Try to delete the 'stdout' and 'stderr' files
|
|
try:
|
|
os.remove(out_file_path)
|
|
os.remove(err_file_path)
|
|
pass
|
|
except OSError:
|
|
pass
|
|
|
|
if not success:
|
|
self.fail(err_msg)
|
|
|
|
def test_environment_with_special_char(self):
|
|
"""Test that environment variables containing '*' and '}' are handled correctly by the inferior."""
|
|
source = 'print_env.cpp'
|
|
d = {'CXX_SOURCES': source}
|
|
self.build(dictionary=d)
|
|
self.setTearDownCleanup(d)
|
|
exe = self.getBuildArtifact("a.out")
|
|
|
|
evil_var = 'INIT*MIDDLE}TAIL'
|
|
|
|
target = self.dbg.CreateTarget(exe)
|
|
main_source_spec = lldb.SBFileSpec(source)
|
|
breakpoint = target.BreakpointCreateBySourceRegex(
|
|
'// Set breakpoint here.', main_source_spec)
|
|
|
|
process = target.LaunchSimple(None,
|
|
['EVIL=' + evil_var],
|
|
self.get_process_working_directory())
|
|
self.assertEqual(
|
|
process.GetState(),
|
|
lldb.eStateStopped,
|
|
PROCESS_STOPPED)
|
|
|
|
threads = lldbutil.get_threads_stopped_at_breakpoint(
|
|
process, breakpoint)
|
|
self.assertEqual(len(threads), 1)
|
|
frame = threads[0].GetFrameAtIndex(0)
|
|
sbvalue = frame.EvaluateExpression("evil")
|
|
value = sbvalue.GetSummary().strip('"')
|
|
|
|
self.assertEqual(value, evil_var)
|
|
process.Continue()
|
|
self.assertEqual(process.GetState(), lldb.eStateExited, PROCESS_EXITED)
|
|
pass
|