mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-26 23:09:03 -04:00

This patch implements the initial support for refactoring action rules. The first rule that's supported is a "source change" rule that returns a set of atomic changes. This patch is based on the ideas presented in my RFC: http://lists.llvm.org/pipermail/cfe-dev/2017-July/054831.html The following pieces from the RFC are added by this patch: - `createRefactoringRule` (known as `apply` in the RFC) - `requiredSelection` refactoring action rule requirement. - `selection::SourceSelectionRange` selection constraint. Differential Revision: https://reviews.llvm.org/D36075 llvm-svn: 311884
166 lines
5.7 KiB
C++
166 lines
5.7 KiB
C++
//===- unittest/Tooling/RefactoringTestActionRulesTest.cpp ----------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "ReplacementTest.h"
|
|
#include "RewriterTestContext.h"
|
|
#include "clang/Tooling/Refactoring.h"
|
|
#include "clang/Tooling/Refactoring/RefactoringActionRules.h"
|
|
#include "clang/Tooling/Tooling.h"
|
|
#include "llvm/Support/Errc.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
using namespace clang;
|
|
using namespace tooling;
|
|
using namespace refactoring_action_rules;
|
|
|
|
namespace {
|
|
|
|
class RefactoringActionRulesTest : public ::testing::Test {
|
|
protected:
|
|
void SetUp() override {
|
|
Context.Sources.setMainFileID(
|
|
Context.createInMemoryFile("input.cpp", DefaultCode));
|
|
}
|
|
|
|
RewriterTestContext Context;
|
|
std::string DefaultCode = std::string(100, 'a');
|
|
};
|
|
|
|
Expected<Optional<AtomicChanges>>
|
|
createReplacements(const std::unique_ptr<RefactoringActionRule> &Rule,
|
|
RefactoringRuleContext &Context) {
|
|
return cast<SourceChangeRefactoringRule>(*Rule).createSourceReplacements(
|
|
Context);
|
|
}
|
|
|
|
TEST_F(RefactoringActionRulesTest, MyFirstRefactoringRule) {
|
|
auto ReplaceAWithB =
|
|
[](std::pair<selection::SourceSelectionRange, int> Selection)
|
|
-> Expected<AtomicChanges> {
|
|
const SourceManager &SM = Selection.first.getSources();
|
|
SourceLocation Loc = Selection.first.getRange().getBegin().getLocWithOffset(
|
|
Selection.second);
|
|
AtomicChange Change(SM, Loc);
|
|
llvm::Error E = Change.replace(SM, Loc, 1, "b");
|
|
if (E)
|
|
return std::move(E);
|
|
return AtomicChanges{Change};
|
|
};
|
|
class SelectionRequirement : public selection::Requirement {
|
|
public:
|
|
std::pair<selection::SourceSelectionRange, int>
|
|
evaluateSelection(selection::SourceSelectionRange Selection) const {
|
|
return std::make_pair(Selection, 20);
|
|
}
|
|
};
|
|
auto Rule = createRefactoringRule(ReplaceAWithB,
|
|
requiredSelection(SelectionRequirement()));
|
|
|
|
// When the requirements are satisifed, the rule's function must be invoked.
|
|
{
|
|
RefactoringRuleContext RefContext(Context.Sources);
|
|
SourceLocation Cursor =
|
|
Context.Sources.getLocForStartOfFile(Context.Sources.getMainFileID())
|
|
.getLocWithOffset(10);
|
|
RefContext.setSelectionRange({Cursor, Cursor});
|
|
|
|
Expected<Optional<AtomicChanges>> ErrorOrResult =
|
|
createReplacements(Rule, RefContext);
|
|
ASSERT_FALSE(!ErrorOrResult);
|
|
ASSERT_FALSE(!*ErrorOrResult);
|
|
AtomicChanges Result = std::move(**ErrorOrResult);
|
|
ASSERT_EQ(Result.size(), 1u);
|
|
std::string YAMLString =
|
|
const_cast<AtomicChange &>(Result[0]).toYAMLString();
|
|
|
|
ASSERT_STREQ("---\n"
|
|
"Key: 'input.cpp:30'\n"
|
|
"FilePath: input.cpp\n"
|
|
"Error: ''\n"
|
|
"InsertedHeaders: \n"
|
|
"RemovedHeaders: \n"
|
|
"Replacements: \n" // Extra whitespace here!
|
|
" - FilePath: input.cpp\n"
|
|
" Offset: 30\n"
|
|
" Length: 1\n"
|
|
" ReplacementText: b\n"
|
|
"...\n",
|
|
YAMLString.c_str());
|
|
}
|
|
|
|
// When one of the requirements is not satisfied, perform should return either
|
|
// None or a valid diagnostic.
|
|
{
|
|
RefactoringRuleContext RefContext(Context.Sources);
|
|
Expected<Optional<AtomicChanges>> ErrorOrResult =
|
|
createReplacements(Rule, RefContext);
|
|
|
|
ASSERT_FALSE(!ErrorOrResult);
|
|
Optional<AtomicChanges> Value = std::move(*ErrorOrResult);
|
|
EXPECT_TRUE(!Value);
|
|
}
|
|
}
|
|
|
|
TEST_F(RefactoringActionRulesTest, ReturnError) {
|
|
Expected<AtomicChanges> (*Func)(selection::SourceSelectionRange) =
|
|
[](selection::SourceSelectionRange) -> Expected<AtomicChanges> {
|
|
return llvm::make_error<llvm::StringError>(
|
|
"Error", std::make_error_code(std::errc::bad_message));
|
|
};
|
|
auto Rule = createRefactoringRule(
|
|
Func, requiredSelection(
|
|
selection::identity<selection::SourceSelectionRange>()));
|
|
|
|
RefactoringRuleContext RefContext(Context.Sources);
|
|
SourceLocation Cursor =
|
|
Context.Sources.getLocForStartOfFile(Context.Sources.getMainFileID());
|
|
RefContext.setSelectionRange({Cursor, Cursor});
|
|
Expected<Optional<AtomicChanges>> Result =
|
|
createReplacements(Rule, RefContext);
|
|
|
|
ASSERT_TRUE(!Result);
|
|
std::string Message;
|
|
llvm::handleAllErrors(Result.takeError(), [&](llvm::StringError &Error) {
|
|
Message = Error.getMessage();
|
|
});
|
|
EXPECT_EQ(Message, "Error");
|
|
}
|
|
|
|
TEST_F(RefactoringActionRulesTest, ReturnInitiationDiagnostic) {
|
|
RefactoringRuleContext RefContext(Context.Sources);
|
|
class SelectionRequirement : public selection::Requirement {
|
|
public:
|
|
Expected<Optional<int>>
|
|
evaluateSelection(selection::SourceSelectionRange Selection) const {
|
|
return llvm::make_error<llvm::StringError>(
|
|
"bad selection", std::make_error_code(std::errc::bad_message));
|
|
}
|
|
};
|
|
auto Rule = createRefactoringRule(
|
|
[](int) -> Expected<AtomicChanges> {
|
|
llvm::report_fatal_error("Should not run!");
|
|
},
|
|
requiredSelection(SelectionRequirement()));
|
|
|
|
SourceLocation Cursor =
|
|
Context.Sources.getLocForStartOfFile(Context.Sources.getMainFileID());
|
|
RefContext.setSelectionRange({Cursor, Cursor});
|
|
Expected<Optional<AtomicChanges>> Result =
|
|
createReplacements(Rule, RefContext);
|
|
|
|
ASSERT_TRUE(!Result);
|
|
std::string Message;
|
|
llvm::handleAllErrors(Result.takeError(), [&](llvm::StringError &Error) {
|
|
Message = Error.getMessage();
|
|
});
|
|
EXPECT_EQ(Message, "bad selection");
|
|
}
|
|
|
|
} // end anonymous namespace
|