mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-19 19:45:40 -04:00
3234887fe2
Without this patch, APSInt inherits APInt::isNegative, which merely checks the sign bit without regard to whether the type is actually signed. isNonNegative and isStrictlyPositive call isNegative and so are also affected. This patch adjusts APSInt to override isNegative, isNonNegative, and isStrictlyPositive with implementations that consider whether the type is signed. A large set of Clang OpenMP tests are affected. Without this patch, these tests assume that `true` is not a valid argument for clauses like `collapse`. Indeed, `true` fails APInt::isStrictlyPositive but not APSInt::isStrictlyPositive. This patch adjusts those tests to assume `true` should be accepted. This patch also adds tests revealing various other similar fixes due to APSInt::isNegative calls in Clang's ExprConstant.cpp and SemaExpr.cpp: `++` and `--` overflow in `constexpr`, evaluated object size based on `alloc_size`, `<<` and `>>` shift count validation, and OpenMP array section validation. Reviewed By: lebedev.ri, ABataev, hfinkel Differential Revision: https://reviews.llvm.org/D59712 llvm-svn: 359012
84 lines
2.7 KiB
C
84 lines
2.7 KiB
C
// RUN: %clang_cc1 -Wall -Wshift-sign-overflow -ffreestanding -fsyntax-only -verify %s
|
|
|
|
#include <limits.h>
|
|
|
|
#define WORD_BIT (sizeof(int) * CHAR_BIT)
|
|
|
|
enum {
|
|
X = 1 << 0,
|
|
Y = 1 << 1,
|
|
Z = 1 << 2
|
|
};
|
|
|
|
void test() {
|
|
char c;
|
|
|
|
c = 0 << 0;
|
|
c = 0 << 1;
|
|
c = 1 << 0;
|
|
c = 1 << -0;
|
|
c = 1 >> -0;
|
|
c = 1 << -1; // expected-warning {{shift count is negative}}
|
|
c = 1 >> -1; // expected-warning {{shift count is negative}}
|
|
c = 1 << (unsigned)-1; // expected-warning {{shift count >= width of type}}
|
|
// expected-warning@-1 {{implicit conversion}}
|
|
c = 1 >> (unsigned)-1; // expected-warning {{shift count >= width of type}}
|
|
c = 1 << c;
|
|
c <<= 0;
|
|
c >>= 0;
|
|
c <<= 1;
|
|
c >>= 1;
|
|
c <<= -1; // expected-warning {{shift count is negative}}
|
|
c >>= -1; // expected-warning {{shift count is negative}}
|
|
c <<= 999999; // expected-warning {{shift count >= width of type}}
|
|
c >>= 999999; // expected-warning {{shift count >= width of type}}
|
|
c <<= CHAR_BIT; // expected-warning {{shift count >= width of type}}
|
|
c >>= CHAR_BIT; // expected-warning {{shift count >= width of type}}
|
|
c <<= CHAR_BIT+1; // expected-warning {{shift count >= width of type}}
|
|
c >>= CHAR_BIT+1; // expected-warning {{shift count >= width of type}}
|
|
(void)((long)c << CHAR_BIT);
|
|
|
|
int i;
|
|
i = 1 << (WORD_BIT - 2);
|
|
i = 2 << (WORD_BIT - 1); // expected-warning {{bits to represent, but 'int' only has}}
|
|
i = 1 << (WORD_BIT - 1); // expected-warning {{sets the sign bit of the shift expression}}
|
|
i = -1 << (WORD_BIT - 1); // expected-warning {{shifting a negative signed value is undefined}}
|
|
i = -1 << 0; // expected-warning {{shifting a negative signed value is undefined}}
|
|
i = 0 << (WORD_BIT - 1);
|
|
i = (char)1 << (WORD_BIT - 2);
|
|
|
|
unsigned u;
|
|
u = 1U << (WORD_BIT - 1);
|
|
u = 5U << (WORD_BIT - 1);
|
|
|
|
long long int lli;
|
|
lli = INT_MIN << 2; // expected-warning {{shifting a negative signed value is undefined}}
|
|
lli = 1LL << (sizeof(long long) * CHAR_BIT - 2);
|
|
}
|
|
|
|
#define a 0
|
|
#define ashift 8
|
|
enum { b = (a << ashift) };
|
|
|
|
// Don't warn for negative shifts in code that is unreachable.
|
|
void test_pr5544() {
|
|
(void) (((1) > 63 && (1) < 128 ? (((unsigned long long) 1)<<((1)-64)) : (unsigned long long) 0)); // no-warning
|
|
}
|
|
|
|
void test_shift_too_much(char x) {
|
|
if (0)
|
|
(void) (x >> 80); // no-warning
|
|
(void) (x >> 80); // expected-warning {{shift count >= width of type}}
|
|
}
|
|
|
|
typedef unsigned vec16 __attribute__((vector_size(16)));
|
|
typedef unsigned vec8 __attribute__((vector_size(8)));
|
|
|
|
void vect_shift_1(vec16 *x) { *x = *x << 4; }
|
|
|
|
void vect_shift_2(vec16 *x, vec16 y) { *x = *x << y; }
|
|
|
|
void vect_shift_3(vec16 *x, vec8 y) {
|
|
*x = *x << y; // expected-error {{vector operands do not have the same number of elements}}
|
|
}
|