mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-19 19:45:40 -04:00

The bitstream reader handles errors poorly. This has two effects: * Bugs in file handling (especially modules) manifest as an "unexpected end of file" crash * Users of clang as a library end up aborting because the code unconditionally calls `report_fatal_error` The bitstream reader should be more resilient and return Expected / Error as soon as an error is encountered, not way late like it does now. This patch starts doing so and adopting the error handling where I think it makes sense. There's plenty more to do: this patch propagates errors to be minimally useful, and follow-ups will propagate them further and improve diagnostics. https://bugs.llvm.org/show_bug.cgi?id=42311 <rdar://problem/33159405> Differential Revision: https://reviews.llvm.org/D63518 llvm-svn: 364464
36 lines
1.6 KiB
C
36 lines
1.6 KiB
C
// Check that clang can use a PCH created from libclang.
|
|
|
|
// This test doesn't use -fdisable-module-hash and hence requires that
|
|
// CompilerInvocation::getModuleHash() computes exactly the same hash
|
|
// for c-index-test and clang, which in turn requires that the both use
|
|
// exactly the same resource-dir, even without calling realpath() on it:
|
|
// - a/../b/ and b/ are not considered the same
|
|
// - on Windows, c:\ and C:\ (only different in case) are not the same
|
|
|
|
// RUN: rm -rf %t.mcp %t.h.pch
|
|
// RUN: %clang_cc1 -fsyntax-only %s -verify
|
|
// RUN: c-index-test -write-pch %t.h.pch %s -fmodules -fmodules-cache-path=%t.mcp -Xclang -triple -Xclang x86_64-apple-darwin
|
|
// RUN: %clang -fsyntax-only -include %t.h %s -Xclang -verify -fmodules -fmodules-cache-path=%t.mcp -Xclang -detailed-preprocessing-record -Xclang -triple -Xclang x86_64-apple-darwin -Xclang -fallow-pch-with-compiler-errors
|
|
// RUN: %clang -x c-header %s -o %t.clang.h.pch -fmodules -fmodules-cache-path=%t.mcp -Xclang -detailed-preprocessing-record -Xclang -triple -Xclang x86_64-apple-darwin -Xclang -fallow-pch-with-compiler-errors -Xclang -verify
|
|
// RUN: c-index-test -test-load-source local %s -include %t.clang.h -fmodules -fmodules-cache-path=%t.mcp -Xclang -triple -Xclang x86_64-apple-darwin | FileCheck %s
|
|
|
|
// FIXME: Still fails on at least some linux boxen.
|
|
// REQUIRES: system-darwin
|
|
|
|
#ifndef HEADER
|
|
#define HEADER
|
|
|
|
void some_function(undeclared_type p); // expected-error{{unknown type name}}
|
|
|
|
struct S { int x; };
|
|
|
|
#else
|
|
// expected-no-diagnostics
|
|
|
|
void test(struct S *s) {
|
|
// CHECK: [[@LINE+1]]:6: MemberRefExpr=x:[[@LINE-6]]:16
|
|
s->x = 0;
|
|
}
|
|
|
|
#endif
|