mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-19 11:35:51 -04:00
a6e8d5e554
expression is a discarded-value expression.
Summary:
We used to get this wrong in three ways:
1) During parsing, an expression-statement followed by the }) ending a
statement expression was always treated as producing the value of the
statement expression. That's wrong for ({ if (1) expr; })
2) During template instantiation, various kinds of statement (most
statements not appearing directly in a compound-statement) were not
treated as discarded-value expressions, resulting in missing volatile
loads (etc).
3) In all contexts, an expression-statement with attributes was not
treated as producing the value of the statement expression, eg
({ [[attr]] expr; }).
Also fix incorrect enforcement of OpenMP rule that directives can "only
be placed in the program at a position where ignoring or deleting the
directive would result in a program with correct syntax". In particular,
a label (be it goto, case, or default) should not affect whether
directives are permitted.
Reviewers: aaron.ballman, rjmccall
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D57984
llvm-svn: 354090
52 lines
1.6 KiB
C++
52 lines
1.6 KiB
C++
// RUN: %clang_cc1 %s -triple=x86_64-apple-darwin10 -emit-llvm -std=c++98 -o - | FileCheck -check-prefix=CHECK -check-prefix=CHECK98 %s
|
|
// RUN: %clang_cc1 %s -triple=x86_64-apple-darwin10 -emit-llvm -std=c++11 -o - | FileCheck -check-prefix=CHECK -check-prefix=CHECK11 %s
|
|
|
|
// Check that IR gen doesn't try to do an lvalue-to-rvalue conversion
|
|
// on a volatile reference result. rdar://problem/8338198
|
|
namespace test0 {
|
|
struct A {
|
|
A(const A& t);
|
|
A& operator=(const A& t);
|
|
volatile A& operator=(const volatile A& t) volatile;
|
|
};
|
|
|
|
volatile A *array;
|
|
|
|
// CHECK-LABEL: define void @_ZN5test04testENS_1AE(
|
|
void test(A t) {
|
|
// CHECK: [[ARR:%.*]] = load [[A:%.*]]*, [[A:%.*]]** @_ZN5test05arrayE, align 8
|
|
// CHECK-NEXT: [[IDX:%.*]] = getelementptr inbounds [[A]], [[A]]* [[ARR]], i64 0
|
|
// CHECK-NEXT: [[TMP:%.*]] = call dereferenceable({{[0-9]+}}) [[A]]* @_ZNV5test01AaSERVKS0_([[A]]* [[IDX]], [[A]]* dereferenceable({{[0-9]+}}) [[T:%.*]])
|
|
// CHECK-NEXT: ret void
|
|
array[0] = t;
|
|
}
|
|
}
|
|
|
|
namespace test1 {
|
|
volatile int *x;
|
|
|
|
// CHECK-LABEL: define void @_ZN5test14testEv()
|
|
void test() {
|
|
// CHECK: [[TMP:%.*]] = load i32*, i32** @_ZN5test11xE, align 8
|
|
// CHECK11-NEXT: {{%.*}} = load volatile i32, i32* [[TMP]], align 4
|
|
// CHECK-NEXT: ret void
|
|
*x;
|
|
}
|
|
}
|
|
|
|
namespace PR40642 {
|
|
template <class T> struct S {
|
|
// CHECK-LABEL: define {{.*}} @_ZN7PR406421SIiE3fooEv(
|
|
void foo() {
|
|
// CHECK98-NOT: load volatile
|
|
// CHECK11: load volatile
|
|
if (true)
|
|
reinterpret_cast<const volatile unsigned char *>(m_ptr)[0];
|
|
// CHECK: }
|
|
}
|
|
int *m_ptr;
|
|
};
|
|
|
|
void f(S<int> *x) { x->foo(); }
|
|
}
|