mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-19 11:35:51 -04:00
a19c985f8a
Since rL335814, if the constraint manager cannot find a range set for `A - B` (where `A` and `B` are symbols) it looks for a range for `B - A` and returns it negated if it exists. However, if a range set for both `A - B` and `B - A` is stored then it only returns the first one. If we both use `A - B` and `B - A`, these expressions behave as two totally unrelated symbols. This way we miss some useful deductions which may lead to false negatives or false positives. This tiny patch changes this behavior: if the symbolic expression the constraint manager is looking for is a difference `A - B`, it tries to retrieve the range for both `A - B` and `B - A` and if both exists it returns the intersection of range `A - B` and the negated range of `B - A`. This way every time a checker applies new constraints to the symbolic difference or to its negated it always affects both the original difference and its negated. Differential Revision: https://reviews.llvm.org/D55007 llvm-svn: 357167
113 lines
2.9 KiB
C
113 lines
2.9 KiB
C
// RUN: %clang_analyze_cc1 -analyzer-checker=debug.ExprInspection,core.builtin -analyzer-config aggressive-binary-operation-simplification=true -verify %s
|
|
|
|
void clang_analyzer_eval(int);
|
|
|
|
void exit(int);
|
|
|
|
#define UINT_MAX (~0U)
|
|
#define INT_MAX (UINT_MAX & (UINT_MAX >> 1))
|
|
#define INT_MIN (UINT_MAX & ~(UINT_MAX >> 1))
|
|
|
|
extern void __assert_fail (__const char *__assertion, __const char *__file,
|
|
unsigned int __line, __const char *__function)
|
|
__attribute__ ((__noreturn__));
|
|
#define assert(expr) \
|
|
((expr) ? (void)(0) : __assert_fail (#expr, __FILE__, __LINE__, __func__))
|
|
|
|
void assert_in_range(int x) {
|
|
assert(x <= ((int)INT_MAX / 4));
|
|
assert(x >= -(((int)INT_MAX) / 4));
|
|
}
|
|
|
|
void assert_in_wide_range(int x) {
|
|
assert(x <= ((int)INT_MAX / 2));
|
|
assert(x >= -(((int)INT_MAX) / 2));
|
|
}
|
|
|
|
void assert_in_range_2(int m, int n) {
|
|
assert_in_range(m);
|
|
assert_in_range(n);
|
|
}
|
|
|
|
void equal(int m, int n) {
|
|
assert_in_range_2(m, n);
|
|
if (m != n)
|
|
return;
|
|
assert_in_wide_range(m - n);
|
|
clang_analyzer_eval(n == m); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
void non_equal(int m, int n) {
|
|
assert_in_range_2(m, n);
|
|
if (m == n)
|
|
return;
|
|
assert_in_wide_range(m - n);
|
|
clang_analyzer_eval(n != m); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
void less_or_equal(int m, int n) {
|
|
assert_in_range_2(m, n);
|
|
if (m < n)
|
|
return;
|
|
assert_in_wide_range(m - n);
|
|
clang_analyzer_eval(n <= m); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
void less(int m, int n) {
|
|
assert_in_range_2(m, n);
|
|
if (m <= n)
|
|
return;
|
|
assert_in_wide_range(m - n);
|
|
clang_analyzer_eval(n < m); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
void greater_or_equal(int m, int n) {
|
|
assert_in_range_2(m, n);
|
|
if (m > n)
|
|
return;
|
|
assert_in_wide_range(m - n);
|
|
clang_analyzer_eval(n >= m); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
void greater(int m, int n) {
|
|
assert_in_range_2(m, n);
|
|
if (m >= n)
|
|
return;
|
|
assert_in_wide_range(m - n);
|
|
clang_analyzer_eval(n > m); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
void negate_positive_range(int m, int n) {
|
|
if (m - n <= 0)
|
|
return;
|
|
clang_analyzer_eval(n - m < 0); // expected-warning{{TRUE}}
|
|
clang_analyzer_eval(n - m > INT_MIN); // expected-warning{{TRUE}}
|
|
clang_analyzer_eval(n - m == INT_MIN); // expected-warning{{FALSE}}
|
|
}
|
|
|
|
void negate_int_min(int m, int n) {
|
|
if (m - n != INT_MIN)
|
|
return;
|
|
clang_analyzer_eval(n - m == INT_MIN); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
void negate_mixed(int m, int n) {
|
|
if (m -n > INT_MIN && m - n <= 0)
|
|
return;
|
|
clang_analyzer_eval(n - m <= 0); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
void effective_range(int m, int n) {
|
|
assert(m - n >= 0);
|
|
assert(n - m >= 0);
|
|
clang_analyzer_eval(m - n == 0); // expected-warning{{TRUE}}
|
|
clang_analyzer_eval(n - m == 0); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
void effective_range_2(int m, int n) {
|
|
assert(m - n <= 0);
|
|
assert(n - m <= 0);
|
|
clang_analyzer_eval(m - n == 0); // expected-warning{{TRUE}} expected-warning{{FALSE}}
|
|
clang_analyzer_eval(n - m == 0); // expected-warning{{TRUE}} expected-warning{{FALSE}}
|
|
}
|