mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-19 03:25:54 -04:00
cbbf92825f
Summary: Finds OpenMP directives that are allowed to contain `default` clause, but either don't specify it, or the clause is specified but with the kind other than `none`, and suggests to use `default(none)` clause. Using `default(none)` clause changes the default variable visibility from being implicitly determined, and thus forces developer to be explicit about the desired data scoping for each variable. Reviewers: JonasToth, aaron.ballman, xazax.hun, hokein, gribozavr Reviewed By: JonasToth, aaron.ballman Subscribers: jdoerfert, openmp-commits, klimek, sbenza, arphaman, Eugene.Zelenko, ABataev, mgorny, rnkovacs, guansong, cfe-commits Tags: #clang-tools-extra, #openmp, #clang Differential Revision: https://reviews.llvm.org/D57113 llvm-svn: 356801
66 lines
2.4 KiB
C++
66 lines
2.4 KiB
C++
//===--- UseDefaultNoneCheck.cpp - clang-tidy -----------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "UseDefaultNoneCheck.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/AST/OpenMPClause.h"
|
|
#include "clang/AST/Stmt.h"
|
|
#include "clang/AST/StmtOpenMP.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
#include "clang/ASTMatchers/ASTMatchers.h"
|
|
#include "clang/ASTMatchers/ASTMatchersMacros.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
namespace openmp {
|
|
|
|
void UseDefaultNoneCheck::registerMatchers(MatchFinder *Finder) {
|
|
// Don't register the check if OpenMP is not enabled; the OpenMP pragmas are
|
|
// completely ignored then, so no OpenMP entires will be present in the AST.
|
|
if (!getLangOpts().OpenMP)
|
|
return;
|
|
|
|
Finder->addMatcher(
|
|
ompExecutableDirective(
|
|
allOf(isAllowedToContainClauseKind(OMPC_default),
|
|
anyOf(unless(hasAnyClause(ompDefaultClause())),
|
|
hasAnyClause(ompDefaultClause(unless(isNoneKind()))
|
|
.bind("clause")))))
|
|
.bind("directive"),
|
|
this);
|
|
}
|
|
|
|
void UseDefaultNoneCheck::check(const MatchFinder::MatchResult &Result) {
|
|
const auto *Directive =
|
|
Result.Nodes.getNodeAs<OMPExecutableDirective>("directive");
|
|
assert(Directive != nullptr && "Expected to match some directive.");
|
|
|
|
if (const auto *Clause = Result.Nodes.getNodeAs<OMPDefaultClause>("clause")) {
|
|
diag(Directive->getBeginLoc(),
|
|
"OpenMP directive '%0' specifies 'default(%1)' clause, consider using "
|
|
"'default(none)' clause instead")
|
|
<< getOpenMPDirectiveName(Directive->getDirectiveKind())
|
|
<< getOpenMPSimpleClauseTypeName(Clause->getClauseKind(),
|
|
Clause->getDefaultKind());
|
|
diag(Clause->getBeginLoc(), "existing 'default' clause specified here",
|
|
DiagnosticIDs::Note);
|
|
return;
|
|
}
|
|
|
|
diag(Directive->getBeginLoc(),
|
|
"OpenMP directive '%0' does not specify 'default' clause, consider "
|
|
"specifying 'default(none)' clause")
|
|
<< getOpenMPDirectiveName(Directive->getDirectiveKind());
|
|
}
|
|
|
|
} // namespace openmp
|
|
} // namespace tidy
|
|
} // namespace clang
|