mirror of
https://github.com/Gericom/teak-llvm.git
synced 2025-06-19 03:25:54 -04:00
2946cd7010
to reflect the new license. We understand that people may be surprised that we're moving the header entirely to discuss the new license. We checked this carefully with the Foundation's lawyer and we believe this is the correct approach. Essentially, all code in the project is now made available by the LLVM project under our new license, so you will see that the license headers include that license only. Some of our contributors have contributed code under our old license, and accordingly, we have retained a copy of our old license notice in the top-level files in each project and repository. llvm-svn: 351636
83 lines
2.7 KiB
C++
83 lines
2.7 KiB
C++
//===--- ProBoundsArrayToPointerDecayCheck.cpp - clang-tidy----------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "ProBoundsArrayToPointerDecayCheck.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
namespace cppcoreguidelines {
|
|
|
|
namespace {
|
|
AST_MATCHER_P(CXXForRangeStmt, hasRangeBeginEndStmt,
|
|
ast_matchers::internal::Matcher<DeclStmt>, InnerMatcher) {
|
|
for (const DeclStmt *Stmt : {Node.getBeginStmt(), Node.getEndStmt()})
|
|
if (Stmt != nullptr && InnerMatcher.matches(*Stmt, Finder, Builder))
|
|
return true;
|
|
return false;
|
|
}
|
|
|
|
AST_MATCHER(Stmt, isInsideOfRangeBeginEndStmt) {
|
|
return stmt(hasAncestor(cxxForRangeStmt(
|
|
hasRangeBeginEndStmt(hasDescendant(equalsNode(&Node))))))
|
|
.matches(Node, Finder, Builder);
|
|
}
|
|
|
|
AST_MATCHER_P(Expr, hasParentIgnoringImpCasts,
|
|
ast_matchers::internal::Matcher<Expr>, InnerMatcher) {
|
|
const Expr *E = &Node;
|
|
do {
|
|
ASTContext::DynTypedNodeList Parents =
|
|
Finder->getASTContext().getParents(*E);
|
|
if (Parents.size() != 1)
|
|
return false;
|
|
E = Parents[0].get<Expr>();
|
|
if (!E)
|
|
return false;
|
|
} while (isa<ImplicitCastExpr>(E));
|
|
|
|
return InnerMatcher.matches(*E, Finder, Builder);
|
|
}
|
|
} // namespace
|
|
|
|
void ProBoundsArrayToPointerDecayCheck::registerMatchers(MatchFinder *Finder) {
|
|
if (!getLangOpts().CPlusPlus)
|
|
return;
|
|
|
|
// The only allowed array to pointer decay
|
|
// 1) just before array subscription
|
|
// 2) inside a range-for over an array
|
|
// 3) if it converts a string literal to a pointer
|
|
Finder->addMatcher(
|
|
implicitCastExpr(
|
|
unless(hasParent(arraySubscriptExpr())),
|
|
unless(hasParentIgnoringImpCasts(explicitCastExpr())),
|
|
unless(isInsideOfRangeBeginEndStmt()),
|
|
unless(hasSourceExpression(ignoringParens(stringLiteral()))))
|
|
.bind("cast"),
|
|
this);
|
|
}
|
|
|
|
void ProBoundsArrayToPointerDecayCheck::check(
|
|
const MatchFinder::MatchResult &Result) {
|
|
const auto *MatchedCast = Result.Nodes.getNodeAs<ImplicitCastExpr>("cast");
|
|
if (MatchedCast->getCastKind() != CK_ArrayToPointerDecay)
|
|
return;
|
|
|
|
diag(MatchedCast->getExprLoc(), "do not implicitly decay an array into a "
|
|
"pointer; consider using gsl::array_view or "
|
|
"an explicit cast instead");
|
|
}
|
|
|
|
} // namespace cppcoreguidelines
|
|
} // namespace tidy
|
|
} // namespace clang
|