Gericom/teak-llvm
1
Fork 0
mirror of https://github.com/Gericom/teak-llvm.git synced 2025-06-28 15:58:57 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity
98,593 Commits 1 Branch 0 Tags 875 MiB
f96ae684c4
Commit Graph

163 Commits

Author SHA1 Message Date
Frits van Bommel
9bbe849fc3 Fix a bug in the loop in JumpThreading::ProcessThreadableEdges() where it could falsely produce a MultipleDestSentinel value if the first predecessor ended with an 'indirectbr'. If that happened, it caused an unnecessary FindMostPopularDest() call. 
This wasn't a correctness problem, but it broke the fast path for single-predecessor blocks.

llvm-svn: 121966
 2010-12-16 12:16:00 +00:00
Frits van Bommel
3d1803495e Teach jump threading to "look through" a select when the branch direction of a terminator depends on it. 
When it sees a promising select it now tries to figure out whether the condition of the select is known in any of the predecessors and if so it maps the operands appropriately.

llvm-svn: 121859
 2010-12-15 09:51:20 +00:00
Chris Lattner
73a58627c3 simplify code and reduce indentation 
llvm-svn: 121670
 2010-12-13 02:38:13 +00:00
Frits van Bommel
d2f4b09e10 Remove some dead code from the jump threading pass. 
The last uses of these functions were removed in r113852 when LazyValueInfo was permanently enabled and removed the need for them.

llvm-svn: 121133
 2010-12-07 13:08:07 +00:00
Frits van Bommel
d9df6eaa9c Implement jump threading of 'indirectbr' by keeping track of whether we're looking for ConstantInt*s or BlockAddress*s. 
llvm-svn: 121066
 2010-12-06 23:36:56 +00:00
Frits van Bommel
76244867cf Refactor jump threading. 
Should have no functional change other than the order of two transformations that are mutually-exclusive and the exact formatting of debug output.
Internally, it now stores the ConstantInt*s as Constant*s, and actual undef values instead of nulls.

llvm-svn: 120946
 2010-12-05 19:06:41 +00:00
Frits van Bommel
5e75ef4a8e Remove trailing whitespace. 
llvm-svn: 120945
 2010-12-05 19:02:47 +00:00
Owen Anderson
6c18d1aac0 Get rid of static constructors for pass registration. Instead, every pass exposes an initializeMyPassFunction(), which 
must be called in the pass's constructor.  This function uses static dependency declarations to recursively initialize
the pass's dependencies.

Clients that only create passes through the createFooPass() APIs will require no changes.  Clients that want to use the
CommandLine options for passes will need to manually call the appropriate initialization functions in PassInitialization.h
before parsing commandline arguments.

I have tested this with all standard configurations of clang and llvm-gcc on Darwin.  It is possible that there are problems
with the static dependencies that will only be visible with non-standard options.  If you encounter any crash in pass
registration/creation, please send the testcase to me directly.

llvm-svn: 116820
 2010-10-19 17:21:58 +00:00
Owen Anderson
8ac477ffb5 Begin adding static dependence information to passes, which will allow us to 
perform initialization without static constructors AND without explicit initialization
by the client.  For the moment, passes are required to initialize both their
(potential) dependencies and any passes they preserve.  I hope to be able to relax
the latter requirement in the future.

llvm-svn: 116334
 2010-10-12 19:48:12 +00:00
Owen Anderson
df7a4f2515 Now with fewer extraneous semicolons! 
llvm-svn: 115996
 2010-10-07 22:25:06 +00:00
Owen Anderson
99c985c37d Fix PR8247: JumpThreading can cause a block to become unreachable while still having predecessor, if it is part of a self-loop. 
Because of this, we cannot use the Simplify* APIs, as they can assert-fail on unreachable code.  Since it's not easy to determine
if a given threading will cause a block to become unreachable, simply defer simplifying simplification to later InstCombine and/or
DCE passes.

llvm-svn: 115082
 2010-09-29 20:34:41 +00:00
Owen Anderson
d361aac3d0 Remove the option to disable LazyValueInfo in JumpThreading, as it is now 
on by default and has received significant testing.

llvm-svn: 113852
 2010-09-14 20:57:41 +00:00
Chris Lattner
e6214557e7 Change lower atomic pass to use IntrinsicInst to simplify it a bit. 
llvm-svn: 113114
 2010-09-05 20:10:47 +00:00
Chris Lattner
05ef361b5e eliminate some non-obvious casts. UndefValue isa Constant. 
llvm-svn: 113113
 2010-09-05 20:03:09 +00:00
Duncan Sands
6778149f7e Reapply commit 112699, speculatively reverted by echristo, since 
I'm sure it is harmless.  Original commit message:
If PrototypeValue is erased in the middle of using the SSAUpdator
then the SSAUpdator may access freed memory.  Instead, simply pass
in the type and name explicitly, which is all that was used anyway.

llvm-svn: 112810
 2010-09-02 08:14:03 +00:00
Owen Anderson
73f988cafa JumpThreading keeps LazyValueInfo up to date, so we don't need to rerun it 
if we schedule another LVI-using pass afterwards.

llvm-svn: 112722
 2010-09-01 18:27:22 +00:00
Eric Christopher
a5d315c665 Speculatively revert 112699 and 112702, they seem to be causing 
self host errors on clang-x86-64.

llvm-svn: 112719
 2010-09-01 17:29:10 +00:00
Duncan Sands
f7b18437b5 If PrototypeValue is erased in the middle of using the SSAUpdator 
then the SSAUpdator may access freed memory.  Instead, simply pass
in the type and name explicitly, which is all that was used anyway.

llvm-svn: 112699
 2010-09-01 10:29:33 +00:00
Owen Anderson
3c84ecb067 More cleanups of my JumpThreading transforms, including extracting some duplicated code into a helper function. 
llvm-svn: 112634
 2010-08-31 20:26:04 +00:00
Owen Anderson
6fdcb172a9 Add an RAII helper to make cleanup of the RecursionSet more fool-proof. 
llvm-svn: 112628
 2010-08-31 19:24:27 +00:00
Owen Anderson
cd4de7f399 Refactor my fix for PR5652 to terminate the predecessor lookups after the first failure. 
llvm-svn: 112620
 2010-08-31 18:48:48 +00:00
Owen Anderson
3997a07fb9 More Chris-inspired JumpThreading fixes: use ConstantExpr to correctly constant-fold undef, and be more careful with its return value. 
This actually exposed an infinite recursion bug in ComputeValueKnownInPredecessors which theoretically already existed (in JumpThreading's
handling of and/or of i1's), but never manifested before.  This patch adds a tracking set to prevent this case.

llvm-svn: 112589
 2010-08-31 07:36:34 +00:00
Owen Anderson
c910acb54a Re-apply r112539, being more careful to respect the return values of the constant folding methods. Additionally, 
use the ConstantExpr::get*() methods to simplify some constant folding.

llvm-svn: 112550
 2010-08-30 23:22:36 +00:00
Owen Anderson
1ddcbbe49c Revert r112539. It accidentally introduced a miscompilation. 
llvm-svn: 112543
 2010-08-30 22:33:41 +00:00
Owen Anderson
75f6037c7c Fixes and cleanups pointed out by Chris. In general, be careful to handle 0 results from ComputeValueKnownInPredecessors 
(indicating undef), and re-use existing constant folding APIs.

llvm-svn: 112539
 2010-08-30 22:07:52 +00:00
Owen Anderson
99d4cb861b Fix typos in comments. 
llvm-svn: 112286
 2010-08-27 20:32:56 +00:00
Owen Anderson
6ebbd92380 Use LVI to eliminate conditional branches where we've tested a related condition previously. Update tests for this change. 
This fixes PR5652.

llvm-svn: 112270
 2010-08-27 17:12:29 +00:00
Owen Anderson
bd2ecc7e68 Make JumpThreading smart enough to properly thread StrSwitch when it's compiled with clang++. 
llvm-svn: 112198
 2010-08-26 17:40:24 +00:00
Owen Anderson
7c853e877e Turn LVI on, previously detected failures should be fixed now. 
llvm-svn: 111923
 2010-08-24 17:21:18 +00:00
Owen Anderson
6ffa3f2aea Turn LVI back off, I have a testcase now. 
llvm-svn: 111834
 2010-08-23 19:59:27 +00:00
Owen Anderson
630add39a6 Re-enable LazyValueInfo. Monitoring for failures. 
llvm-svn: 111816
 2010-08-23 18:12:23 +00:00
Owen Anderson
aac8cbb261 Disable LVI while I evaluate a failure. 
llvm-svn: 111551
 2010-08-19 19:47:08 +00:00
Owen Anderson
5c87dd55d3 Tentatively enabled LVI by default. I'll be monitoring for any failures. 
llvm-svn: 111543
 2010-08-19 19:04:40 +00:00
Owen Anderson
208636fa33 Inform LazyValueInfo whenever a block is deleted, to avoid dangling pointer issues. 
llvm-svn: 111382
 2010-08-18 18:39:01 +00:00
Chris Lattner
3c603024bb Fix PR7755: knowing something about an inval for a pred 
from the LHS should disable reconsidering that pred on the
RHS.  However, knowing something about the pred on the RHS
shouldn't disable subsequent additions on the RHS from
happening.

llvm-svn: 111349
 2010-08-18 03:14:36 +00:00
Owen Anderson
a7aed18624 Reapply r110396, with fixes to appease the Linux buildbot gods. 
llvm-svn: 110460
 2010-08-06 18:33:48 +00:00
Owen Anderson
bda59bd247 Revert r110396 to fix buildbots. 
llvm-svn: 110410
 2010-08-06 00:23:35 +00:00
Owen Anderson
755aceb5d0 Don't use PassInfo* as a type identifier for passes. Instead, use the address of the static 
ID member as the sole unique type identifier.  Clean up APIs related to this change.

llvm-svn: 110396
 2010-08-05 23:42:04 +00:00
Owen Anderson
4674dd6cf5 Give JumpThreading+LVI a long-form cl::opt so that it's easier to toggle the default. 
llvm-svn: 110384
 2010-08-05 22:11:31 +00:00
Owen Anderson
aa7f66ba67 Add an initial implementation of LazyValueInfo updating for JumpThreading. Disabled for now. 
llvm-svn: 109424
 2010-07-26 18:48:03 +00:00
Owen Anderson
a57b97e7e7 Fix batch of converting RegisterPass<> to INTIALIZE_PASS(). 
llvm-svn: 109045
 2010-07-21 22:09:45 +00:00
Gabor Greif
a5fa885d47 cache results of operator* 
llvm-svn: 108142
 2010-07-12 14:10:24 +00:00
Chris Lattner
bbc25ff5cc if jump threading is able to infer interesting values on both 
the LHS and RHS of an and/or instruction, don't multiply add
known predecessor values.  This fixes the crash on testcase
from PR7498

llvm-svn: 108114
 2010-07-12 00:47:34 +00:00
Chris Lattner
329ea064ed jump threading can't split a critical edge from an indirectbr. This 
fixes PR7356.

llvm-svn: 105950
 2010-06-14 19:45:43 +00:00
Dan Gohman
826bdf8c10 Move FindAvailableLoadedValue isSafeToLoadUnconditionally out of 
lib/Transforms/Utils and into lib/Analysis so that Analysis passes
can use them.

llvm-svn: 104949
 2010-05-28 16:19:17 +00:00
Chris Lattner
9ae28b141f fix PR6743, a case where we'd delete an instruction before using it 
in some cases.

llvm-svn: 100937
 2010-04-10 18:26:57 +00:00
Duncan Sands
19d0b47b1f There are two ways of checking for a given type, for example isa<PointerType>(T) 
and T->isPointerTy().  Convert most instances of the first form to the second form.
Requested by Chris.

llvm-svn: 96344
 2010-02-16 11:11:14 +00:00
Duncan Sands
9dff9bec31 Uniformize the names of type predicates: rather than having isFloatTy and 
isInteger, we now have isFloatTy and isIntegerTy.  Requested by Chris!

llvm-svn: 96223
 2010-02-15 16:12:20 +00:00
Chris Lattner
d924f63692 Make jump threading honor x|undef -> true and x&undef -> false, 
instead of considering x|undef -> x, which may not be true.

llvm-svn: 95850
 2010-02-11 04:40:44 +00:00
Chris Lattner
29b15c5cfd third bug from PR6119: the xor dupe extension allows 
for arbitrary terminators in predecessors, don't assume
it is a conditional or uncond branch.  The testcase shows
an example where they can happen with switches.

llvm-svn: 94323
 2010-01-23 19:21:31 +00:00