Gericom/teak-llvm
1
Fork 0
mirror of https://github.com/Gericom/teak-llvm.git synced 2025-06-23 13:35:42 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity
306,812 Commits 1 Branch 0 Tags 875 MiB
81fe1fbf4a
Commit Graph

408 Commits

Author SHA1 Message Date
Eli Friedman
9ee2d04753 Make -mms-bitfields behave consistently. 
Patch by Jeremiah Zanin.

llvm-svn: 165849
 2012-10-12 23:29:20 +00:00
Dmitri Gribenko
a664e5b88f Use LLVM_DELETED_FUNCTION in place of 'DO NOT IMPLEMENT' comments. 
llvm-svn: 163983
 2012-09-15 20:20:27 +00:00
Roman Divacky
e637711ae0 Dont cast away const needlessly. Found by gcc48 -Wcast-qual. 
llvm-svn: 163325
 2012-09-06 15:59:27 +00:00
Benjamin Kramer
648e68b809 Remove windows line endings. 
While there fix a dead assert.

llvm-svn: 163031
 2012-08-31 22:14:25 +00:00
Joao Matos
dc86f94f62 Improved MSVC __interface support by adding first class support for it, instead of aliasing to "struct" which had some incorrect behaviour. Patch by David Robins. 
llvm-svn: 163013
 2012-08-31 18:45:21 +00:00
Benjamin Kramer
4a9020839c Flesh out test for defaulted key functions a bit more. 
llvm-svn: 161243
 2012-08-03 15:43:22 +00:00
Benjamin Kramer
73d1be7c56 Fix failed to generate vtables in certain cases. 
By C++ standard, the vtable should be generated if the first non-inline
virtual function is defined in the TU.  Current version of clang doesn't
generate vtable if the first virtual function is defaulted, because the
key function is regarded as the defaulted function.

Patch by Li Kan!

llvm-svn: 161236
 2012-08-03 08:39:58 +00:00
Benjamin Kramer
2ef3031496 Remove get(V)BaseClassOffsetInBits, the CharUnit functions should be used instead. 
No functionality change.

llvm-svn: 159719
 2012-07-04 18:45:14 +00:00
David Blaikie
40ed29730b Revert Decl's iterators back to pointer value_type rather than reference value_type 
In addition, I've made the pointer and reference typedef 'void' rather than T*
just so they can't get misused. I would've omitted them entirely but
std::distance likes them to be there even if it doesn't use them.

This rolls back r155808 and r155869.

Review by Doug Gregor incorporating feedback from Chandler Carruth.

llvm-svn: 158104
 2012-06-06 20:45:41 +00:00
John McCall
e42a336604 Add support for laying out vtordisps according to our current 
working knowledge of the Microsoft ABI.  Based on a patch by
Dmitry Sokolov.

llvm-svn: 155905
 2012-05-01 08:55:32 +00:00
David Blaikie
2d7c57ec1d Remove the ref/value inconsistency in filter_decl_iterator. 
filter_decl_iterator had a weird mismatch where both op* and op-> returned T*
making it difficult to generalize this filtering behavior into a reusable
library of any kind.

This change errs on the side of value, making op-> return T* and op* return
T&.

(reviewed by Richard Smith)

llvm-svn: 155808
 2012-04-30 02:36:29 +00:00
Sean Callanan
d9a909cd29 When laying out an Objective-C object, consult 
the external source to complete the Decl if it
hasn't been completed already.

This fixes a crash in LLDB.

llvm-svn: 152807
 2012-03-15 16:33:08 +00:00
David Blaikie
bbafb8a745 Unify naming of LangOptions variable/get function across the Clang stack (Lex to AST). 
The member variable is always "LangOpts" and the member function is always "getLangOpts".

Reviewed by Chris Lattner

llvm-svn: 152536
 2012-03-11 07:00:24 +00:00
Sean Callanan
56c198962c If a struct needs to be laid out, and it has not 
been completed yet, then complete it if possible.
This fixes some assertion failures encountered by
LLDB.

llvm-svn: 150020
 2012-02-08 00:04:52 +00:00
Douglas Gregor
44ba7899c4 Allow the external AST source to provide a layout without specifying 
the alignment (because it's not encoded in DWARF). In this case, make
an educated guess at the alignment.

llvm-svn: 149161
 2012-01-28 00:53:29 +00:00
Douglas Gregor
e9fc377a44 Extend the ExternalASTSource interface to allow the AST source to 
provide the layout of records, rather than letting Clang compute
the layout itself. LLDB provides the motivation for this feature:
because various layout-altering attributes (packed, aligned, etc.)
don't get reliably get placed into DWARF, the record layouts computed
by LLDB from the reconstructed records differ from the actual layouts,
and badness occurs. This interface lets the DWARF data drive layout,
so we don't need the attributes preserved to get the answer write.

The testing methodology for this change is fun. I've introduced a
variant of -fdump-record-layouts called -fdump-record-layouts-simple
that always has the simple C format and provides size/alignment/field
offsets. There is also a -cc1 option -foverride-record-layout=<file>
to take the output of -fdump-record-layouts-simple and parse it to
produce a set of overridden layouts, which is introduced into the AST
via a testing-only ExternalASTSource (called
LayoutOverrideSource). Each test contains a number of records to lay
out, which use various layout-changing attributes, and then dumps the
layouts. We then run the test again, using the preprocessor to
eliminate the layout-changing attributes entirely (which would give us
different layouts for the records), but supplying the
previously-computed record layouts. Finally, we diff the layouts
produced from the two runs to be sure that they are identical.

Note that this code makes the assumption that we don't *have* to
provide the offsets of bases or virtual bases to get the layout right,
because the alignment attributes don't affect it. I believe this
assumption holds, but if it does not, we can extend
LayoutOverrideSource to also provide base offset information.

Fixes the Clang side of <rdar://problem/10169539>.

llvm-svn: 149055
 2012-01-26 07:55:45 +00:00
Richard Smith
dafff94759 constexpr irgen: Add irgen support for APValue::Struct, APValue::Union, 
APValue::Array and APValue::MemberPointer. All APValue values can now be emitted
as constants.

Add new CGCXXABI entry point for emitting an APValue MemberPointer. The other
entrypoints dealing with constant member pointers are no longer necessary and
will be removed in a later change.

Switch codegen from using EvaluateAsRValue/EvaluateAsLValue to
VarDecl::evaluateValue. This performs caching and deals with the nasty cases in
C++11 where a non-const object's initializer can refer indirectly to
previously-initialized fields within the same object.

Building the intermediate APValue object incurs a measurable performance hit on
pathological testcases with huge initializer lists, so we continue to build IR
directly from the Expr nodes for array and record types outside of C++11.

llvm-svn: 148178
 2012-01-14 04:30:29 +00:00
Eli Friedman
2e108376d5 Recommit r148056 with fixes to deal with weirdness with bitfields in unions. 
Original message: Make sure adding a field to a struct never reduces its size.  PR11745.

llvm-svn: 148070
 2012-01-12 23:48:56 +00:00
Eli Friedman
43f1834fad Revert r148056 while I investigate failures. 
llvm-svn: 148068
 2012-01-12 23:27:03 +00:00
Eli Friedman
8c89d125ff Make sure adding a field to a struct never reduces its size. PR11745. 
llvm-svn: 148056
 2012-01-12 22:41:25 +00:00
Douglas Gregor
64d9257e38 When performing layout for an Objective-C class, make sure to dig out 
the definition of that class. Fixes PR11613 / <rdar://problem/10604077>.

llvm-svn: 146976
 2011-12-20 15:50:13 +00:00
Douglas Gregor
dc9166c8e1 Keep track of all declarations of an Objective-C class (both forward 
declarations and definitions) as ObjCInterfaceDecls within the same
redeclaration chain. This new representation matches what we do for
C/C++ variables/functions/classes/templates/etc., and makes it
possible to answer the query "where are all of the declarations of
this class?"

llvm-svn: 146679
 2011-12-15 20:29:51 +00:00
Fariborz Jahanian
0586df4a00 Fixes a bug in calculation of field offsets of ms_struct 
fields by just following what comment says.
// rdar://10513599

llvm-svn: 146414
 2011-12-12 21:16:36 +00:00
Eli Friedman
a91d38a435 Fix bitfield handling for record layout with #pragma pack. <rdar://problem/10494810> and PR9560. 
llvm-svn: 145673
 2011-12-02 02:38:48 +00:00
Eli Friedman
83a1258342 Fix MSVC class layout for empty classes. Patch by Dmitry Sokolov. 
llvm-svn: 145544
 2011-12-01 00:37:01 +00:00
John McCall
0153cd3027 Fix the layout of vb-tables and vf-tables in the MS C++ ABI. 
Based on work by Dmitry Sokolov!

llvm-svn: 144072
 2011-11-08 04:01:03 +00:00
Benjamin Kramer
96ad717226 Now that we have a portable 64 bit format string use it to make this simple again. 
llvm-svn: 143800
 2011-11-05 09:02:52 +00:00
Eli Friedman
5b08d9adf5 Fix incorrect format string in debug output. 
llvm-svn: 143768
 2011-11-05 00:38:30 +00:00
Eli Friedman
43114f9084 More ASTRecordLayout changes for MS ABI; based on patch by r4start. 
llvm-svn: 142694
 2011-10-21 22:49:56 +00:00
Eli Friedman
66005df1f1 Revert accidental commit. 
llvm-svn: 142326
 2011-10-18 01:18:41 +00:00
Eli Friedman
5e9534b0ae Rewrite parts of MS ABI C++ layout. Based on work by r4start; I ended up doing this while I was trying to review his patch. 
llvm-svn: 142325
 2011-10-18 00:55:28 +00:00
Benjamin Kramer
b89514a9b8 Change operator<< for raw_ostream and NamedDecl to take a reference instead of a pointer. 
Passing a pointer was a bad idea as it collides with the overload for void*.

llvm-svn: 141971
 2011-10-14 18:45:37 +00:00
Richard Smith
caf3390d44 Constant expression evaluation refactoring: 
- Remodel Expr::EvaluateAsInt to behave like the other EvaluateAs* functions,
   and add Expr::EvaluateKnownConstInt to capture the current fold-or-assert
   behaviour.
 - Factor out evaluation of bitfield bit widths.
 - Fix a few places which would evaluate an expression twice: once to determine
   whether it is a constant expression, then again to get the value.

llvm-svn: 141561
 2011-10-10 18:28:20 +00:00
John McCall
f937c023bf Rename TagDecl::isDefinition -> isCompleteDefinition 
for better self-documenting code, since the semantics
are subtly different from getDefinition().

llvm-svn: 141355
 2011-10-07 06:10:15 +00:00
John McCall
0710e551ef Record layout requires not just a definition, but a complete 
definition.  Assert this.  Change IR generation to not try to
aggressively emit the IR translation of a record during its
own definition.  Fixes PR10912.

llvm-svn: 141350
 2011-10-07 02:39:22 +00:00
Daniel Dunbar
096ed290a1 Driver & AST: Implement support for -fpack-struct and -fpack-struct= command 
line options.
 - <rdar://problem/10120602>, PR9631

llvm-svn: 141211
 2011-10-05 21:04:55 +00:00
Eric Christopher
8a39a01a10 Fix doxygen comment. 
llvm-svn: 141165
 2011-10-05 06:00:51 +00:00
Eli Friedman
84d2d3a90e Some changes to improve compatibility for MSVC-style C++ struct layout. Patch from r4start at gmail.com (with some minor modifications by me). 
llvm-svn: 140623
 2011-09-27 19:12:27 +00:00
Ted Kremenek
fed48af3de Don't emit -Wpadded warnings without a valid SourceLocation. This can happen when RecordLayoutBuilder is used by Codegen, not Sema. 
llvm-svn: 139162
 2011-09-06 19:40:45 +00:00
Douglas Gregor
e8bbc12152 Extend the ASTContext constructor to delay the initialization of 
builtin types (When requested). This is another step toward making
ASTUnit build the ASTContext as needed when loading an AST file,
rather than doing so after the fact. No actual functionality change (yet).

llvm-svn: 138985
 2011-09-02 00:18:52 +00:00
Chad Rosier
e1a6a0e05c Add support for using anonymous bitfields (e.g., int : 0) to enforce alignment. 
This fixes cases where the anonymous bitfield is followed by a bitfield member.
E.g.,
struct t4
{
 char foo;
 long : 0;
 char bar : 1;
};

rdar://9859156

llvm-svn: 136991
 2011-08-05 22:38:04 +00:00
Chad Rosier
f01a7ddcd6 More whitespace and naming fixup. No functionality change. 
llvm-svn: 136944
 2011-08-04 23:34:15 +00:00
Chad Rosier
64b18eebc6 Fix style and remove obviously redundant code. 
llvm-svn: 136907
 2011-08-04 19:25:14 +00:00
Chad Rosier
a336c6f380 Additional comments and whitespace. 
llvm-svn: 136892
 2011-08-04 17:52:43 +00:00
Chad Rosier
18903ee2d3 Add partial support for using anonymous bitfields (e.g., int : 0) to enforce 
alignment.  This fixes cases where the anonymous bitfield is followed by a 
non-bitfield member.  E.g.,

struct t4
{
  int foo : 1;
  long : 0;
  char bar;
};

Part of rdar://9859156

llvm-svn: 136858
 2011-08-04 01:21:14 +00:00
Chris Lattner
0e62c1cc0b remove unneeded llvm:: namespace qualifiers on some core types now that LLVM.h imports 
them into the clang namespace.

llvm-svn: 135852
 2011-07-23 10:55:15 +00:00
Jordy Rose
a91768e569 Add a const overload for ObjCInterfaceDecl::all_declared_ivar_begin. 
This was previously not-const only because it has to lazily construct a chain
of ivars the first time it is called (and after the chain is invalidated).
In practice, all the clients were just const_casting their const Decls;
all those now-unnecessary const_casts have been removed.

llvm-svn: 135741
 2011-07-22 02:08:32 +00:00
Fariborz Jahanian
b26d578b41 Eliminate most uses of ShallowCollectObjCIvars which requires 
a vector for collection. Use iterators where needed instead.
// rdar://6817577

llvm-svn: 134015
 2011-06-28 18:05:25 +00:00
Eli Friedman
300f55dcad PR10120: Make CodeGenModule::getVTableLinkage use NamedDecl::getLinkage to determine whether the vtable should be externally visible, instead of a rough approximation of it which messes up with templates. 
While I'm here, zap the other user of isInAnonymousNamespace outside of Decl.cpp.

llvm-svn: 132861
 2011-06-10 21:53:06 +00:00
Fariborz Jahanian
783243b3ca Implenment #pack pragma and ms_struct attribute layout. 
Concludes // radar://8823265.

llvm-svn: 131188
 2011-05-11 16:58:31 +00:00
Fariborz Jahanian
07ceb0a1a4 Support pack pragma and ms_struct attributes. // rdar://8823265 
llvm-svn: 131142
 2011-05-10 19:00:50 +00:00
Fariborz Jahanian
7adbed6b4d 'long long' requires special treatment in ms_struct 
structs (impacts 32-bit only though).

llvm-svn: 131103
 2011-05-09 22:03:17 +00:00
Fariborz Jahanian
307eace474 In ms_struct structs, Establish a new alignment for a 
non-bitfield following a bitfield if size of their types differ.

llvm-svn: 131032
 2011-05-06 22:42:22 +00:00
Fariborz Jahanian
b7a2879677 Establish a new alignment for an ms_struct bitfield following 
a non-bitfield if size of their types differ.

llvm-svn: 131023
 2011-05-06 21:56:12 +00:00
Fariborz Jahanian
84335f7c8e More ms_struct bitfield stuff: 
Adjacent bit fields are packed into the same 1-, 2-, or
4-byte allocation unit if the integral types are the same
size. // rdar://8823265.

llvm-svn: 130851
 2011-05-04 18:51:37 +00:00
Fariborz Jahanian
759e4a1add Only the first zero-length bitfield decides alignment of 
the followup data member in an ms_struct struct.
// rdar:// 8823265

llvm-svn: 130795
 2011-05-03 22:07:14 +00:00
Fariborz Jahanian
fc0fe6eb52 Finish off rules for z-length bitfields in ms_struct 
structs. // rdar://8823265

llvm-svn: 130783
 2011-05-03 20:21:04 +00:00
Fariborz Jahanian
eb39741c0b More rule enforcement of zero bitfields for ms_struct. 
llvm-svn: 130696
 2011-05-02 17:20:56 +00:00
Fariborz Jahanian
595ec5d43c Some refactoring of my ms_struct patch. 
// rdar://8823265 related.

llvm-svn: 130311
 2011-04-27 17:14:21 +00:00
Fariborz Jahanian
bcb23a180b With ms_struct attribut, Zero-length bitfields following 
non-bitfield members are ignore. // rdar://8823265 wip

llvm-svn: 130257
 2011-04-26 23:52:16 +00:00
Ted Kremenek
022dbc1672 Simplify crash recovery cleanup registration. 
llvm-svn: 128057
 2011-03-22 01:15:19 +00:00
Ted Kremenek
f75d089679 Recover memory from RecordLayoutBuilders during crashes. 
llvm-svn: 127931
 2011-03-19 01:00:36 +00:00
Ken Dyck
a1a2e8decb Instead of round up sizes to '8', round them up to the alignment of the char 
type.

llvm-svn: 127391
 2011-03-10 02:00:35 +00:00
Ken Dyck
e73807538a Round up the non-virtual size to the next char instead of rounding down. 
llvm-svn: 127390
 2011-03-10 01:53:59 +00:00
Ken Dyck
dbe37f38d0 Use CharUnits for TypeAlign variable in LayoutWideBitField(). No change in 
functionality intended.

llvm-svn: 126730
 2011-03-01 01:36:00 +00:00
Ken Dyck
aab635e67a Change the return type of GetVirtualPointersSize() to CharUnits. No change 
in functionality intended.

llvm-svn: 126727
 2011-03-01 01:22:45 +00:00
Ken Dyck
1b4420ed42 Retry r126357. Use CharUnits for the Size and DataSize calculations when 
they are known to be exact multiples of the width of the char type. Add a
test case to CodeGen/union.c that would have caught the problem with the
previous attempt. No change in functionality intended.

llvm-svn: 126628
 2011-02-28 02:01:38 +00:00
Daniel Dunbar
30cdc7022b Revert "Use CharUnits values for Size and DataSize outside of the bitfield 
layout", it broke some GCC tests.

llvm-svn: 126386
 2011-02-24 16:40:53 +00:00
Ken Dyck
8e74e79145 Use CharUnits values for Size and DataSize outside of the bitfield layout 
methods, when they are known to be exact multiples of the width of the char
type. 

llvm-svn: 126357
 2011-02-24 02:12:14 +00:00
Ken Dyck
3c215f2fd1 Use Context.getCharWidth() in place of literal '8's in assertions. 
llvm-svn: 126356
 2011-02-24 01:33:05 +00:00
Ken Dyck
ecfc75529f Make the Size and DataSize members more CharUnits-friendly by wrapping them 
with getter and setter methods in both bit units and CharUnits. This will help
simplify some of the unit mismatch in the parts of the code where sizes are
known to be exact multiples of the width of the char type.

Assertions in the getters help guard against accidentally converting to
CharUnits when sizes are not exact multiples of the char width.

llvm-svn: 126354
 2011-02-24 01:13:28 +00:00
Ken Dyck
6d90e8937c Expand use of CharUnits in LayoutField(). No change in functionality 
intended.

llvm-svn: 126066
 2011-02-20 02:06:09 +00:00
Ken Dyck
85ef0431a7 Expand use of CharUnits for alignments further. No change in functionality 
intended.

llvm-svn: 126034
 2011-02-19 18:58:07 +00:00
Ken Dyck
02ced6fd19 Convert MaxFieldAlignment to CharUnits from bits. No change in functionality 
intended.

llvm-svn: 125704
 2011-02-17 01:49:42 +00:00
Ken Dyck
1300b3b357 Convert the UnpackedAlignment field to CharUnits from bits. No change in 
functionality intended.

llvm-svn: 125643
 2011-02-16 02:11:31 +00:00
Ken Dyck
4731d5b65a Convert Alignment member to CharUnits from bits. No change in functionality 
intended.

llvm-svn: 125641
 2011-02-16 02:05:21 +00:00
Ken Dyck
af1c83fbe7 Convert NonVirtualSize to CharUnits from bits. No change in functionality 
intended.

llvm-svn: 125639
 2011-02-16 01:52:01 +00:00
Ken Dyck
a2d3dda041 Convert NonVirtualAlignment to CharUnits. No change in functionality 
intended.

llvm-svn: 125638
 2011-02-16 01:43:15 +00:00
Ken Dyck
7ad11e70b6 Convert RecordLayout::Alignment to CharUnits from bit units. No change in 
functionality intended. 

llvm-svn: 125549
 2011-02-15 02:32:40 +00:00
Ken Dyck
d5090c16f8 Convert RecordLayout::DataSize to CharUnits from bits, eliminating two 
unnecessary calls to RoundUpToAlignment. No changes to functionality
intended.

llvm-svn: 125356
 2011-02-11 02:20:09 +00:00
Ken Dyck
b0fcc59e19 Add a helper function, ASTContext::toBits(), that converts sizes in 
CharUnits to sizes in bits, and use it to tidy up the places where the
conversion was done explicitly.

llvm-svn: 125332
 2011-02-11 01:54:29 +00:00
Ken Dyck
c8ae55050d Convert RecordLayout::Size to CharUnits from bits. No changes to 
functionality intended.

llvm-svn: 125156
 2011-02-09 01:59:34 +00:00
Ken Dyck
bec0285d7f Convert RecordLayout::NonVirtualAlign to CharUnits. No change in 
functionality intended.

llvm-svn: 125069
 2011-02-08 02:02:47 +00:00
Fariborz Jahanian
09b2331cf7 For gcc compatibility, size of a class which is zero 
but has non-empty data fields, such as array of zero length,
remains zero.
// rdar://8945175

llvm-svn: 124741
 2011-02-02 19:36:18 +00:00
Douglas Gregor
dbe3927026 Basic support for -mms-bitfields, from Carl Norum! 
llvm-svn: 124661
 2011-02-01 15:15:22 +00:00
Ken Dyck
316d6f69bc Convert RecordLayout::NonVirtualSize from bit units to CharUnits. 
llvm-svn: 124646
 2011-02-01 01:52:10 +00:00
Ken Dyck
7c4026bea7 Remove private toCharUnits() helper method, replacing with calls to 
ASTContext::toCharUnitsFromBits().

llvm-svn: 124092
 2011-01-24 01:28:50 +00:00
Ken Dyck
86a7fcc19c Replace calls to CharUnits::fromQuantity() with ones 
ASTContext::toCharUnitsFromBits() when converting from bit sizes to char units.

llvm-svn: 123715
 2011-01-18 01:56:16 +00:00
Jay Foad
39c7980772 PR3558: mark "logically const" accessor methods in ASTContext as const, 
and mark the fields they use as mutable. This allows us to remove a few
const_casts.

llvm-svn: 123314
 2011-01-12 09:06:06 +00:00
Rafael Espindola
7bcde197d7 Fix PR8796. 
The problem was that we were asserting the we never added an empty class
to the same offset twice. This is not true for unions, where two members, empty
or not, can have the some offset.

llvm-svn: 122633
 2010-12-29 23:02:58 +00:00
Argyrios Kyrtzidis
d62c9be4fc Fix another unnecessary-struct-padding issue. 
llvm-svn: 121352
 2010-12-09 02:47:58 +00:00
Argyrios Kyrtzidis
8b54274fcf Before determining the effect the alignment of base struct will have in the aligment of the sub-struct, 
take into account if the sub-struct is packed and its maximum field alignment.

Fixes rdar://8745206

llvm-svn: 121335
 2010-12-09 00:35:20 +00:00
Anders Carlsson
60a6263ee8 Move isNearlyEmpty out into the ASTContext so it can be called from CodeGen as well. 
llvm-svn: 120137
 2010-11-25 01:51:53 +00:00
Anders Carlsson
7f95cd1817 Rename RecordLayout::getPrimaryBaseWasVirtual to isPrimaryBaseVirtual. 
llvm-svn: 120133
 2010-11-24 23:12:57 +00:00
Anders Carlsson
5adde29d86 Use the newly added function in ASTRecordLayoutBuilder. 
llvm-svn: 120131
 2010-11-24 22:55:48 +00:00
Argyrios Kyrtzidis
d004064864 Refactoring of Diagnostic class. 
-Move the stuff of Diagnostic related to creating/querying diagnostic IDs into a new DiagnosticIDs class.
-DiagnosticIDs can be shared among multiple Diagnostics for multiple translation units.
-The rest of the state in Diagnostic object is considered related and tied to one translation unit.
-Have Diagnostic point to the SourceManager that is related with. Diagnostic can now accept just a
   SourceLocation instead of a FullSourceLoc.
-Reflect the changes to various interfaces.

llvm-svn: 119730
 2010-11-18 20:06:41 +00:00
Anders Carlsson
09814d3f3a Don't update empty field subobjects for bitfields. Fixes PR8519. 
llvm-svn: 117921
 2010-11-01 15:14:51 +00:00
Anders Carlsson
0a14ee9ed8 Get rid of more calls to getBaseClassOffsetInBits. 
llvm-svn: 117883
 2010-11-01 00:21:58 +00:00
Anders Carlsson
3f01871647 Port over a couple of getVBaseClassOffsetInBits call sites to use getVBaseClassOffset instead. 
llvm-svn: 117882
 2010-10-31 23:45:59 +00:00
Anders Carlsson
fd88a6160d Rename getBaseClassOffset to getBaseClassOffsetInBits and introduce a getBaseClassOffset which returns the offset in CharUnits. Do the same thing for getVBaseClassOffset. 
llvm-svn: 117881
 2010-10-31 23:22:37 +00:00
Anders Carlsson
a2f8e41a0a Start converting over the RecordLayoutBuilder next. 
llvm-svn: 117878
 2010-10-31 22:20:42 +00:00
Anders Carlsson
28466ab8f4 EmptyObjectMap now uses CharUnits wherever possible. 
llvm-svn: 117877
 2010-10-31 22:13:23 +00:00
Anders Carlsson
233e272775 More CharUnits conversion. 
llvm-svn: 117875
 2010-10-31 21:54:55 +00:00
Anders Carlsson
725190ff3f More CharUnits conversion. 
llvm-svn: 117874
 2010-10-31 21:39:24 +00:00
Anders Carlsson
f8f756d1d5 Use CharUnits in the EmptyClassOffsets map. 
llvm-svn: 117873
 2010-10-31 21:22:43 +00:00
Anders Carlsson
22f5720c27 Baby steps towards using only CharUnits for base class offsets in ASTRecordLayout. Start by storing the offsets in CharUnits in the ASTRecordLayout object. 
llvm-svn: 117869
 2010-10-31 21:01:46 +00:00
Benjamin Kramer
2fc373e155 Move classes into anonymous namespaces. 
llvm-svn: 117104
 2010-10-22 16:33:16 +00:00
Argyrios Kyrtzidis
6843141d39 Store in PCH the key function of C++ class to avoid deserializing the complete declaration context in order to compute it. 
Progress for rdar://7260160.

llvm-svn: 116508
 2010-10-14 20:14:38 +00:00
Argyrios Kyrtzidis
8c64bbe032 Embrace C++ ABI 5.2.6 and consider that template instantiations don't have key functions (same as GCC). 
llvm-svn: 116391
 2010-10-13 02:39:41 +00:00
Argyrios Kyrtzidis
ca0d0cd3b9 Implement -Wpadded and -Wpacked. 
-Wpadded warns when undesired padding is introduced in a struct. (rdar://7469556)
-Wpacked warns if a struct is given the packed attribute, but the packed attribute has no effect
  on the layout or the size of the struct. Such structs may be mis-aligned for little benefit.

The warnings are emitted at the point where layout is calculated, that is at RecordLayoutBuilder.
To avoid calculating the layouts of all structs regardless of whether they are needed or not,
I let the layouts be lazily constructed when needed. This has the disadvantage that the above warnings
will be emitted only when they are used for IR gen, and not e.g with -fsyntax-only:

$ cat t.c
struct S {
  char c;
  int i;
};
void f(struct S* s) {}

$ clang -fsyntax-only -Wpadded t.c
$ clang -c -Wpadded t.c -o t.o
t.c:3:7: warning: padding struct 'struct S' with 3 bytes to align 'i' [-Wpadded]
  int i;
      ^
1 warning generated.

This is a good tradeoff between providing the warnings and not calculating layouts for all
structs in case the user has enabled a couple of rarely used warnings.

llvm-svn: 114544
 2010-09-22 14:32:24 +00:00
Argyrios Kyrtzidis
3c6cd17c8a Use a smart pointer instead of delete. 
llvm-svn: 112005
 2010-08-25 00:32:14 +00:00
Chandler Carruth
76c0cb493f Add a virtual destructor to the base of another class hierarchy with virtual 
methods.

llvm-svn: 111804
 2010-08-23 08:37:21 +00:00
Charles Davis
6bcb07ad71 Add some enum goodness as requested by Chris. Now instead of storing the 
active C++ ABI as a raw string, we store it as an enum. This should improve
performance somewhat.

And yes, this time, I started from a clean build directory, and
all the tests passed. :)

llvm-svn: 111507
 2010-08-19 02:18:14 +00:00
John McCall
1ed0182413 Restore the build 
llvm-svn: 111498
 2010-08-19 01:21:57 +00:00
Charles Davis
c2c576a9e7 Add a special RecordLayoutBuilder for the Microsoft C++ ABI. 
All it does right now is add space for two vtable pointers instead of one
when a class has both virtual methods and virtual bases. This is a requirement
of the Microsoft ABI, since it has separate vtables for methods and bases. Other
stuff will come up over time, but we'll cross those bridges when we get to
them.

llvm-svn: 111493
 2010-08-19 00:55:19 +00:00
Alexis Hunt
dcfba7b35b Generate Attr subclasses with TableGen. 
Now all classes derived from Attr are generated from TableGen.
Additionally, Attr* is no longer its own linked list; SmallVectors or
Attr* are used. The accompanying LLVM commit contains the updates to
TableGen necessary for this.

Some other notes about newly-generated attribute classes:

 - The constructor arguments are a SourceLocation and a Context&,
   followed by the attributes arguments in the order that they were
   defined in Attr.td

 - Every argument in Attr.td has an appropriate accessor named getFoo,
   and there are sometimes a few extra ones (such as to get the length
   of a variadic argument).

Additionally, specific_attr_iterator has been introduced, which will
iterate over an AttrVec, but only over attributes of a certain type. It
can be accessed through either Decl::specific_attr_begin/end or
the global functions of the same name.

llvm-svn: 111455
 2010-08-18 23:23:40 +00:00
Daniel Dunbar
56df97761d StringRef'ication of lots stuff, patch by Peter Davies! 
llvm-svn: 111314
 2010-08-17 22:39:59 +00:00
Argyrios Kyrtzidis
499e6e49e7 Remove ATTRIBUTE_UNUSED from the common pattern of disallowing copying. 
llvm-svn: 111101
 2010-08-15 10:17:39 +00:00
Argyrios Kyrtzidis
0a33cb62a6 Add ATTRIBUTE_UNUSED to methods not supposed to be used. 
llvm-svn: 111087
 2010-08-15 01:15:27 +00:00
Daniel Dunbar
f35e76552f Sema: Fix a subtle i64 -> i32 truncation which broke layout of large structures 
with bit-fields.

llvm-svn: 107185
 2010-06-29 18:34:35 +00:00
Jeffrey Yasskin
bb219e01a6 Delete assert in ComputeKeyFunction. The function runs fine without it, since 
there's an explicit guard on isPolymorphic, and virtual bases don't affect the
key function calculation.  This allows people to call
ASTContext::getKeyFunction on arbitrary classes.

llvm-svn: 107143
 2010-06-29 15:27:35 +00:00
Anders Carlsson
cc59cc5d80 Do the same short-circuit optimization when laying out bases. 
llvm-svn: 105920
 2010-06-13 18:00:18 +00:00
Anders Carlsson
ae111dc821 Implement part of the EmptySubobjectMap optimization described in PR6998. We still need to do this for bases. 
llvm-svn: 105919
 2010-06-13 17:49:16 +00:00
Anders Carlsson
446872069f Correctly handle fields with virtual bases containing empty subobjects. 
llvm-svn: 105628
 2010-06-08 19:09:24 +00:00
Anders Carlsson
45c1d2898e When checking whether we can place a base subobject at an offset, we don't need to go past the highest offset that's known to contain an empty base subobject. 
llvm-svn: 105611
 2010-06-08 16:20:35 +00:00
Anders Carlsson
cc5de097a6 Minor cleanups to the empty subobject map. 
llvm-svn: 105608
 2010-06-08 15:56:03 +00:00
Anders Carlsson
7498b32117 And now for the best part: Removing the old code. 
llvm-svn: 105162
 2010-05-30 06:56:46 +00:00
Anders Carlsson
b1fcdd063c Turn on the new empty base subobject tracking code. It's a bit faster than the previous code. However, it still has quadratic performance, something which I intend to fix shortly in a subsequent patch. 
llvm-svn: 105161
 2010-05-30 06:52:33 +00:00
Anders Carlsson
a7774a685d Cleanup. 
llvm-svn: 105114
 2010-05-29 21:10:24 +00:00
Anders Carlsson
a60b86a3fa Make EmptySubobjectMap::CanPlaceBaseAtOffset take a BaseSubobjectInfo as well. 
llvm-svn: 105113
 2010-05-29 20:49:49 +00:00
Anders Carlsson
d7f3fcf248 Change RecordLayoutBuilder::LayoutBase to take a BaseSubobjectInfo. No functionality change. 
llvm-svn: 105112
 2010-05-29 20:47:33 +00:00
Anders Carlsson
6b0d914ad0 Rework the way virtual primary bases are added when laying out classes. Instead of doing it as a separate step, we now use the BaseSubobjectInfo and use it when laying out the bases. This fixes a bug where we would either not add a primary virtual base at all, or add it at the wrong offset. 
llvm-svn: 105110
 2010-05-29 19:44:50 +00:00
Anders Carlsson
d6ff5d7787 Change LayoutVirtualBase to also take a BaseSubobjectInfo. 
llvm-svn: 105104
 2010-05-29 17:48:36 +00:00
Anders Carlsson
bb0e6787b0 Change RecordLayoutBuilder::LayoutNonVirtualBase to take a BaseSubobjectInfo. No functionality change. 
llvm-svn: 105103
 2010-05-29 17:42:25 +00:00
Anders Carlsson
e3c24c7033 Move computing the base subobject info for a class into the RecordLayoutBuilder because we're going to need it to be able to correctly add offsets for primary virtual bases. 
llvm-svn: 105102
 2010-05-29 17:35:14 +00:00
Anders Carlsson
a7f3cdb0f2 Rename BaseInfo to BaseSubobjectInfo. 
llvm-svn: 105007
 2010-05-28 21:24:37 +00:00
Anders Carlsson
056818f8a2 Move BaseInfo outside of the EmptySubobject class. 
llvm-svn: 105002
 2010-05-28 21:13:31 +00:00
Anders Carlsson
db319761e7 More work on the empty subobject map. This code is not yet used. 
llvm-svn: 104861
 2010-05-27 18:20:57 +00:00
Daniel Dunbar
6da1098b4b Sema: Add initial support for '#pragma options align=mac68k'. 
- Docs are fairly sketchy, if someone wants to pore through gcc to look for
   holes I'd appreciate any failing test cases!

llvm-svn: 104809
 2010-05-27 05:45:51 +00:00
Anders Carlsson
439edd1aea More work on the new empty subobject map. 
llvm-svn: 104808
 2010-05-27 05:41:06 +00:00
Daniel Dunbar
592a85c137 Strip trailing whitespace. 
llvm-svn: 104801
 2010-05-27 02:25:46 +00:00
Daniel Dunbar
401304462a AST: Rename PragmaPackAttr to MaxFieldAlignmentAttr, which is more accurate. 
llvm-svn: 104795
 2010-05-27 01:12:46 +00:00
Anders Carlsson
c121b4e59f More work on the empty subobjects map. 
llvm-svn: 104787
 2010-05-27 00:07:01 +00:00
Anders Carlsson
c5ca1f7799 Move ComputeEmptySubobjectSizes to EmptySubobjectMap. 
llvm-svn: 104702
 2010-05-26 15:54:25 +00:00
Anders Carlsson
f58de11b61 Stub out the EmptySubobjectsMap class. 
llvm-svn: 104701
 2010-05-26 15:32:58 +00:00
Anders Carlsson
ce7f77729a Inline the RecordLayoutBuilder constructor. 
llvm-svn: 104700
 2010-05-26 15:20:08 +00:00
Anders Carlsson
c28a6c9251 Add a Layout overload that takes a CXXRecordDecl. 
llvm-svn: 104695
 2010-05-26 15:10:00 +00:00
Benjamin Kramer
c7656cdf83 Move RecordLayoutBuilder into an anonymous namespace. 
llvm-svn: 104693
 2010-05-26 09:58:31 +00:00
Anders Carlsson
c222620adf Rename ASTRecordLayoutBuilder to RecordLayoutBuilder. 
llvm-svn: 104688
 2010-05-26 05:58:59 +00:00
Anders Carlsson
35a36eb78d Move the ASTRecordLayoutBuilder class declaration into the .cpp file. 
llvm-svn: 104686
 2010-05-26 05:41:04 +00:00
Anders Carlsson
b48414f4cb Fix thinko and remove another unused function. 
llvm-svn: 104683
 2010-05-26 05:31:23 +00:00
Anders Carlsson
1d1e4cf04d Fix build. 
llvm-svn: 104682
 2010-05-26 05:25:15 +00:00
Anders Carlsson
d20e7cd3c6 No need to use the PrimaryBaseInfo struct in the builder. 
llvm-svn: 104681
 2010-05-26 05:20:58 +00:00
Anders Carlsson
87209bb54b Remove FIXME. 
llvm-svn: 104674
 2010-05-26 05:11:02 +00:00
Anders Carlsson
d295486012 Fold the other Layout overload into its sole call site. 
llvm-svn: 104673
 2010-05-26 05:10:47 +00:00
Anders Carlsson
6ed3a9a494 Fold the ASTRecordLayoutBuilder::ComputeLayout overload that takes an ObjCInterfaceDecl pointer into its only callsite. 
llvm-svn: 104672
 2010-05-26 05:04:25 +00:00
Anders Carlsson
df291d8d8b Move the relevant ASTContext member functions that deal with ASTRecordLayoutBuilder into RecordLayoutBuilder.cpp. This matches the way we interact with other builder classes (CGRecordLayoutBuilder, VTableBuilder and VTTBuilder) and it also allows for making ASTRecordLayoutBuilder a private class without a header file. 
llvm-svn: 104671
 2010-05-26 04:56:53 +00:00
Anders Carlsson
5773205a8d When recording empty subobjects we should always look at the primary virtual base. 
llvm-svn: 104464
 2010-05-23 18:14:24 +00:00
Anders Carlsson
5f1a1704a2 Add an UpdateVBases parameter to UpdateEmptyClassOffsets. Not used just yet. 
llvm-svn: 103403
 2010-05-10 15:28:59 +00:00
Anders Carlsson
d626cb74d1 More work on handling empty classes. 
llvm-svn: 103402
 2010-05-10 15:26:14 +00:00
Anders Carlsson
82828a31f6 Cleanup. 
llvm-svn: 103370
 2010-05-09 05:03:38 +00:00
Anders Carlsson
15837f8f63 Actually compute the empty subobject sizes. No functionality change yet. 
llvm-svn: 103363
 2010-05-08 23:06:26 +00:00
Anders Carlsson
2357bfd9d0 Add a SizeOfLargestEmptySubobject member to ASTRecordLayout. For C++ classes this will hold the largest empty subobject or 0 if the class doesn't have any empty subobjects. 
llvm-svn: 103359
 2010-05-08 22:35:05 +00:00
Daniel Dunbar
ccabe48235 AST: Dump ASTRecordLayout objects when they are created with -fdump-record-layouts. 
llvm-svn: 101815
 2010-04-19 20:44:53 +00:00
Dan Gohman
145f3f1e83 Fix -Wcast-qual warnings. 
llvm-svn: 101786
 2010-04-19 16:39:44 +00:00
Anders Carlsson
aad5fa85d0 If a wide bit-field is inside a union its offset should always be 0. 
llvm-svn: 101668
 2010-04-17 20:21:41 +00:00
Benjamin Kramer
b11416d061 Add raw_ostream operators to NamedDecl for convenience. Switch over all users of getNameAsString on a stream. 
The next step is to print the name directly into the stream, avoiding a temporary std::string copy.

llvm-svn: 101632
 2010-04-17 09:33:03 +00:00
Anders Carlsson
d9abbe56a5 Remove printfs. 
llvm-svn: 101470
 2010-04-16 15:59:41 +00:00
Anders Carlsson
5723516ce9 More work on wide bit-fields, WIP. 
llvm-svn: 101467
 2010-04-16 15:57:11 +00:00
Anders Carlsson
5efc56e36b Rename the ASTContext member 'Context'. 
llvm-svn: 101462
 2010-04-16 15:07:51 +00:00
Anders Carlsson
ea7b18298e Split adding the primary virtual base offsets out into a separate pass. This fixes a bug where we would lay out virtual bases in the wrong order. 
llvm-svn: 101373
 2010-04-15 16:12:58 +00:00
Daniel Dunbar
1da6511b99 Tweak spelling (Bitfield -> BitField) 
llvm-svn: 101369
 2010-04-15 15:06:18 +00:00
Daniel Dunbar
3d9289c736 Add TargetInfo::useBitfieldTypeAlignment(). 
- Used to determine whether the alignment of the type in a bit-field is
   respected when laying out structures. The default is true, targets can
   override this as needed.

 - This is designed to correspond to the PCC_BITFIELD_TYPE_MATTERS macro in
   gcc. The AST/Sema implementation only affects one line, unless I have
   forgotten something. I'd appreciate further review.

 - IRgen still needs to be updated to fully support this (which is effectively
   PR5591).

llvm-svn: 101356
 2010-04-15 06:18:39 +00:00
Daniel Dunbar
fe53aaef51 Remove unnecessary cast. 
llvm-svn: 101176
 2010-04-13 20:52:05 +00:00
Anders Carlsson
7a148f7141 Fix another vbase layout bug. 
llvm-svn: 100952
 2010-04-10 21:35:33 +00:00
Anders Carlsson
5b441d73b7 Add a simple debug-only verification pass to the record layout builder. 
llvm-svn: 100951
 2010-04-10 21:24:48 +00:00
Anders Carlsson
291279e3a6 Simplify the virtual base layout code and fix a bug where we wouldn't store the offset for a virtual base. 
llvm-svn: 100940
 2010-04-10 18:42:27 +00:00
Daniel Dunbar
aa423afffc AST: Move C++ record layout dumping to ASTContext::DumpRecordLayout. 
llvm-svn: 100746
 2010-04-08 02:59:49 +00:00
Anders Carlsson
fe9009635d More record layout builder cleanup and simplification. 
llvm-svn: 98238
 2010-03-11 05:42:17 +00:00
Anders Carlsson
de710c9125 Get rid of the PrimaryBase parameter from LayoutVirtualBases. 
llvm-svn: 98233
 2010-03-11 04:33:54 +00:00
Anders Carlsson
f7b7a1e781 More cleanup towards fixing the real bug. 
llvm-svn: 98232
 2010-03-11 04:24:02 +00:00
Anders Carlsson
6a84889d3f Replace the class offset vectors in RecordLayoutBuilder with maps instead so we'll have faster lookup and so we can detect duplicates. 
llvm-svn: 98231
 2010-03-11 04:10:39 +00:00
Anders Carlsson
f2fa75bdbb More cleanup. 
llvm-svn: 98230
 2010-03-11 03:39:12 +00:00
Anders Carlsson
c4c00ec41b More record layout builder cleanup. 
llvm-svn: 98229
 2010-03-11 02:41:30 +00:00
Anders Carlsson
aa87b4eab1 Remove the IndirectPrimary parameter in LayoutVirtualBases; it's already there as a member variable. 
llvm-svn: 98211
 2010-03-11 00:21:21 +00:00
Anders Carlsson
8630b5b09b More cleanup and simplification of the record layout builder. 
llvm-svn: 98208
 2010-03-11 00:15:35 +00:00
Anders Carlsson
0d0b588fb2 Get rid of the LayoutBaseNonVirtually; it was used to lay out a base either as a non-virtual base or a virtual base. 
llvm-svn: 98198
 2010-03-10 22:26:24 +00:00
Anders Carlsson
09ffa32b92 More shuffling. 
llvm-svn: 98197
 2010-03-10 22:21:28 +00:00
Anders Carlsson
f08e681ba8 Cleanups, no functionality change yet. 
llvm-svn: 98196
 2010-03-10 22:16:06 +00:00
Ted Kremenek
c3015a914f Allocate ASTRecordLayout objects using the allocator associated with ASTContext. 
This allows them to be allocated using a BumpPtrAllocated
in the common case.

llvm-svn: 97978
 2010-03-08 20:56:29 +00:00
Fariborz Jahanian
aef662206b Patch removes IVars list from ObjCInterfaceDecl and 
instead relies on their DeclContext for iteration, etc.

llvm-svn: 96638
 2010-02-19 00:31:17 +00:00
Zhongxing Xu
ec345b7ecb Simplify code. If we can reach here, the base must be virtual. 
llvm-svn: 96211
 2010-02-15 04:28:35 +00:00
Mike Stump
0a2754ed8a Be sure to select primary bases among the nearly empties in preorder, 
not just among the direct bases.  Before we where missing nearly
empties that were bases of virtual base classes.

llvm-svn: 94208
 2010-01-22 20:27:17 +00:00
Douglas Gregor
a318efd1f2 Improve key-function computation for templates. In particular: 
- All classes can have a key function; templates don't change that.
  non-template classes when computing the key function.
  - We always mark all of the virtual member functions of class
  template instantiations. 
  - The vtable for an instantiation of a class template has weak
  linkage. 

We could probably use available_externally linkage for vtables of
classes instantiated by explicit instantiation declarations (extern
templates), but GCC doesn't do this and I'm not 100% that the ABI
permits it.

llvm-svn: 92753
 2010-01-05 19:06:31 +00:00
Eli Friedman
f2c79b6b9c Misc key function fixes. 
llvm-svn: 90831
 2009-12-08 03:56:49 +00:00
Anders Carlsson
8e0317bf05 Instantiated or specialized class templates never have a key function. This (and the previous check-in) fixes PR5557. 
llvm-svn: 90753
 2009-12-07 08:29:39 +00:00
Anders Carlsson
5ebf8b44e9 Move key functions to a separate map. 
llvm-svn: 90745
 2009-12-07 04:35:11 +00:00
Eli Friedman
71a26d8f82 Move helper onto CXXMethodDecl. 
llvm-svn: 90716
 2009-12-06 20:50:05 +00:00
Eli Friedman
0846d52f70 Tweak "key function" rules so that they work for templates with virtual 
inline functions.

llvm-svn: 90645
 2009-12-05 04:55:55 +00:00
Anders Carlsson
f98849eb8a In Sema, whenever we think that a function is going to cause a vtable to be generated, we mark any virtual implicit member functions as referenced. 
llvm-svn: 90327
 2009-12-02 17:15:43 +00:00