5 Commits

Author	SHA1	Message	Date
Rafael Espindola	437b0d5887	Use std::unique_ptr to make the ownership explicit. ... llvm-svn: 214377	2014-07-31 03:12:45 +00:00
Rafael Espindola	2e60ca964c	Pass a unique_ptr<MemoryBuffer> to the constructors in the Binary hierarchy. ... Once the objects are constructed, they own the buffer. Passing a unique_ptr makes that clear. llvm-svn: 211595	2014-06-24 13:56:32 +00:00
Rafael Espindola	6304e94108	Pass a std::unique_ptr& to the create??? methods is lib/Object. ... This makes the buffer ownership on error conditions very natural. The buffer is only moved out of the argument if an object is constructed that now owns the buffer. llvm-svn: 211546	2014-06-23 22:00:37 +00:00
Rafael Espindola	c3f9b5a534	Make ObjectFile and BitcodeReader always own the MemoryBuffer. ... This allows us to just use a std::unique_ptr to store the pointer to the buffer. The flip side is that they have to support releasing the buffer back to the caller. Overall this looks like a more efficient and less brittle api. llvm-svn: 211542	2014-06-23 21:53:12 +00:00
Rafael Espindola	f12b82824a	Add a SymbolicFile interface between Binary and ObjectFile. ... This interface allows IRObjectFile to be implemented without having dummy methods for all section and segment related methods. Both llvm-ar and llvm-nm are changed to use it. Unfortunately the mangler is still not plugged in since it requires some refactoring to make a Module hold a DataLayout. llvm-svn: 201881	2014-02-21 20:10:59 +00:00