Gericom/teak-llvm
1
Fork 0
mirror of https://github.com/Gericom/teak-llvm.git synced 2025-06-23 21:45:46 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity
171,804 Commits 1 Branch 0 Tags 875 MiB
191ec63b71
Commit Graph

162 Commits

Author SHA1 Message Date
Daniel Dunbar
d3f3d932ee IRgen: Add a -fuse-register-sized-bitfield-access option, for testing. 
- Changes bit-field access policy to try to use (aligned) register sized accesses.

The idea here is that by using larger accesses we expose more coalescing
potential to the backend when we have situations like adjacent bit-fields in the
same structure (which is common), and that the backend should be smart enough to
narrow the accesses down when no coalescing is done or when it is shown not to
be profitable.

--
$ clang -m32 -O3 -S -o - t.c
_f0:                                    ## @f0
	pushl	%ebp
	movl	%esp, %ebp
	movl	8(%ebp), %eax
	movb	(%eax), %cl
	andb	$-128, %cl
	orb	$1, %cl
	movb	%cl, (%eax)
	movb	1(%eax), %cl
	andb	$-128, %cl
	orb	$1, %cl
	movb	%cl, 1(%eax)
	movb	2(%eax), %cl
	andb	$-128, %cl
	orb	$1, %cl
	movb	%cl, 2(%eax)
	movb	3(%eax), %cl
	andb	$-128, %cl
	orb	$1, %cl
	movb	%cl, 3(%eax)
	popl	%ebp
	ret

$ clang -m32 -O3 -S -o - t.c -Xclang -fuse-register-sized-bitfield-access
_f0:                                    ## @f0
	pushl	%ebp
	movl	%esp, %ebp
	movl	8(%ebp), %eax
	movl	$-2139062144, %ecx      ## imm = 0xFFFFFFFF80808080
	andl	(%eax), %ecx
	orl	$16843009, %ecx         ## imm = 0x1010101
	movl	%ecx, (%eax)
	popl	%ebp
	ret
--

llvm-svn: 133532
 2011-06-21 18:54:46 +00:00
Douglas Gregor
6ab2fa8f78 Introduce Type::isSignedIntegerOrEnumerationType() and 
Type::isUnsignedIntegerOrEnumerationType(), which are like
Type::isSignedIntegerType() and Type::isUnsignedIntegerType() but also
consider the underlying type of a C++0x scoped enumeration type.

Audited all callers to the existing functions, switching those that
need to also handle scoped enumeration types (e.g., those that deal
with constant values) over to the new functions. Fixes PR9923 /
<rdar://problem/9447851>.

llvm-svn: 131735
 2011-05-20 16:38:50 +00:00
Fariborz Jahanian
fc0fe6eb52 Finish off rules for z-length bitfields in ms_struct 
structs. // rdar://8823265

llvm-svn: 130783
 2011-05-03 20:21:04 +00:00
Fariborz Jahanian
eb39741c0b More rule enforcement of zero bitfields for ms_struct. 
llvm-svn: 130696
 2011-05-02 17:20:56 +00:00
Fariborz Jahanian
595ec5d43c Some refactoring of my ms_struct patch. 
// rdar://8823265 related.

llvm-svn: 130311
 2011-04-27 17:14:21 +00:00
Fariborz Jahanian
bcb23a180b With ms_struct attribut, Zero-length bitfields following 
non-bitfield members are ignore. // rdar://8823265 wip

llvm-svn: 130257
 2011-04-26 23:52:16 +00:00
Ken Dyck
272b6fa0f0 Simplify AppendTailPadding() by converting its parameter to CharUnits. No 
change in functionality intended.

llvm-svn: 130108
 2011-04-24 16:53:44 +00:00
Ken Dyck
7a0b19f978 Eliminate literal 8s from LayoutUnionField by converting NumBytesToAppend to 
CharUnits. No change in functionality intended.

llvm-svn: 130107
 2011-04-24 16:47:33 +00:00
Ken Dyck
345a6de9b4 Eliminate literal 8s from LayoutBitField(), converting variables to 
CharUnits or replacing the 8s with char align. No change in functionality
intended.

llvm-svn: 130106
 2011-04-24 16:40:29 +00:00
Ken Dyck
27337a8800 Convert AccessInfo::AccessAlignment to CharUnits. No change in functionality 
intended.

llvm-svn: 130087
 2011-04-24 10:13:17 +00:00
Ken Dyck
f76759c6fa Convert CGBitFieldInfo::FieldByteOffset to CharUnits. No change in 
functionality intended.

llvm-svn: 130085
 2011-04-24 10:04:59 +00:00
Anders Carlsson
fcaaa697ec When laying out bases in, always try the "base subobject" LLVM type. If it 
turns out that a field or base needs to be laid out in the tail padding of
the base, CGRecordLayoutBuilder::ResizeLastBaseFieldIfNecessary will convert
it to an array of i8.

I've audited the new test results to make sure that they are still valid. I've
also verified that we pass a self-host with this change.

This (finally) fixes PR5589!

llvm-svn: 129673
 2011-04-17 21:56:13 +00:00
Anders Carlsson
b6d31e7dcc Use a SmallVector for field types in CGRecordLayoutBuilder now that llvm::StructType::get takes an ArrayRef. 
llvm-svn: 129667
 2011-04-17 21:32:41 +00:00
Nick Lewycky
d2348d8d3f Fix typo in comment. 
llvm-svn: 128088
 2011-03-22 17:35:47 +00:00
John McCall
8a3c55567e A much-delayed response to Ken Dyck's review: make this somewhat more 
char-width agnostic.

llvm-svn: 126542
 2011-02-26 08:41:59 +00:00
Chris Lattner
fb59c7c7d8 improve support for big endian targets, fixing PR8171, patch 
by Heikki Kultala!

llvm-svn: 125784
 2011-02-17 22:09:58 +00:00
John McCall
4d9f14234f Refactor CGRecordLayoutBuilder to use CharUnits more consistently. 
llvm-svn: 125605
 2011-02-15 22:21:29 +00:00
John McCall
0217dfc2ba Perform zero-initialization of virtual base classes when emitting 
a zero constant for a complete class.  rdar://problem/8424975

To make this happen, track the field indexes for virtual bases
in the complete object.  I'm curious whether we might be better
off making CGRecordLayoutBuilder *much* more reliant on
ASTRecordLayout;  we're currently duplicating an awful lot of the ABI
layout logic.

llvm-svn: 125555
 2011-02-15 06:40:56 +00:00
Ken Dyck
7ad11e70b6 Convert RecordLayout::Alignment to CharUnits from bit units. No change in 
functionality intended. 

llvm-svn: 125549
 2011-02-15 02:32:40 +00:00
Ken Dyck
b0fcc59e19 Add a helper function, ASTContext::toBits(), that converts sizes in 
CharUnits to sizes in bits, and use it to tidy up the places where the
conversion was done explicitly.

llvm-svn: 125332
 2011-02-11 01:54:29 +00:00
Ken Dyck
89d9f360cd Drop the 'InBits' part from the name of RecordSizeInBits as the value is in 
character units.

llvm-svn: 125281
 2011-02-10 12:36:29 +00:00
Ken Dyck
f18bf0d2e1 Eliminate some signed-to-unsigned comparision warnings introduced in 
r125156.

llvm-svn: 125280
 2011-02-10 12:20:05 +00:00
Ken Dyck
c8ae55050d Convert RecordLayout::Size to CharUnits from bits. No changes to 
functionality intended.

llvm-svn: 125156
 2011-02-09 01:59:34 +00:00
Ken Dyck
bec0285d7f Convert RecordLayout::NonVirtualAlign to CharUnits. No change in 
functionality intended.

llvm-svn: 125069
 2011-02-08 02:02:47 +00:00
Ken Dyck
316d6f69bc Convert RecordLayout::NonVirtualSize from bit units to CharUnits. 
llvm-svn: 124646
 2011-02-01 01:52:10 +00:00
Argyrios Kyrtzidis
648fcbef5b Fix another obscure corner layout case. 
llvm-svn: 121436
 2010-12-10 00:11:00 +00:00
Anders Carlsson
a518b2a5a1 Add a LayoutBase member function. No functionality change. 
llvm-svn: 120924
 2010-12-04 23:59:48 +00:00
Anders Carlsson
d74cad80b0 Replace calls to AppendBytes with calls to AppendPadding when the bytes appended are padding. 
llvm-svn: 120922
 2010-12-04 23:53:18 +00:00
John McCall
bcd38217f3 CGRecordLayoutBuilder does not need to be exported from this module. 
llvm-svn: 120489
 2010-11-30 23:17:27 +00:00
Anders Carlsson
acf877be12 Don't store the maximum alignment, we can trivially compute it. 
llvm-svn: 120268
 2010-11-28 23:06:23 +00:00
Anders Carlsson
a459adb2ff More work on laying out virtual bases. 
llvm-svn: 120257
 2010-11-28 19:18:44 +00:00
Anders Carlsson
1f95ee3016 Begin work on actually laying out virtual bases. 
llvm-svn: 120140
 2010-11-25 01:59:35 +00:00
Anders Carlsson
7f95cd1817 Rename RecordLayout::getPrimaryBaseWasVirtual to isPrimaryBaseVirtual. 
llvm-svn: 120133
 2010-11-24 23:12:57 +00:00
Anders Carlsson
4131f00a1f Add CXXRecordDecl::getIndirectPrimaryBases. 
llvm-svn: 120129
 2010-11-24 22:50:27 +00:00
Anders Carlsson
6277615cbb Simplify code. 
llvm-svn: 120109
 2010-11-24 19:57:04 +00:00
Anders Carlsson
36e2fa8209 CGRecordLayout types are always struct types. 
llvm-svn: 120106
 2010-11-24 19:37:16 +00:00
Anders Carlsson
39a6b22023 Remove FIXME; we don't ever want to lay out empty bases. 
llvm-svn: 119957
 2010-11-22 00:03:08 +00:00
Anders Carlsson
a7dd96ce77 Rename BaseLLVMType to NonVirtualBaseLLVMType. 
llvm-svn: 119956
 2010-11-21 23:59:45 +00:00
Anders Carlsson
e64fbe2a6c Add getCGRecordLayout helper function. No functionality change. 
llvm-svn: 119955
 2010-11-21 23:56:06 +00:00
Nick Lewycky
30d939681c Remove debugging printf. 
Fix linux build.

llvm-svn: 118497
 2010-11-09 09:53:02 +00:00
Anders Carlsson
c1351cac17 Introduce the concept of a non-virtual base type to CGRecordLayoutBuilder as a first step towards fixing PR6995. 
llvm-svn: 118491
 2010-11-09 05:25:47 +00:00
Anders Carlsson
fd88a6160d Rename getBaseClassOffset to getBaseClassOffsetInBits and introduce a getBaseClassOffset which returns the offset in CharUnits. Do the same thing for getVBaseClassOffset. 
llvm-svn: 117881
 2010-10-31 23:22:37 +00:00
Daniel Dunbar
c7f9bbafe4 IRgen: Move CGBitFieldInfo strategy computation helpers to static member 
functions.

llvm-svn: 112913
 2010-09-02 23:53:28 +00:00
John McCall
614dbdcd55 Go back to asking CodeGenTypes whether a type is zero-initializable. 
Make CGT defer to the ABI on all member pointer types.
This requires giving CGT a handle to the ABI.
It's way easier to make that work if we avoid lazily creating the ABI.
Make it so.

llvm-svn: 111786
 2010-08-22 21:01:12 +00:00
Daniel Dunbar
401304462a AST: Rename PragmaPackAttr to MaxFieldAlignmentAttr, which is more accurate. 
llvm-svn: 104795
 2010-05-27 01:12:46 +00:00
Anders Carlsson
be48c548c5 Correctly initialize bases with member pointers. This should fix PR6441 but that test case is a bit weird and I'd like to investigate further before closing that bug. 
llvm-svn: 104025
 2010-05-18 16:51:41 +00:00
Anders Carlsson
061ca524b7 Keep track of the LLVM field numbers for non-virtual bases. 
llvm-svn: 104013
 2010-05-18 05:22:06 +00:00
Anders Carlsson
af9e5afe54 Start laying out bases as individual fields. We still use ugly i8 arrays but this is a step in the right direction. 
llvm-svn: 104012
 2010-05-18 05:12:20 +00:00
Anders Carlsson
58fe1756fb Use a more appropriate LLVM type for the vtable pointer. 
llvm-svn: 103078
 2010-05-05 05:47:36 +00:00
Daniel Dunbar
5981377698 IRgen: Fix another case where we generated an invalid access component when we 
immediately narrowed the access size. Fix this (and previous case) by just
choosing a better access size up-front.

llvm-svn: 102068
 2010-04-22 15:22:33 +00:00
Daniel Dunbar
5d6c07e0e9 IRgen: Fix case where we might generate an access component with width == 0, if 
we have to narrow the access side immediately (can happen with packed,
-fno-bitfield-type-align).

llvm-svn: 102067
 2010-04-22 14:56:10 +00:00
Daniel Dunbar
fc66e0ed87 IRgen: Set alignment correctly on bit-field accesses. 
llvm-svn: 102046
 2010-04-22 03:17:04 +00:00
Daniel Dunbar
488f55c271 IRgen: Rewrite bit-field access policy to not access data beyond the bounds of the structure, which we also now verify as part of the post-layout consistency checks. 
- This fixes some pedantic bugs with packed structures, as well as major problems with -fno-bitfield-type-align.

 - Fixes PR5591, PR5567, and all known -fno-bitfield-type-align issues.

 - Review appreciated.

llvm-svn: 102045
 2010-04-22 02:35:46 +00:00
Daniel Dunbar
b6f4b05914 IRgen: Fix CGRecordLayout::print to print the bit-field infos in a consistent order. 
llvm-svn: 102044
 2010-04-22 02:35:36 +00:00
Daniel Dunbar
2ba67440b6 IRgen: Add checking that the LLVM and AST record layout offsets agree (for 
non-bit-fields).

llvm-svn: 102014
 2010-04-21 19:10:49 +00:00
Daniel Dunbar
20b551a443 IRgen: Always use i8 arrays to access union bit-fields. This is ugly, but 
matches how we currently handle structs, and this correctly handles
-fno-bitfield-type-align.

llvm-svn: 101918
 2010-04-20 17:52:30 +00:00
Daniel Dunbar
ccabe48235 AST: Dump ASTRecordLayout objects when they are created with -fdump-record-layouts. 
llvm-svn: 101815
 2010-04-19 20:44:53 +00:00
Daniel Dunbar
2ea5183b59 IRgen: Kill unused function and move the type match assert to after record dumping. 
llvm-svn: 101814
 2010-04-19 20:44:47 +00:00
Anders Carlsson
d5f27b0583 Simplify wide bit-field layout in CGRecordLayoutBuilder, and also fix a bug where assigning to a bit-field member would overwrite other parts of the struct. 
llvm-svn: 101681
 2010-04-17 22:54:57 +00:00
Anders Carlsson
2295f13bb0 Unnamed bit-fields in a union should be laid out with a type that doesn't affect alignment. 
llvm-svn: 101673
 2010-04-17 21:04:52 +00:00
Anders Carlsson
1de2f5710b Factor union field layout code out into a separate function. No functionality change. 
llvm-svn: 101671
 2010-04-17 20:49:27 +00:00
Anders Carlsson
11e5140db9 Vtable -> VTable renames across the board. 
llvm-svn: 101666
 2010-04-17 20:15:18 +00:00
Anders Carlsson
be6f3181dd Make CGRecordLayoutBuilder deal with wide bit-fields. Will land tests shortly (Daniel, please review). 
llvm-svn: 101472
 2010-04-16 16:23:02 +00:00
Daniel Dunbar
9c78d63fbc IRgen: Change CGBitFieldInfo to take the AccessInfo as constructor arguments, it is now an immutable object. 
Also, add some checking of various invariants that should hold on the CGBitFieldInfo access.

llvm-svn: 101345
 2010-04-15 05:09:32 +00:00
Daniel Dunbar
bb13845c5f IRgen: Eliminate now unused fields from CGBitFieldInfo. 
llvm-svn: 101344
 2010-04-15 05:09:28 +00:00
Daniel Dunbar
b935b9370d IRgen: Enhance CGBitFieldInfo with enough information to fully describe the "policy" with which a bit-field should be accessed. 
- For now, these policies are computed to match the current IRgen strategy, although the new information isn't being used yet (except in -fdump-record-layouts).

 - Design comments appreciated.

llvm-svn: 101178
 2010-04-13 20:58:55 +00:00
Daniel Dunbar
f9c24f8403 IRgen: Factor out ComputeBitFieldInfo. 
llvm-svn: 101066
 2010-04-12 21:01:28 +00:00
Daniel Dunbar
b97bff9aa9 IRgen: Add CGRecordLayout::dump, and dump (irgen) record layouts as part of -fdump-record-layouts. 
llvm-svn: 101051
 2010-04-12 18:14:18 +00:00
Daniel Dunbar
c75c8bd757 IRgen: Move the bit-field access type into CGBitFieldInfo, and change bit-field LValues to just store the base address of object containing the bit-field. 
llvm-svn: 100745
 2010-04-08 02:59:45 +00:00
Daniel Dunbar
196ea449ed IRgen: Move BitFieldIsSigned bit into CGBitFieldInfo. 
llvm-svn: 100513
 2010-04-06 01:07:44 +00:00
Daniel Dunbar
d45491077a Simplify. 
llvm-svn: 100512
 2010-04-06 01:07:41 +00:00
Daniel Dunbar
cd3d5e76ce IRgen: Lift BitFieldInfo to CGBitFieldInfo at namespace level. 
llvm-svn: 100433
 2010-04-05 16:20:44 +00:00
Daniel Dunbar
034299ef25 IRGen: Move the auxiliary data structures tracking AST -> LLVM mappings out of CodeGenTypes, to per-record CGRecordLayout structures. 
- I did a cursory check that this was perf neutral, FWIW.

llvm-svn: 99978
 2010-03-31 01:09:11 +00:00
Daniel Dunbar
e75a64f2d3 CGRecordLayoutBuilder: Switch unions to use same mechanism for tracking field and bit-field info as structs. 
- Anders, please check.

llvm-svn: 99977
 2010-03-31 00:55:13 +00:00
Daniel Dunbar
23ee4b7710 IRGen: Hide CGRecordLayoutBuilder class, because I can. 
llvm-svn: 99967
 2010-03-31 00:11:27 +00:00
Daniel Dunbar
072d0bb247 IRgen: Move CGRecordLayout to its own happy little file. 
llvm-svn: 99945
 2010-03-30 22:26:10 +00:00
Anders Carlsson
e8bfe412ec Improve handling of emitting 'null' pointers to data members. 
llvm-svn: 95066
 2010-02-02 05:17:25 +00:00
Anders Carlsson
b1ef991097 Fix an incorrect union layout assert. Fixes PR6164. 
llvm-svn: 94754
 2010-01-28 18:22:03 +00:00
Anders Carlsson
d681a29ac0 Baby steps towards fixing PR5589. If a class needs a vtable pointer, add one. 
llvm-svn: 91545
 2009-12-16 17:27:20 +00:00
Anders Carlsson
220bf4fc5a No need to add tail padding if the resulting LLVM struct type will have the same size as the final record size. 
llvm-svn: 90820
 2009-12-08 01:24:23 +00:00
Anders Carlsson
b1d3f7c909 Have ASTRecordLayout keep track of the key function, in preparation of fixing a synthetic ctor/dtor bug. 
llvm-svn: 90168
 2009-11-30 23:41:22 +00:00
Mike Stump
a7a1b7e780 Fixup key function calculations. 
llvm-svn: 89412
 2009-11-20 00:02:19 +00:00
Mike Stump
beab381d2d This doesn't work yet. 
llvm-svn: 89307
 2009-11-19 03:53:54 +00:00
Fariborz Jahanian
e8e631c912 Prevent a code gen. crash on empty unions - pr5408. 
llvm-svn: 86287
 2009-11-06 20:47:40 +00:00
Anders Carlsson
1d116976b4 Store the key function of a record decl inside CGRecordLayout. 
llvm-svn: 83900
 2009-10-12 21:16:22 +00:00
Mike Stump
11289f4280 Remove tabs, and whitespace cleanups. 
llvm-svn: 81346
 2009-09-09 15:08:12 +00:00
Anders Carlsson
0e91275ab4 If the alignment of the chosen field in a union is greater than the alignment of the union, we need to use a packed LLVM struct. Fixes <rdar://problem/7184250>. 
llvm-svn: 80964
 2009-09-03 22:56:02 +00:00
Anders Carlsson
09a3774cd3 Packed unions should be packed. Fixes an assert Daniel reported. 
llvm-svn: 80808
 2009-09-02 17:51:33 +00:00
Anders Carlsson
d606de72ab More work towards zero-initializing structs that contain member pointers in constant expressions. 
llvm-svn: 79805
 2009-08-23 01:25:01 +00:00
Anders Carlsson
beac2bef4d Remove the PaddingFields member from CGRecordLayout, it wasn't used anyway. 
llvm-svn: 79799
 2009-08-23 01:01:04 +00:00
Owen Anderson
41a750271b Update for LLVM API change. 
llvm-svn: 78946
 2009-08-13 21:57:51 +00:00
Anders Carlsson
28a5fa29f3 Take #pragma pack into account when laying out structs. Fixes rdar://problem/7095436. 
llvm-svn: 78490
 2009-08-08 19:38:24 +00:00
Anders Carlsson
68e0b68289 Introduce a new PragmaPack attribute, and use it for #pragma pack. The PackedAttr now only represents __attribute__((packed)). 
This is necessary because #pragma pack and __attribute__((packed)) have different semantics. No functionality change yet, but this lays the groundwork for fixing a record layout bug.

llvm-svn: 78483
 2009-08-08 18:23:56 +00:00
Anders Carlsson
453878bed4 Assert that the LLVM type has the same size as the RecordDecl size. 
llvm-svn: 78481
 2009-08-08 18:01:57 +00:00
Owen Anderson
758428f4e3 Update for LLVM API change. 
llvm-svn: 78259
 2009-08-05 23:18:46 +00:00
Anders Carlsson
19702bb054 Simplify alignment handling in the record builder. 
llvm-svn: 78069
 2009-08-04 16:29:15 +00:00
Fariborz Jahanian
7be1ad814b No longer need to keep base class offsets in the offset 
table as it has its own place now.

llvm-svn: 77491
 2009-07-29 18:50:06 +00:00
Anders Carlsson
d5d6413aa5 More CGRecordLayoutBuilder cleanup. 
llvm-svn: 77335
 2009-07-28 17:56:36 +00:00
Fariborz Jahanian
7b2b1ec6b1 Some minor changes toward support of data 
member access in the presense of non-virtual bases.

llvm-svn: 77246
 2009-07-27 20:57:45 +00:00
Anders Carlsson
72fb384a65 Enable the new struct type builder now that the constant struct builder works. (The old code will still be there until we know that everything works well. 
llvm-svn: 77190
 2009-07-27 15:31:55 +00:00