Gericom/teak-llvm
1
Fork 0
mirror of https://github.com/Gericom/teak-llvm.git synced 2025-06-19 11:35:51 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Keep symbols passed by -init and -fini

Browse Source 
Previously, symbols passed by -init and -fini look as if they are
not referenced by anyone, and the LTO might eliminate them.
This patch fixes the issue.

Fixes a bug reported in https://bugs.llvm.org/show_bug.cgi?id=43927

Differential Revision: https://reviews.llvm.org/D69985
This commit is contained in:
Rui Ueyama 2019-11-08 14:39:14 +09:00
parent 41449c58c5
commit f95273f75a
2 changed files with 44 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lld/ELF/Driver.cpp
View File

@ -1782,6 +1782,12 @@ template <class ELFT> void LinkerDriver::link(opt::InputArgList &args) {
for (StringRef pat : args::getStrings(args, OPT_undefined_glob))
handleUndefinedGlob(pat);
// Mark -init and -fini symbols so that the LTO doesn't eliminate them.
if (Symbol *sym = symtab->find(config->init))
sym->isUsedInRegularObj = true;
if (Symbol *sym = symtab->find(config->fini))
sym->isUsedInRegularObj = true;
// If any of our inputs are bitcode files, the LTO code generator may create
// references to certain library functions that might not be explicit in the
// bitcode file's symbol table. If any of those library functions are defined

38
lld/test/ELF/lto/init-fini.ll Normal file
View File

@ -0,0 +1,38 @@
; REQUIRES: x86
; RUN: llvm-as %s -o %t.o
;;
;; Verify that symbols given by -init and -fini are preserved and
;; DT_INIT/DT_FINI are created.
;;
; RUN: ld.lld -o %t.exe -pie %t.o
; RUN: llvm-nm %t.exe | FileCheck -check-prefix=TEST1 --allow-empty %s
; RUN: llvm-readelf -d %t.exe | FileCheck -check-prefix=TEST2 %s
; TEST1-NOT: foo
; TEST1-NOT: bar
; TEST2-NOT: INIT
; TEST2-NOT: FINI
; RUN: ld.lld -o %t.exe -pie -init=foo -fini=bar %t.o
; RUN: llvm-nm %t.exe | FileCheck -check-prefix=TEST3 %s
; RUN: llvm-readelf -d %t.exe | FileCheck -check-prefix=TEST4 %s
; TEST3: bar
; TEST3: foo
; TEST4: INIT
; TEST4: FINI
target triple = "x86_64-unknown-linux-gnu"
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
define void @foo() {
ret void
}
define void @bar() {
ret void
}