[CodeGen][NFC] Rename IsVerbose to IsStandalone in Machine*::print

Committed r322867 too soon.

Differential Revision: https://reviews.llvm.org/D42239

llvm-svn: 322868
This commit is contained in:
Francis Visoiu Mistrih 2018-01-18 18:05:15 +00:00
parent 378b5f3de6
commit eb3f76fc83
10 changed files with 26 additions and 25 deletions

View File

@ -726,9 +726,9 @@ public:
// Debugging methods. // Debugging methods.
void dump() const; void dump() const;
void print(raw_ostream &OS, const SlotIndexes * = nullptr, void print(raw_ostream &OS, const SlotIndexes * = nullptr,
bool IsVerbose = true) const; bool IsStandalone = true) const;
void print(raw_ostream &OS, ModuleSlotTracker &MST, void print(raw_ostream &OS, ModuleSlotTracker &MST,
const SlotIndexes * = nullptr, bool IsVerbose = true) const; const SlotIndexes * = nullptr, bool IsStandalone = true) const;
// Printing method used by LoopInfo. // Printing method used by LoopInfo.
void printAsOperand(raw_ostream &OS, bool PrintType = true) const; void printAsOperand(raw_ostream &OS, bool PrintType = true) const;

View File

@ -1234,17 +1234,17 @@ public:
/// Print this MI to \p OS. /// Print this MI to \p OS.
/// Don't print information that can be inferred from other instructions if /// Don't print information that can be inferred from other instructions if
/// \p IsVerbose is false. It is usually true when only a fragment of the /// \p IsStandalone is false. It is usually true when only a fragment of the
/// function is printed. /// function is printed.
/// Only print the defs and the opcode if \p SkipOpers is true. /// Only print the defs and the opcode if \p SkipOpers is true.
/// Otherwise, also print operands if \p SkipDebugLoc is true. /// Otherwise, also print operands if \p SkipDebugLoc is true.
/// Otherwise, also print the debug loc, with a terminating newline. /// Otherwise, also print the debug loc, with a terminating newline.
/// \p TII is used to print the opcode name. If it's not present, but the /// \p TII is used to print the opcode name. If it's not present, but the
/// MI is in a function, the opcode will be printed using the function's TII. /// MI is in a function, the opcode will be printed using the function's TII.
void print(raw_ostream &OS, bool IsVerbose = true, bool SkipOpers = false, void print(raw_ostream &OS, bool IsStandalone = true, bool SkipOpers = false,
bool SkipDebugLoc = false, bool SkipDebugLoc = false,
const TargetInstrInfo *TII = nullptr) const; const TargetInstrInfo *TII = nullptr) const;
void print(raw_ostream &OS, ModuleSlotTracker &MST, bool IsVerbose = true, void print(raw_ostream &OS, ModuleSlotTracker &MST, bool IsStandalone = true,
bool SkipOpers = false, bool SkipDebugLoc = false, bool SkipOpers = false, bool SkipDebugLoc = false,
const TargetInstrInfo *TII = nullptr) const; const TargetInstrInfo *TII = nullptr) const;
void dump() const; void dump() const;

View File

@ -270,7 +270,7 @@ public:
/// \param PrintDef - whether we want to print `def` on an operand which /// \param PrintDef - whether we want to print `def` on an operand which
/// isDef. Sometimes, if the operand is printed before '=', we don't print /// isDef. Sometimes, if the operand is printed before '=', we don't print
/// `def`. /// `def`.
/// \param IsVerbose - whether we want a verbose output of the MO. This /// \param IsStandalone - whether we want a verbose output of the MO. This
/// prints extra information that can be easily inferred when printing the /// prints extra information that can be easily inferred when printing the
/// whole function, but not when printing only a fragment of it. /// whole function, but not when printing only a fragment of it.
/// \param ShouldPrintRegisterTies - whether we want to print register ties. /// \param ShouldPrintRegisterTies - whether we want to print register ties.
@ -283,7 +283,7 @@ public:
/// information from it's parent. /// information from it's parent.
/// \param IntrinsicInfo - same as \p TRI. /// \param IntrinsicInfo - same as \p TRI.
void print(raw_ostream &os, ModuleSlotTracker &MST, LLT TypeToPrint, void print(raw_ostream &os, ModuleSlotTracker &MST, LLT TypeToPrint,
bool PrintDef, bool IsVerbose, bool ShouldPrintRegisterTies, bool PrintDef, bool IsStandalone, bool ShouldPrintRegisterTies,
unsigned TiedOperandIdx, const TargetRegisterInfo *TRI, unsigned TiedOperandIdx, const TargetRegisterInfo *TRI,
const TargetIntrinsicInfo *IntrinsicInfo) const; const TargetIntrinsicInfo *IntrinsicInfo) const;

View File

@ -768,7 +768,7 @@ void MIPrinter::print(const MachineInstr &MI, unsigned OpIdx,
if (ShouldPrintRegisterTies && Op.isReg() && Op.isTied() && !Op.isDef()) if (ShouldPrintRegisterTies && Op.isReg() && Op.isTied() && !Op.isDef())
TiedOperandIdx = Op.getParent()->findTiedOperandIdx(OpIdx); TiedOperandIdx = Op.getParent()->findTiedOperandIdx(OpIdx);
const TargetIntrinsicInfo *TII = MI.getMF()->getTarget().getIntrinsicInfo(); const TargetIntrinsicInfo *TII = MI.getMF()->getTarget().getIntrinsicInfo();
Op.print(OS, MST, TypeToPrint, PrintDef, /*IsVerbose=*/false, Op.print(OS, MST, TypeToPrint, PrintDef, /*IsStandalone=*/false,
ShouldPrintRegisterTies, TiedOperandIdx, TRI, TII); ShouldPrintRegisterTies, TiedOperandIdx, TRI, TII);
break; break;
} }

View File

@ -260,7 +260,7 @@ std::string MachineBasicBlock::getFullName() const {
} }
void MachineBasicBlock::print(raw_ostream &OS, const SlotIndexes *Indexes, void MachineBasicBlock::print(raw_ostream &OS, const SlotIndexes *Indexes,
bool IsVerbose) const { bool IsStandalone) const {
const MachineFunction *MF = getParent(); const MachineFunction *MF = getParent();
if (!MF) { if (!MF) {
OS << "Can't print out MachineBasicBlock because parent MachineFunction" OS << "Can't print out MachineBasicBlock because parent MachineFunction"
@ -270,12 +270,12 @@ void MachineBasicBlock::print(raw_ostream &OS, const SlotIndexes *Indexes,
const Function &F = MF->getFunction(); const Function &F = MF->getFunction();
const Module *M = F.getParent(); const Module *M = F.getParent();
ModuleSlotTracker MST(M); ModuleSlotTracker MST(M);
print(OS, MST, Indexes, IsVerbose); print(OS, MST, Indexes, IsStandalone);
} }
void MachineBasicBlock::print(raw_ostream &OS, ModuleSlotTracker &MST, void MachineBasicBlock::print(raw_ostream &OS, ModuleSlotTracker &MST,
const SlotIndexes *Indexes, const SlotIndexes *Indexes,
bool IsVerbose) const { bool IsStandalone) const {
const MachineFunction *MF = getParent(); const MachineFunction *MF = getParent();
if (!MF) { if (!MF) {
OS << "Can't print out MachineBasicBlock because parent MachineFunction" OS << "Can't print out MachineBasicBlock because parent MachineFunction"
@ -331,7 +331,7 @@ void MachineBasicBlock::print(raw_ostream &OS, ModuleSlotTracker &MST,
OS << '\t'; OS << '\t';
if (I.isInsideBundle()) if (I.isInsideBundle())
OS << " * "; OS << " * ";
I.print(OS, MST, IsVerbose); I.print(OS, MST, IsStandalone);
} }
// Print the successors of this block according to the CFG. // Print the successors of this block according to the CFG.

View File

@ -524,7 +524,7 @@ void MachineFunction::print(raw_ostream &OS, const SlotIndexes *Indexes) const {
OS << '\n'; OS << '\n';
// If we print the whole function, don't print any verbose information, // If we print the whole function, don't print any verbose information,
// since that information is already present. // since that information is already present.
BB.print(OS, MST, Indexes, /*IsVerbose=*/false); BB.print(OS, MST, Indexes, /*IsStandalone=*/false);
} }
OS << "\n# End machine code for function " << getName() << ".\n\n"; OS << "\n# End machine code for function " << getName() << ".\n\n";

View File

@ -1229,7 +1229,7 @@ LLVM_DUMP_METHOD void MachineInstr::dump() const {
} }
#endif #endif
void MachineInstr::print(raw_ostream &OS, bool IsVerbose, bool SkipOpers, void MachineInstr::print(raw_ostream &OS, bool IsStandalone, bool SkipOpers,
bool SkipDebugLoc, const TargetInstrInfo *TII) const { bool SkipDebugLoc, const TargetInstrInfo *TII) const {
const Module *M = nullptr; const Module *M = nullptr;
const Function *F = nullptr; const Function *F = nullptr;
@ -1241,11 +1241,11 @@ void MachineInstr::print(raw_ostream &OS, bool IsVerbose, bool SkipOpers,
ModuleSlotTracker MST(M); ModuleSlotTracker MST(M);
if (F) if (F)
MST.incorporateFunction(*F); MST.incorporateFunction(*F);
print(OS, MST, IsVerbose, SkipOpers, SkipDebugLoc, TII); print(OS, MST, IsStandalone, SkipOpers, SkipDebugLoc, TII);
} }
void MachineInstr::print(raw_ostream &OS, ModuleSlotTracker &MST, void MachineInstr::print(raw_ostream &OS, ModuleSlotTracker &MST,
bool IsVerbose, bool SkipOpers, bool SkipDebugLoc, bool IsStandalone, bool SkipOpers, bool SkipDebugLoc,
const TargetInstrInfo *TII) const { const TargetInstrInfo *TII) const {
// We can be a bit tidier if we know the MachineFunction. // We can be a bit tidier if we know the MachineFunction.
const MachineFunction *MF = nullptr; const MachineFunction *MF = nullptr;
@ -1281,7 +1281,7 @@ void MachineInstr::print(raw_ostream &OS, ModuleSlotTracker &MST,
LLT TypeToPrint = MRI ? getTypeToPrint(StartOp, PrintedTypes, *MRI) : LLT{}; LLT TypeToPrint = MRI ? getTypeToPrint(StartOp, PrintedTypes, *MRI) : LLT{};
unsigned TiedOperandIdx = getTiedOperandIdx(StartOp); unsigned TiedOperandIdx = getTiedOperandIdx(StartOp);
MO.print(OS, MST, TypeToPrint, /*PrintDef=*/false, IsVerbose, MO.print(OS, MST, TypeToPrint, /*PrintDef=*/false, IsStandalone,
ShouldPrintRegisterTies, TiedOperandIdx, TRI, IntrinsicInfo); ShouldPrintRegisterTies, TiedOperandIdx, TRI, IntrinsicInfo);
++StartOp; ++StartOp;
} }
@ -1314,7 +1314,7 @@ void MachineInstr::print(raw_ostream &OS, ModuleSlotTracker &MST,
const unsigned OpIdx = InlineAsm::MIOp_AsmString; const unsigned OpIdx = InlineAsm::MIOp_AsmString;
LLT TypeToPrint = MRI ? getTypeToPrint(OpIdx, PrintedTypes, *MRI) : LLT{}; LLT TypeToPrint = MRI ? getTypeToPrint(OpIdx, PrintedTypes, *MRI) : LLT{};
unsigned TiedOperandIdx = getTiedOperandIdx(OpIdx); unsigned TiedOperandIdx = getTiedOperandIdx(OpIdx);
getOperand(OpIdx).print(OS, MST, TypeToPrint, /*PrintDef=*/true, IsVerbose, getOperand(OpIdx).print(OS, MST, TypeToPrint, /*PrintDef=*/true, IsStandalone,
ShouldPrintRegisterTies, TiedOperandIdx, TRI, ShouldPrintRegisterTies, TiedOperandIdx, TRI,
IntrinsicInfo); IntrinsicInfo);
@ -1353,7 +1353,7 @@ void MachineInstr::print(raw_ostream &OS, ModuleSlotTracker &MST,
else { else {
LLT TypeToPrint = MRI ? getTypeToPrint(i, PrintedTypes, *MRI) : LLT{}; LLT TypeToPrint = MRI ? getTypeToPrint(i, PrintedTypes, *MRI) : LLT{};
unsigned TiedOperandIdx = getTiedOperandIdx(i); unsigned TiedOperandIdx = getTiedOperandIdx(i);
MO.print(OS, MST, TypeToPrint, /*PrintDef=*/true, IsVerbose, MO.print(OS, MST, TypeToPrint, /*PrintDef=*/true, IsStandalone,
ShouldPrintRegisterTies, TiedOperandIdx, TRI, IntrinsicInfo); ShouldPrintRegisterTies, TiedOperandIdx, TRI, IntrinsicInfo);
} }
} else if (i == AsmDescOp && MO.isImm()) { } else if (i == AsmDescOp && MO.isImm()) {
@ -1420,7 +1420,7 @@ void MachineInstr::print(raw_ostream &OS, ModuleSlotTracker &MST,
if (MO.isImm() && isOperandSubregIdx(i)) if (MO.isImm() && isOperandSubregIdx(i))
MachineOperand::printSubRegIdx(OS, MO.getImm(), TRI); MachineOperand::printSubRegIdx(OS, MO.getImm(), TRI);
else else
MO.print(OS, MST, TypeToPrint, /*PrintDef=*/true, IsVerbose, MO.print(OS, MST, TypeToPrint, /*PrintDef=*/true, IsStandalone,
ShouldPrintRegisterTies, TiedOperandIdx, TRI, IntrinsicInfo); ShouldPrintRegisterTies, TiedOperandIdx, TRI, IntrinsicInfo);
} }
} }

View File

@ -641,13 +641,13 @@ void MachineOperand::print(raw_ostream &OS, const TargetRegisterInfo *TRI,
const TargetIntrinsicInfo *IntrinsicInfo) const { const TargetIntrinsicInfo *IntrinsicInfo) const {
tryToGetTargetInfo(*this, TRI, IntrinsicInfo); tryToGetTargetInfo(*this, TRI, IntrinsicInfo);
ModuleSlotTracker DummyMST(nullptr); ModuleSlotTracker DummyMST(nullptr);
print(OS, DummyMST, LLT{}, /*PrintDef=*/false, /*IsVerbose=*/true, print(OS, DummyMST, LLT{}, /*PrintDef=*/false, /*IsStandalone=*/true,
/*ShouldPrintRegisterTies=*/true, /*ShouldPrintRegisterTies=*/true,
/*TiedOperandIdx=*/0, TRI, IntrinsicInfo); /*TiedOperandIdx=*/0, TRI, IntrinsicInfo);
} }
void MachineOperand::print(raw_ostream &OS, ModuleSlotTracker &MST, void MachineOperand::print(raw_ostream &OS, ModuleSlotTracker &MST,
LLT TypeToPrint, bool PrintDef, bool IsVerbose, LLT TypeToPrint, bool PrintDef, bool IsStandalone,
bool ShouldPrintRegisterTies, bool ShouldPrintRegisterTies,
unsigned TiedOperandIdx, unsigned TiedOperandIdx,
const TargetRegisterInfo *TRI, const TargetRegisterInfo *TRI,
@ -687,7 +687,7 @@ void MachineOperand::print(raw_ostream &OS, ModuleSlotTracker &MST,
if (TargetRegisterInfo::isVirtualRegister(Reg)) { if (TargetRegisterInfo::isVirtualRegister(Reg)) {
if (const MachineFunction *MF = getMFIfAvailable(*this)) { if (const MachineFunction *MF = getMFIfAvailable(*this)) {
const MachineRegisterInfo &MRI = MF->getRegInfo(); const MachineRegisterInfo &MRI = MF->getRegInfo();
if (IsVerbose || !PrintDef || MRI.def_empty(Reg)) { if (IsStandalone || !PrintDef || MRI.def_empty(Reg)) {
OS << ':'; OS << ':';
OS << printRegClassOrBank(Reg, MRI, TRI); OS << printRegClassOrBank(Reg, MRI, TRI);
} }

View File

@ -27,7 +27,8 @@ DiagnosticInfoMIROptimization::MachineArgument::MachineArgument(
Key = MKey; Key = MKey;
raw_string_ostream OS(Val); raw_string_ostream OS(Val);
MI.print(OS, /*IsVerbose=*/true, /*SkipOpers=*/false, /*SkipDebugLoc=*/true); MI.print(OS, /*IsStandalone=*/true, /*SkipOpers=*/false,
/*SkipDebugLoc=*/true);
} }
Optional<uint64_t> Optional<uint64_t>

View File

@ -311,7 +311,7 @@ TEST(MachineOperandTest, PrintMetadata) {
std::string str; std::string str;
// Print a MachineOperand containing a metadata node. // Print a MachineOperand containing a metadata node.
raw_string_ostream OS(str); raw_string_ostream OS(str);
MO.print(OS, MST, LLT{}, /*PrintDef=*/false, /*IsVerbose=*/false, MO.print(OS, MST, LLT{}, /*PrintDef=*/false, /*IsStandalone=*/false,
/*ShouldPrintRegisterTies=*/false, 0, /*TRI=*/nullptr, /*ShouldPrintRegisterTies=*/false, 0, /*TRI=*/nullptr,
/*IntrinsicInfo=*/nullptr); /*IntrinsicInfo=*/nullptr);
ASSERT_TRUE(OS.str() == "!0"); ASSERT_TRUE(OS.str() == "!0");