GerbilSoft/rom-properties
1
Fork 0
mirror of https://github.com/GerbilSoft/rom-properties.git synced 2025-06-18 11:35:38 -04:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[kde,win32] initDimensions() functions: Don't store the string temporarily.

Browse Source 
Inline the formatDimensions() call into the initString() call.

This doesn't affect the code size in either debug or release builds.
This commit is contained in:
David Korth 2025-02-01 10:30:55 -05:00
parent ff23009961
commit f4318755e6
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/kde/RomDataView.cpp
View File

@ -732,8 +732,7 @@ QLabel *RomDataViewPrivate::initDimensions(QLabel *lblDesc,
{
// Dimensions
const int *const dimensions = field.data.dimensions;
const QString str = formatDimensions(dimensions);
return initString(lblDesc, field, str);
return initString(lblDesc, field, formatDimensions(dimensions));
}
/**

4
src/win32/RP_ShellPropSheetExt.cpp
View File

@ -1324,8 +1324,8 @@ int RP_ShellPropSheetExt_Private::initDimensions(_In_ HWND hWndTab,
{
// TODO: 'x' or '×'? Using 'x' for now.
const int *const dimensions = field.data.dimensions;
const tstring tstr = formatDimensions(dimensions);
return initString(hWndTab, pt_start, size, field, fieldIdx, tstr.c_str());
return initString(hWndTab, pt_start, size, field, fieldIdx,
formatDimensions(dimensions).c_str());
}
/**