GerbilSoft/rom-properties
1
Fork 0
mirror of https://github.com/GerbilSoft/rom-properties.git synced 2025-06-18 19:45:41 -04:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[librptexture] ImageDecoder::fromLinear32_ssse3(): Missed a 16-byte stride alignment check.

Browse Source 
xtexconv includes a sample DDS that has stride == 15,076. Without this
check, rpcli crashes due to the use of movdqa on an unaligned pointer.

Reference: https://learn.microsoft.com/en-us/samples/microsoft/xbox-gdk-samples/xtexconv/
This commit is contained in:
David Korth 2025-05-11 03:06:29 -04:00
parent f6d9394da8
commit f13bde810f
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/librptexture/decoder/ImageDecoder_Linear_ssse3.cpp
View File

@ -3,7 +3,7 @@
* ImageDecoder_Linear.cpp: Image decoding functions: Linear *
* SSSE3-optimized version. *
* *
* Copyright (c) 2016-2024 by David Korth. *
* Copyright (c) 2016-2025 by David Korth. *
* SPDX-License-Identifier: GPL-2.0-or-later *
***************************************************************************/
@ -229,6 +229,10 @@ rp_image_ptr fromLinear32_ssse3(PixelFormat px_format,
if (unlikely(stride % bytespp != 0 || stride < (width * bytespp))) {
// Invalid stride.
return nullptr;
} else if (unlikely((stride % 16 != 0) && px_format != PixelFormat::Host_ARGB32)) {
// Unaligned stride.
// Use the C++ version.
return fromLinear32_cpp(px_format, width, height, img_buf, img_siz, stride);
}
src_stride_adj = (stride / bytespp) - width;
} else {