GerbilSoft/rom-properties
1
Fork 0
mirror of https://github.com/GerbilSoft/rom-properties.git synced 2025-06-18 19:45:41 -04:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[libromdata/tests] GcnFstTest: Use 0UL instead of 0 when comparing to file_info.size_filename.

Browse Source 
extlib\googletest\googletest\include\gtest/gtest.h(1444): error C2220: warning treated as error - no 'object' file generated (compiling source file src\libromdata\tests\disc\GcnFstTest.cpp)
  src\libromdata\tests\disc\GcnFstTest.cpp(546): note: see reference to function template instantiation 'testing::AssertionResult testing::internal::CmpHelperGT<unsigned long,int>(const char *,const char *,const T1 &,const T2 &)' being compiled
          with
          [
              T1=unsigned long,
              T2=int
          ]
extlib\googletest\googletest\include\gtest/gtest.h(1444): warning C4018: '>': signed/unsigned mismatch (compiling source file src\libromdata\tests\disc\GcnFstTest.cpp)
This commit is contained in:
David Korth 2025-04-01 03:49:53 -04:00
parent 543b2580b7
commit cb93a103a3
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/libromdata/tests/disc/GcnFstTest.cpp
View File

@ -543,13 +543,13 @@ std::vector<GcnFstTest_mode> GcnFstTest::ReadTestCasesFromDisk(uint8_t offsetShi
break;
// Make sure the filename isn't empty.
EXPECT_GT(file_info.size_filename, 0) << "A filename in the ZIP file has no name. Skipping...";
EXPECT_GT(file_info.size_filename, 0UL) << "A filename in the ZIP file has no name. Skipping...";
// Make sure the file isn't too big.
EXPECT_LE(file_info.uncompressed_size, MAX_GCN_FST_BIN_FILESIZE) <<
"GCN FST file '" << filename << "' is too big. (maximum size is 1 MB)";
if (file_info.size_filename > 0 &&
if (file_info.size_filename > 0UL &&
file_info.uncompressed_size <= MAX_GCN_FST_BIN_FILESIZE)
{
// Add this filename to the list.