GerbilSoft/rom-properties
1
Fork 0
mirror of https://github.com/GerbilSoft/rom-properties.git synced 2025-06-18 11:35:38 -04:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[librptexture] ICOPrivate::~ICOPrivate(): Use dir.is_res instead of isResource().
Some checks failed
Codecov / run (push) Has been cancelled
Details
CodeQL / Analyze (cpp) (push) Has been cancelled
Details

Browse Source 
Removed isResource().
This commit is contained in:
David Korth 2025-06-13 18:35:18 -04:00
parent 73eb28c4ee
commit b19f128903
1 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/librptexture/fileformat/ICO.cpp
View File

@ -85,15 +85,6 @@ public:
/** Win3.x icon stuff **/
/**
* Is this an icon resource from a .exe/.dll?
* @return True if it's a resource; false if it's a .ico file.
*/
inline bool isResource(void) const
{
return (iconType >= IconType::IconRes_Win1) && (iconType <= IconType::CursorRes_Win3);
}
// NOTE: ICONDIRENTRY (for .ico files) and GRPICONDIRENTRY (for resources)
// are different sizes. Hence, we have to use this union of struct pointers hack.
struct icodir_ico {
@ -311,7 +302,7 @@ ICOPrivate::ICOPrivate(ICO *q, const IResourceReaderPtr &resReader, uint16_t typ
ICOPrivate::~ICOPrivate()
{
if (dir.v) {
if (isResource()) {
if (dir.is_res) {
delete dir.res;
} else {
delete dir.ico;