GerbilSoft/rom-properties
1
Fork 0
mirror of https://github.com/GerbilSoft/rom-properties.git synced 2025-06-19 03:55:43 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

[rpcli] DoScsiInquiry(): Fix an inverted condition that broke SCSI inquiry.

Browse Source 
It was showing an error if the file specified was in fact a device file,
which prevents it from working.

This fixes a regression from commit 837315505e.
([rpcli] rpcli.cpp: Un-indent a few functions.)

Affects: v2.3 - v2.5
This commit is contained in:
David Korth 2025-04-22 19:51:44 -04:00
parent 3bbe0f63c5
commit 8e48fd28f1
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
NEWS.md
View File

@ -7,6 +7,8 @@
* Affects: v2.4 - v2.5 * Affects: v2.4 - v2.5
* EXE: Don't show the "XML parsing failed" warning if the EXE doesn't * EXE: Don't show the "XML parsing failed" warning if the EXE doesn't
actually have a manifest. actually have a manifest.
* rpcli: SCSI inquiry was accidentally broken during a code cleanup.
* Affects: v2.3 - v2.5
* Other changes: * Other changes:
* Added support for localsearch-3.8, the new name of Tracker. * Added support for localsearch-3.8, the new name of Tracker.

2
src/rpcli/rpcli.cpp
View File

@ -457,7 +457,7 @@ static void DoScsiInquiry(const TCHAR *filename, bool json)
} }
// TODO: Check for unsupported devices? (Only CD-ROM is supported.) // TODO: Check for unsupported devices? (Only CD-ROM is supported.)
if (file->isDevice()) { if (!file->isDevice()) {
// TODO: Return an error code? // TODO: Return an error code?
fputs("-- ", stderr); fputs("-- ", stderr);
fputs(C_("rpcli", "Not a device file"), stderr); fputs(C_("rpcli", "Not a device file"), stderr);